Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp2246236pxv;
        Sat, 17 Jul 2021 08:04:49 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwf81x++tYE3EyiWoIC9/bOqnI602Fe0CqztaT1RsZ5lf7Vag784O+vSdNtLW82sPN7CDV6
X-Received: by 2002:a50:ee87:: with SMTP id f7mr22214657edr.155.1626534289050;
        Sat, 17 Jul 2021 08:04:49 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1626534289; cv=none;
        d=google.com; s=arc-20160816;
        b=huN3LvhZAG6/XI/45aYtz9Aziuuu77ISCxBcQAVxQz868qlsn1XIfsQancyO3yGlze
         jup7yVUv4XTuCG8bsqYk/bdUjqycw0DXpSSXT4M4raLzQwqg/gcZsQ/N72K9BShGrMhY
         kt7XxaqEbgwQwWEccl6rKpKZZGQ6f05fXMZQpPMHUVnLS7kIJR0/3MkHiwhlLgSlvllj
         k6swVL4LBbDsTFAT1EtjX3aYadD+PiHXurb5p910vpk17XG5d7IelHPYFAngkJP57HGq
         oN8x4///GcU5kVQqZxjG6XBjZcBNLWklAgpq/CmJhIwoWdvlcXuI4uItCNiIix85xh1P
         HRTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:date:subject:cc:to:from
         :dkim-signature;
        bh=7WJUP7CO371Ox38MLS3F6Pu/++9FjOfLN9lRQi3hrS0=;
        b=zteOlmPALizbAhzvcEd1/7j0Za3Ar76Ft1ncxrKc9mcF19vj1doq2mVzl45k1//fJi
         K1ieg7ivvI4pYsyCEjmj2j/xqopSJjZIjBQxgPXiFogjGAKonzReDFAYjGOROniKBT3B
         pDHwv4eDBuFSKfm8fOi2ydMYyw1YIH5Sb0lYtIXnjdPKSHRAMqMfFwyT9t4vJ/bKItRV
         115EKbWNtkJraQ8KCHhWR9KBtOFPlRApNzVSrQszcQdn70db7LLR6C1MeLYqG33UAs/e
         nKrC1XoTGacAcHRoagWsiqDM2NNPJnLvlE8svRl1rDFrU7a9hUHIz6iaEeA+Pt+V9BW+
         hQqw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@chronox.de header.s=strato-dkim-0002 header.b=fhIgSQhl;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org
Return-Path: <linux-crypto-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id r24si16937430ejy.194.2021.07.17.08.04.12;
        Sat, 17 Jul 2021 08:04:49 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@chronox.de header.s=strato-dkim-0002 header.b=fhIgSQhl;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234614AbhGQPGa (ORCPT <rfc822;ujwal.kundur.foss@gmail.com>
        + 99 others); Sat, 17 Jul 2021 11:06:30 -0400
Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.167]:10413 "EHLO
        mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234582AbhGQPG3 (ORCPT
        <rfc822;linux-crypto@vger.kernel.org>);
        Sat, 17 Jul 2021 11:06:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1626534208;
    s=strato-dkim-0002; d=chronox.de;
    h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:
    From:Subject:Sender;
    bh=7WJUP7CO371Ox38MLS3F6Pu/++9FjOfLN9lRQi3hrS0=;
    b=fhIgSQhlyEv7Y3ASIp1IWSiIQDJz/w3kvFQNMjYiIClN7mSXQ6Y3gerLG6EIwtE5fq
    qUVrDtGMi0JvXlWKv32dUiUYMD3w98w5Gwm7u7xkDqUi42JfnoL1M5u/cuQjYm9ll/em
    82TigQ4h3N4Ls1DczcSqUPpfm0wBacohxrgLSSFhH1KMLaKvweWESlwSHur2zXoToMGg
    zRz2gRqEARmPaW0N455fFi18wTC/ZnC5uzMXsIbf+qvzVl8c1BK0QyDsAvJ/69pGcfPF
    MoxB21fEeozwV9BzqefRtCgtus6jCIUaUBtOCg/ksoUvggI+VKn/fLRk06Vyf2IInURe
    ywRA==
Authentication-Results: strato.com;
    dkim=none
X-RZG-AUTH: ":P2ERcEykfu11Y98lp/T7+hdri+uKZK8TKWEqNyiHySGSa9k9xmwdNnzGHXPaIvSZEqc="
X-RZG-CLASS-ID: mo00
Received: from positron.chronox.de
    by smtp.strato.de (RZmta 47.28.1 DYNA|AUTH)
    with ESMTPSA id 9043bbx6HF3RC9v
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))
        (Client did not present a certificate);
    Sat, 17 Jul 2021 17:03:27 +0200 (CEST)
From:   Stephan =?ISO-8859-1?Q?M=FCller?= <smueller@chronox.de>
To:     Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>
Cc:     Sagi Grimberg <sagi@grimberg.me>,
        Keith Busch <keith.busch@wdc.com>,
        linux-nvme@lists.infradead.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH 03/11] crypto/ffdhe: Finite Field DH Ephemeral Parameters
Date:   Sat, 17 Jul 2021 17:03:26 +0200
Message-ID: <29491463.gfxVf8N7Et@positron.chronox.de>
In-Reply-To: <20210716110428.9727-4-hare@suse.de>
References: <20210716110428.9727-1-hare@suse.de> <20210716110428.9727-4-hare@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Am Freitag, 16. Juli 2021, 13:04:20 CEST schrieb Hannes Reinecke:

Hi Hannes,

> +#include <linux/module.h>
> +#include <crypto/internal/kpp.h>
> +#include <crypto/kpp.h>
> +#include <crypto/dh.h>
> +#include <linux/mpi.h>
> +
> +/*
> + * ffdhe2048 generator (g), modulus (p) and group size (q)
> + */
> +const u8 ffdhe2048_g[] = { 0x02 };

What about using static const here (and for all the following groups)?

Ciao
Stephan