Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp2913554pxv; Sun, 18 Jul 2021 05:22:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxV4f1rPWrT0/IYSOi0K2vpbrv2N6mR1hgDzMdgRgdpHfJ/iweizL2hkkUvS0mHdo4owNYV X-Received: by 2002:a17:906:a185:: with SMTP id s5mr22120066ejy.96.1626610977012; Sun, 18 Jul 2021 05:22:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626610977; cv=none; d=google.com; s=arc-20160816; b=JzoWfR3Ua8Hmzha9l89GiOXtKiPZojLfKUU04gEMzcJIGvrV4J4RHZh2SGtQZM/g5Y 7E7xatx7NFTZ/VhTacky9GZSd3CbNzQDju425tmKMw8AcuerMwj3DGKs+JS/XiPT3eb1 MdtaT5pv4Bw7mtic2Wz+XOFfAMiq7aj5NQg1oKDAF/snhDa4CBb5jJaE9suG4+aha1wQ DX46iOFiPICUf4qEpB/NJYPoI/82gqshgI4zddZNRkFW6dVcb39JeLaZfK99zAAc5TKc QZmSiZHBemJLXAd6bdYhghjalYaFIQXiwE0g77eVGKCacaT4NinrTHoY5AxhXrjVMXgw LauA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-signature; bh=pugyD51b77ZzuWl1Jldtt+XqGHZGBTYClAPtWrnyQCA=; b=v8g0h6pMq/xSvzfiH1JrRgEV9/AWQodC0g9ejslNd+1ZlvoEvEsyU5VSmiJdZ44S3t Qglc1BVtZsSR0997sYiPLKx9FASaysR0dle6gh/297Ok1Bo1ahWcWFEIPPnFAAsl/EXZ 0J0LHOnnJyzXhWQ6tVtBPP9TBZFYGPOX7sx9tMG6chBmwkJNU61d3q5z/3mru8L8w/At PGShF5nWvwLFnVWKmCcimHV4ZX4pBeecHh60KDb2DDRT75xs31GsqETiLeEGwq4lWcyW +qEEjXSTBmBzvOIa51yCxlCiLoYm7D2dnnhXG6K3glSLm8nOFnKCoFJDZmSW7tbzH5HJ wL5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=jYVsQlu5; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r4si18462307eju.200.2021.07.18.05.22.21; Sun, 18 Jul 2021 05:22:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=jYVsQlu5; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233273AbhGRMZN (ORCPT + 99 others); Sun, 18 Jul 2021 08:25:13 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:55998 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233251AbhGRMZN (ORCPT ); Sun, 18 Jul 2021 08:25:13 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D71BF224EB; Sun, 18 Jul 2021 12:22:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626610934; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pugyD51b77ZzuWl1Jldtt+XqGHZGBTYClAPtWrnyQCA=; b=jYVsQlu5W5FlNCN4W7Sw612NN8CSZ0FVAZ90I7qLCgBoJET+PJOb/achfvmyqLd39xJgNM Ni1OWvNJdZHcdpoj22NQo+fY0/yP89s4VE4AcTRnwdHMa612FLfLH10GUPUngyW3TQVgWB pRyXIRy6YQaLexbkIDcJNGY0dG4YNfM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626610934; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pugyD51b77ZzuWl1Jldtt+XqGHZGBTYClAPtWrnyQCA=; b=1e5cukwEBcVb4JIyJU46lkt7eN5noYoVf8FxWGUd/3714Qnekh1XrXO7U9h53whQUkjvL1 3fgkbPeTC/9224BQ== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id AED2E13AD2; Sun, 18 Jul 2021 12:22:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id GsOoKfYc9GD3OgAAGKfGzw (envelope-from ); Sun, 18 Jul 2021 12:22:14 +0000 Subject: Re: [PATCH 03/11] crypto/ffdhe: Finite Field DH Ephemeral Parameters To: =?UTF-8?Q?Stephan_M=c3=bcller?= , Christoph Hellwig Cc: Sagi Grimberg , Keith Busch , linux-nvme@lists.infradead.org, Herbert Xu , "David S . Miller" , linux-crypto@vger.kernel.org References: <20210716110428.9727-1-hare@suse.de> <20210716110428.9727-4-hare@suse.de> <29491463.gfxVf8N7Et@positron.chronox.de> From: Hannes Reinecke Message-ID: Date: Sun, 18 Jul 2021 14:22:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <29491463.gfxVf8N7Et@positron.chronox.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 7/17/21 5:03 PM, Stephan Müller wrote: > Am Freitag, 16. Juli 2021, 13:04:20 CEST schrieb Hannes Reinecke: > > Hi Hannes, > >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +/* >> + * ffdhe2048 generator (g), modulus (p) and group size (q) >> + */ >> +const u8 ffdhe2048_g[] = { 0x02 }; > > What about using static const here (and for all the following groups)? > Yes, of course. Will be fixing it. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer