Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210716165403.6115-1-ardb@kernel.org> <YPIdEwVJsOdrpJJH@quark.localdomain>
In-Reply-To: <YPIdEwVJsOdrpJJH@quark.localdomain>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Mon, 19 Jul 2021 09:11:50 +0200
Message-ID: <CAMj1kXEyoOnke4=bcCvKuqLP2On63XK2JUP-LgmoBi-H_m+XmA@mail.gmail.com>
Subject: Re: [PATCH] crypto: x86/aes-ni - add missing error checks in XTS code
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Dave Hansen <dave.hansen@intel.com>,
        syzbot <syzbot+5d1bad8042a8f0e8117a@syzkaller.appspotmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 17 Jul 2021 at 01:58, Eric Biggers <ebiggers@kernel.org> wrote:
>
> On Fri, Jul 16, 2021 at 06:54:03PM +0200, Ard Biesheuvel wrote:
> > The updated XTS code fails to check the return code of skcipher_walk_virt,
> > which may lead to skcipher_walk_abort() or skcipher_walk_done() being called
> > while the walk argument is in an inconsistent state.
> >
> > So check the return value after each such call, and bail on errors.
> >
> > Fixes: 2481104fe98d ("crypto: x86/aes-ni-xts - rewrite and drop indirections via glue helper")
>
> Add Cc stable?
>
> > Reported-by: Dave Hansen <dave.hansen@intel.com>
> > Reported-by: syzbot <syzbot+5d1bad8042a8f0e8117a@syzkaller.appspotmail.com>
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > ---
> >  arch/x86/crypto/aesni-intel_glue.c | 5 +++++
> >  1 file changed, 5 insertions(+)
>
> Reviewed-by: Eric Biggers <ebiggers@google.com>
>

Thanks Eric. Herbert can add the cc:stable if he decides to, but IIRC,
he prefers relying on the fixes: tag only.