Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4367482pxv; Tue, 20 Jul 2021 01:59:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuIBkeoxovBUDSPNTr+BIG655Jes8SINXytgRi+bwjLIRhOgaUeuXKsgulhqojjMIlD6oc X-Received: by 2002:aa7:c1ca:: with SMTP id d10mr38113074edp.107.1626771585082; Tue, 20 Jul 2021 01:59:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626771585; cv=none; d=google.com; s=arc-20160816; b=fndWEpAoxzKWl/36Dc5GeRPuNAAB6qQdPuy4A4QqKCQ7sDl6UTnPAcUfeqm2rANXFB gFPgIeqZ8d+TsM0lNVULMRZWNhBpL7LBwQDp3IpuSjyX0lVci4nGcxezX9Q5RwT9oUJT s8r6/elk6Uso5fY3RONSik+BFYXJfrApYHOkEG9NU0pCocOSG7Jhwmvmn0GoWq5jufBy /NepmPan45a3wy0HhYXxnk3Oy+ofHZKpecAeqY1IDiAw7MJoX+d6fbYiEVCvMZduJhe+ zrJPAMRYHGcqMLK1d9CD0b47bh4X8Bbu5mF8mdWd/t/94wBlzYAIKDQjApsGODcF19J/ NtpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:dkim-signature; bh=1lqqgzqtYfp0v6TI7qw4VF2x+qKcHr0dRz421WUxxZo=; b=vLVeVZv0OszA4k+kSvs636+qwPSC7BpHMdtUb26j6ZauAWOiKil5gBT3DcmfeQfOJM nc1gygbs8tSFBaopcRTR+qNT42+d/EkPp5S+QeA3EWtzr4I6S3uFsb/AZExVp7mnlhuo 327fG+l7K1i+6zuhxHgVIUL+whBS7PnE5/UfTpFWqZ8jQaA9ymIPsz1cdKp5BIvmaCnv bQhEZpfDiKRS+iYRbUNz6RJKoxxyAUtg0uQNN4QaBCjwC5CyTjb0m93unSqPGhjxQ2ja XV5JHncWnrs4dpCB1UKXx3NWIvsIoHMmbKbkwszCq6mykrCXi+9NVHS+vEnsdu+BlrB+ hxow== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=aFILqc88; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g13si23840113edf.463.2021.07.20.01.59.22; Tue, 20 Jul 2021 01:59:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=aFILqc88; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232349AbhGTIR0 (ORCPT + 99 others); Tue, 20 Jul 2021 04:17:26 -0400 Received: from esa.microchip.iphmx.com ([68.232.153.233]:24894 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235172AbhGTIPO (ORCPT ); Tue, 20 Jul 2021 04:15:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1626771353; x=1658307353; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bwI9gxWGdNp9j8lflPn0ecNSwTANdGc33doeihFdZBM=; b=aFILqc88OHeIn5EoeRnv3odvf7ddKm8x2eOlmU8HxlPkh9+28XwmKdOO hh7CIKobqgKGq6zbqdhEuos6fnNTGuOV9rQCaURs1KbkYdTDlDQ47iElF 42re+ZKm/+KAZxyuplXYarQGLxsw+OENNxkKHMderScGJhymRB596QBrc sTCotYZvZuuTLkF3qyjGsWcYE7r6emt4WQ+hxihZhmXsiqGdIEdda1Yzh 2n5rLVAtGyPn3XRPPVhZKb5x9Eyt2SG3Ewe7NTdWKRBzBpwuc+HpHCemf F9BqInF9X16J/DDBcboEpG8V7B0kDGAeBlJoBkbMQPA1X7nhfQE3ZQejR A==; IronPort-SDR: AsQ9+fN3cEW94XouGCgB6FtnzgJB6gnbcpyPSJXngBjjJnc/p5Q1/brJHQe5Av3RttOKMWiA4X 12ygX0KneBZJ+vxZ6nWRqIfPOSjOP/LsLJ8mWytfAhigl09WGJxqgZ5rLrJNN3291Ddv3nUDDI GB0tQ0iOwzXtEEaOUY4ihvmDWRP8LWhM62uhEtzcmPvN9q1vKdG9XzloiWYkO8D6VEqPbS91nT zV3WWl4gvxZNp7KD36MwVWIa6EZMLbP/CFbdwzzgmUyoBTubtfhl0BQfDqJ4Rvq16qZRrs+73P ae5mULGi1pT0nVdn1ImFmndI X-IronPort-AV: E=Sophos;i="5.84,254,1620716400"; d="scan'208";a="128973620" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 20 Jul 2021 01:55:50 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 20 Jul 2021 01:55:49 -0700 Received: from ROB-ULT-M18064N.mchp-main.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Tue, 20 Jul 2021 01:55:47 -0700 From: Tudor Ambarus To: CC: , , , , , , "Tudor Ambarus" Subject: [PATCH 4/9] crypto: atmel-aes: Add XTS input length constraint Date: Tue, 20 Jul 2021 11:55:30 +0300 Message-ID: <20210720085535.141486-5-tudor.ambarus@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210720085535.141486-1-tudor.ambarus@microchip.com> References: <20210720085535.141486-1-tudor.ambarus@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Input length smaller than block size does not make sense for XTS. Signed-off-by: Tudor Ambarus --- drivers/crypto/atmel-aes.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c index 9c6d80d1d7a0..4e9515e8dd25 100644 --- a/drivers/crypto/atmel-aes.c +++ b/drivers/crypto/atmel-aes.c @@ -1091,6 +1091,9 @@ static int atmel_aes_crypt(struct skcipher_request *req, unsigned long mode) struct atmel_aes_dev *dd; u32 opmode = mode & AES_FLAGS_OPMODE_MASK; + if (opmode == AES_FLAGS_XTS && req->cryptlen < XTS_BLOCK_SIZE) + return -EINVAL; + if ((opmode == AES_FLAGS_ECB || opmode == AES_FLAGS_CBC) && !IS_ALIGNED(req->cryptlen, crypto_skcipher_blocksize(skcipher))) return -EINVAL; -- 2.25.1