Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 26 Jul 2021 23:37:38 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Andre Przywara <andre.przywara@arm.com>
Cc:     Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Mark Rutland <mark.rutland@arm.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Sudeep Holla <sudeep.holla@arm.com>,
        linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Ard Biesheuvel <ardb@kernel.org>,
        Will Deacon <will@kernel.org>, Ali Saidi <alisaidi@amazon.com>,
        Jon Nettleton <jon@solid-run.com>
Subject: Re: [PATCH v3 2/2] hwrng: Add Arm SMCCC TRNG based driver
Message-ID: <20210726223738.GM4670@sirena.org.uk>
References: <20210726175610.3311-1-andre.przywara@arm.com>
 <20210726175610.3311-3-andre.przywara@arm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Z1Z8UV8BNhgCynIS"
Content-Disposition: inline
In-Reply-To: <20210726175610.3311-3-andre.przywara@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--Z1Z8UV8BNhgCynIS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jul 26, 2021 at 06:56:10PM +0100, Andre Przywara wrote:

> +static int smccc_trng_init(struct hwrng *rng)
> +{
> +	return 0;
> +}

If this can be empty (looking at the core it seems like it can) then
best just remove it.

> +	platform_set_drvdata(pdev, trng);
> +	ret = devm_hwrng_register(&pdev->dev, trng);
> +	if (!ret)
> +		dev_info(&pdev->dev,
> +			 "ARM SMCCC TRNG firmware random number generator\n");

Is the log message needed given that we're not announcing any version
information here or anything?  A brief sampling of other drivers
suggests it's not a standard thing for the subsystem.

--Z1Z8UV8BNhgCynIS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmD/OTEACgkQJNaLcl1U
h9DF7wf9GqmHJLZkYahxYPpoXwvLcvsZt6nYbntvEyaggYXeftDozXfAGzJUwtVA
j43FX18gocM2pF69qk3kpzyt36ESGVWBnENrKlpBmonaZBd+OjEtf0Of3cfwXvfe
TrzFuo5BBcPdBhA2ijXjTZK3eiVhiwqbw/OO6xf6u0ZgZAJDtAOC0+cVmFC/pE6Q
8cVSY5v4izXNENx9COp3o6Irq1KvV3d5qsfMbU26N046nEbwtkUE5QLrNRk11hOg
7F1jg0P4Lny1jVNXkrtjrAZY9wlL/XOAUjQawf1kU29xLUn8BJHTqsz7uyu3Zd6k
tkl1X6LuTHtJ9rGRj+S3NaJ539HsYg==
=QpYI
-----END PGP SIGNATURE-----

--Z1Z8UV8BNhgCynIS--