Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 27 Jul 2021 01:59:22 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Andre Przywara <andre.przywara@arm.com>
Cc:     Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Mark Rutland <mark.rutland@arm.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Sudeep Holla <sudeep.holla@arm.com>,
        linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Ard Biesheuvel <ardb@kernel.org>,
        Will Deacon <will@kernel.org>, Ali Saidi <alisaidi@amazon.com>,
        Jon Nettleton <jon@solid-run.com>
Subject: Re: [PATCH v3 2/2] hwrng: Add Arm SMCCC TRNG based driver
Message-ID: <20210727005922.GN4670@sirena.org.uk>
References: <20210726175610.3311-1-andre.przywara@arm.com>
 <20210726175610.3311-3-andre.przywara@arm.com>
 <20210726223738.GM4670@sirena.org.uk>
 <20210727013004.4caca28f@slackpad.fritz.box>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="xTKfHyrFnSV9DG3y"
Content-Disposition: inline
In-Reply-To: <20210727013004.4caca28f@slackpad.fritz.box>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--xTKfHyrFnSV9DG3y
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jul 27, 2021 at 01:30:04AM +0100, Andre Przywara wrote:

> Now thinking about this, there would probably be some value in making
> the TRNG UUID somehow available, as this can be used to identify flawed
> implementations (general problems in the hardware or backend bugs). But
> this should be some query-able interface, rather than some line in
> dmesg. Any ideas? Might be beyond the scope of this series, though...

I guess you could append it to the name (eg, "SMCCC TRNG ${UUID}")
though it'd be a bit of an eyesore if anyone displays that in UIs much?

A separate version string queryable in parallel with name would be more
work but possibly a bit more sensible, some other hardware entropy
sources will have firmware version numbers or similar they could
usefully report I expect.

--xTKfHyrFnSV9DG3y
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmD/WmkACgkQJNaLcl1U
h9DxSQf/SRmE+SMJ3GxdX20HOP2LsvMm9R5rJCf0HK/MQYavnz151pAb5OICJWLT
YC0FOoXaXwAgzz1b8y3MkC+9aAV0d3eSvfGCpbEF7lQ4imCwjnXZPSjZZkLexRcj
r+9yXM2U2iDKtUxrngwh2+OcZlaagC9oJYgxB9YhK+lkuxgsA9Y4PC7QzQ8I9nzN
vgygd/7t4DV4cjadSUdmlcSYKuZlF4ORWUHIUb8KFbLYZ01PlAtcHwUXtXP+mL8S
xK+H5YBAEoIoeSlYPirKHKyOgEnL9We0grsN0JhgPz04oLLLP2WeYBIwEm5w4iHn
gTBNJ39Xlzeq7LOzWJ2I7W/CG2UQ8A==
=Nq3c
-----END PGP SIGNATURE-----

--xTKfHyrFnSV9DG3y--