Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp6600520pxv; Thu, 29 Jul 2021 19:58:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz51w5JnKvsd6R2qwQ5n+mPJHSneGuFxCorNbYLOZnI1mSgUqe4a3yhVRh1reEghksyzwI5 X-Received: by 2002:aa7:c50d:: with SMTP id o13mr302275edq.153.1627613937286; Thu, 29 Jul 2021 19:58:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627613937; cv=none; d=google.com; s=arc-20160816; b=hclSSCaUU6xYPUnewzqgfpRSs3qsVglNV4K5GMy4kBeLHzrkGCl1usOVSfVXqKHm8q TgRsuTnHxSCeLYr/Re+yCNpHd3/owU+a4McXS564jscYm6rysG/xWOpKr/LWrRc5UahQ aKAWNY4eKyE4O0tuPLtGlHrgngHD4HqegTZRSX9le2kXK+orZfuG61Dw2ywPe9TINdRS ishsr2P36sQLtNhRi1xxkE/1gzWeGl7x9Pxz2WUdeDhd+bzeVmKTo65GniA/tMeb5eQL SCSzH0jSPSrNGfZuOO3VDrdRtVtVax9l69vRAT79AzboTB9hWWUFDyWzTGnIPMChPYgN 4NpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=5iqCT5XcCRk+OusScbzRTr428K1N0EikyHWw5DSqi8A=; b=W7dgNCyKdOkokudSHGLHJO5PTQKJLgI2H06iEJyuxcq8IZ9/Tdx/4zTcBUWeUzT0tt SAaqVfd0C6MQQYLBbJydwqSky/0v1VhJZWKsfAONVpo/YR48oO+pA5wOt9haeIFkBIAV bunkzQAwmHpNuG/D2ysHgpPEKK4ayIT9Bg3H8y5VHwiBFwoHz9sJDYB2w/wSjgHKtW6d dTmObfyZpuEYPP9m+vefHFNS+SBJLPbym0xFnKXZyURJ9dVbmNpyVJ0CTDRdLa3ucZVW l+Umy8GvzLkihEkrzdDOT1JeM8aa841/BZ8MdAdCCWqbJtT2TtQ4+PDaOIX3Ey8nw/s+ l5Yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n15si343986edy.519.2021.07.29.19.58.25; Thu, 29 Jul 2021 19:58:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230172AbhG3Cz4 (ORCPT + 99 others); Thu, 29 Jul 2021 22:55:56 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:51562 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbhG3Cz4 (ORCPT ); Thu, 29 Jul 2021 22:55:56 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1m9Igd-0000O1-NJ; Fri, 30 Jul 2021 10:55:47 +0800 Received: from herbert by gondobar with local (Exim 4.92) (envelope-from ) id 1m9Iga-0003Kz-Py; Fri, 30 Jul 2021 10:55:44 +0800 Date: Fri, 30 Jul 2021 10:55:44 +0800 From: Herbert Xu To: Daniel Latypov Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, brendanhiggins@google.com, davidgow@google.com, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com Subject: Re: [RFC v1 1/2] crypto: tcrypt: minimal conversion to run under KUnit Message-ID: <20210730025544.GA12781@gondor.apana.org.au> References: <20210715213138.1363079-1-dlatypov@google.com> <20210715213138.1363079-2-dlatypov@google.com> <20210723064328.GA7986@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Jul 23, 2021 at 12:31:28PM -0700, Daniel Latypov wrote: > > Thanks, that makes a lot of sense. > In that case, how useful would `kunit.py run` be? I.e. Do people > mostly want to see numbers on bare metal? I think it's a mix of both. As in performance on bare metal and under virtualisation may be of interest. I don't think you're going to be going through kunit for the speed tests though, because you need to supply module parameters for tcrypt to do that. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt