Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp604029pxt; Fri, 6 Aug 2021 09:15:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzk+Z0hPk/KWVN3vmtdAgK8NbfWkhjldwpdX1IXJG4Q5I5lbKKyGbpw4SCDN+gKmV4QWXMD X-Received: by 2002:a05:6e02:12af:: with SMTP id f15mr576818ilr.39.1628266512799; Fri, 06 Aug 2021 09:15:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628266512; cv=none; d=google.com; s=arc-20160816; b=nsSpRF0FbgxQpKkFnFvmc/49z2+SUC1Iq2A98ovDGLQDDZGlg2jcRL2IhVYaEHo0j4 4MtTtmSfGDWesrQcyTWN/G/1pb1m+idLTRNKSc/9TMEyslYkKSEBD4ZA3OXpGWmuk4ll vXwpfZanzNgK5A9Xd2bQ08pLxpwChjE8p7ByY/zhAErOHvHpioOe+adNAwaBZF/+enj3 C4tVB1RWcKl9JSTZoHJ5LF/tJp0ISo7awXhNnZAQLKtnjQviBf3ziiJMfQVImSco9YUa 7wrIAk6HmcNgujQKOPLSNtoXHUbP7WYOt3jrQjIiduDKQC/eTWaovUas1i/I5GAB0tx0 4Ytw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=N63ri0L6HokQmPdTxCqIM4ax0fq1UWEFDx93lbuQIys=; b=cxdeeItSwIRjEPDkiwdb67luZoI57qWrkznaA4xs8UTgkuF7q+nV4uPrNvQXT6MOky hZX19bBTiU2kjlir5BFRVlrHvZMc64uc90gibjOZMU7I5T/UNrvuDVukXgJdrtNvxIXn kHc+ILTAqqXArFlMwoOdKVv7bRYOPrk69n5AviK597Gu4FivNxpfu/PwQrr+IG+Du/Rf R+OseT5BS+QHcvfhLXGpZEFPTmqmNW6P1P2co/IAQrfzF7O755hqCDWluMW8xRSMx8Ih zFpGcZ73kNpDzh9nac6LJCEhENgxeUgKwuzSgszhfS2S3gUyKO1UKbXexrmyaEKn0ffD IRHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d11si10510647ilc.143.2021.08.06.09.14.57; Fri, 06 Aug 2021 09:15:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343607AbhHFMOv (ORCPT + 99 others); Fri, 6 Aug 2021 08:14:51 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:51750 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343589AbhHFMOu (ORCPT ); Fri, 6 Aug 2021 08:14:50 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1mBykB-0003gR-3f; Fri, 06 Aug 2021 20:14:31 +0800 Received: from herbert by gondobar with local (Exim 4.92) (envelope-from ) id 1mByk6-0006eb-FL; Fri, 06 Aug 2021 20:14:26 +0800 Date: Fri, 6 Aug 2021 20:14:26 +0800 From: Herbert Xu To: Tony Lindgren Cc: "David S . Miller" , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-crypto@vger.kernel.org, Lokesh Vutla , Tero Kristo Subject: Re: [PATCH 1/6] crypto: omap-sham - clear dma flags only after omap_sham_update_dma_stop() Message-ID: <20210806121426.GA25554@gondor.apana.org.au> References: <20210727102339.49141-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210727102339.49141-1-tony@atomide.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jul 27, 2021 at 01:23:34PM +0300, Tony Lindgren wrote: > We should not clear FLAGS_DMA_ACTIVE before omap_sham_update_dma_stop() is > done calling dma_unmap_sg(). We already clear FLAGS_DMA_ACTIVE at the > end of omap_sham_update_dma_stop(). > > The early clearing of FLAGS_DMA_ACTIVE is not causing issues as we do not > need to defer anything based on FLAGS_DMA_ACTIVE currently. So this can be > applied as clean-up. > > Cc: Lokesh Vutla > Cc: Tero Kristo > Signed-off-by: Tony Lindgren > --- > drivers/crypto/omap-sham.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt