Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3606880pxt; Tue, 10 Aug 2021 07:22:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfjfDwLKiqBoSIZeuI3H1K81dRpw6gJsDtiKzQ60OwCuwC2yIt9Lzc0DaKnZ+KLDflaCep X-Received: by 2002:a6b:e00c:: with SMTP id z12mr266652iog.27.1628605334534; Tue, 10 Aug 2021 07:22:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628605334; cv=none; d=google.com; s=arc-20160816; b=XRCwYE2NGIgtbAceUKJjixsd/poF8IuPqDu9tgfyr8xH7lLkZgpSt44nS9fo5bB0uc l+qMOQuhSNuxjfL+DfDtgjh0PeayzGAsRFIDyNVB+HEJU+Sbl1IhSZDdQ/95qYf+hGn3 PqGkl9dKaUGPObZPfWDU/Ab7Pu0P/wmTWNoSJXcabXhCUH5SMJrHCNTcvcRkO/IIWQvi U6OZ6fSOlHa5lQvjUJWXIGZzJPZL5l0VQ7wa4ir4bEI7P41TArUH9C+xRZqTxQi7X5aS HpZ43cxXQwZZjhbL2xj/rLGE7lI8JElCAFHODA7wVUQVB9JQwCBJxs/9LM/KEfsca29L Xd7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PVX/m13LlgW2RqeJado5fh0rRBijUO5c/y0yBM9F/DE=; b=0fGcr5xgWQkie3cSyIobcGC3yXPg6/sEU1j1/l7RQ0XrOtdLdzkdTBfeAKVFm/mTiT LxwtcMQgNY3fEemU5Hky4Pc77LN6/2Y+poSlKScXG5GVbP7YrhivX6H1uLXX04WKFMnu +AjLp420eTU+LjSFxVaXmz/64sKvr5ZQ3pB2TcOEhAbeBQxPF/v2n2tCNViNjq4BFdZD jqQBgo4JnxXQl1NG5rZyI8ACSYJBO4NhuTDaMympUDiLhgzW4VcX2f69cc/NrKk+yfzb T3dd2ixRACX/IL58wOLD0zz1SejQeb+1/b0htrM9hqGPgPbjpjXkF54l3aDEXuBVsoa8 bHhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="JWZPzNZ/"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q20si11933916iod.32.2021.08.10.07.22.01; Tue, 10 Aug 2021 07:22:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="JWZPzNZ/"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240452AbhHJODN (ORCPT + 99 others); Tue, 10 Aug 2021 10:03:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236686AbhHJODM (ORCPT ); Tue, 10 Aug 2021 10:03:12 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D61AC0613D3; Tue, 10 Aug 2021 07:02:50 -0700 (PDT) Received: from zn.tnic (p200300ec2f0d650032a7c3e3b83a4c54.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:6500:32a7:c3e3:b83a:4c54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 43F6D1EC0236; Tue, 10 Aug 2021 16:02:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1628604163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=PVX/m13LlgW2RqeJado5fh0rRBijUO5c/y0yBM9F/DE=; b=JWZPzNZ/xGpf7iPnHSEAqrFCvp+lnaHI0oBVV2vKcj/Tog4CULHEumJH7s2bOwhs2geilQ oMRRacR8FZigRA1lDkloeXT5wLQCy9NaPsGi/3El21mNKEPpczb/tFxxXhvIzmBjiy9N3M z7uLILiZ+jAyP/muqU7zSEgv5peuAIk= Date: Tue, 10 Aug 2021 16:03:27 +0200 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , tony.luck@intel.com, npmccallum@redhat.com, brijesh.ksingh@gmail.com Subject: Re: [PATCH Part1 RFC v4 03/36] x86/sev: Add support for hypervisor feature VMGEXIT Message-ID: References: <20210707181506.30489-1-brijesh.singh@amd.com> <20210707181506.30489-4-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Aug 10, 2021 at 08:39:02AM -0500, Brijesh Singh wrote: > I was thinking that some driver may need it in future, but nothing in my > series needs it yet. I will drop it and we can revisit it later. Yeah, please never do such exports in anticipation. And if we *ever* need them, they should be _GPL ones - not EXPORT_SYMBOL. And then the API needs to be discussed and potentially proper accessors added instead of exporting naked variables... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette