Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp526630pxt; Thu, 12 Aug 2021 04:05:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxO8sbNUCKXgNDzsUfiE5vKxDh61NeEzLkbD2kuLDogkVr/Vg6UL9c5F2o1VwWZZZWzcOIQ X-Received: by 2002:a05:600c:22c2:: with SMTP id 2mr3380850wmg.3.1628766316256; Thu, 12 Aug 2021 04:05:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628766316; cv=none; d=google.com; s=arc-20160816; b=K/dqXShd0QZu1mizwslDbWBOIudCEMUx91AuDKOUVfiZ4Qlf0hh1xjm6xR7gzp9jf+ T2p1gQzBN9tje3uE2JCX6I7FwRwOxX7dtxcO521i3lbS4P9VbJr6AkLKxXO7ZE8bj5sk 6fG6N0iuQN+nQp1OlifuaSMesHQ+a862cBvYvIhNsSnGsloey4o24LRx2SroNw3OePRd LyQN4OxHyvt2+WzpSenIblcO76H5kk4m577mA+H2VQDaPkopPOX6FqZ7YuJ+9AB1rTKJ tDi9N8E/UZVZNlQmJx2nPSvQbJfKcLaQgOJdTTZCpCQsT5SDDiXlR+ZNJ/2o/OPcISqx VsoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=bhVvRjgVrwMzyqJXHlRWL1pHfqqipZSO8jFkgbpc5Hg=; b=1KK1x1uxX3dGqrWFh2zmgtcnWKKaz+MH3lg79Q/zXOe+KFlKXopDE7BufCPef7XKSE UORdjJcp+9dQn9t+OF7WydhuwuCZnCdDzQQZyGM6msLHdAJHymL2pEody2GNm/d9JtKh vsiw71hpA9e+FNC0XxEZC8lDnjPEopPk4mA1iKy2T3E+sh0O3KyRldv+eehZJouz1SZE 9PkkJPXzo/UcCUFmyvxTUCzfnbYtnEg9efZJwgbUkQ6HNTGcXmCocfrJrGXzz8szMjCw rUgjTCjuWD5sDhwlWYMwJZ9jD8tsjxe/9HfBpmXb/BvuOsQij4vOGO+JwruD4BVhKqJt UvpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d7si2519993edm.267.2021.08.12.04.04.44; Thu, 12 Aug 2021 04:05:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236584AbhHLLFH (ORCPT + 99 others); Thu, 12 Aug 2021 07:05:07 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:52728 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235696AbhHLLFH (ORCPT ); Thu, 12 Aug 2021 07:05:07 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1mE8Vt-0003C0-9C; Thu, 12 Aug 2021 19:04:41 +0800 Received: from herbert by gondobar with local (Exim 4.92) (envelope-from ) id 1mE8Vs-0001bk-91; Thu, 12 Aug 2021 19:04:40 +0800 Date: Thu, 12 Aug 2021 19:04:40 +0800 From: Herbert Xu To: Kai Ye Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, wangzhou1@hisilicon.com Subject: Re: [PATCH 2/2] crypto: hisilicon/sec - modify the hardware endian configuration Message-ID: <20210812110440.GB5890@gondor.apana.org.au> References: <1628243914-33224-1-git-send-email-yekai13@huawei.com> <1628243914-33224-3-git-send-email-yekai13@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1628243914-33224-3-git-send-email-yekai13@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Aug 06, 2021 at 05:58:34PM +0800, Kai Ye wrote: > > + reg &= ~(BIT(1) | BIT(0)); > +#ifndef CONFIG_64BIT > + reg |= BIT(1); > +#endif > + > +#ifndef CONFIG_CPU_LITTLE_ENDIAN > + reg |= BIT(0); > +#endif Please rewrite these without ifdefs. For example, if (!IS_ENABLED(CONFIG_64BIT)) reg |= BIT(1); if (!IS_ENABLED(CONFIG_CPU_LITTLE_ENDIAN)) reg |= BIT(0); I can't vouch for the logic here so please double-check. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt