Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 12 Aug 2021 19:31:09 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Weili Qian <qianweili@huawei.com>
Cc:     davem@davemloft.net, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org, wangzhou1@hisilicon.com,
        liulongfang@huawei.com
Subject: Re: [PATCH 3/5] crypto: hisilicon - support runtime PM for
 accelerator device
Message-ID: <20210812113109.GA9121@gondor.apana.org.au>
References: <1628332356-33278-1-git-send-email-qianweili@huawei.com>
 <1628332356-33278-4-git-send-email-qianweili@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1628332356-33278-4-git-send-email-qianweili@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Sat, Aug 07, 2021 at 06:32:34PM +0800, Weili Qian wrote:
>
> @@ -1083,6 +1105,10 @@ static void hpre_remove(struct pci_dev *pdev)
>  	hisi_qm_uninit(qm);
>  }
>  
> +const struct dev_pm_ops hpre_pm_ops = {
> +	SET_RUNTIME_PM_OPS(hisi_qm_suspend, hisi_qm_resume, NULL)
> +};
> +

This causes a warning as it should be static.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt