Received: by 2002:a05:6a10:8a4d:0:0:0:0 with SMTP id dn13csp882924pxb; Fri, 13 Aug 2021 08:22:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxO58DFZZ1ja85obn17eruyF2eHk8N4TGC8EbGPNI28wiOuyhtU/3SyxYkvgY9Xyoh0BAnq X-Received: by 2002:a92:d0b:: with SMTP id 11mr2308726iln.244.1628868132726; Fri, 13 Aug 2021 08:22:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628868132; cv=none; d=google.com; s=arc-20160816; b=EVg2fhl2ERE1edmuHnzLUqotYApZotI/WfFSj8+KxQsdlC/tWys9cu5cYln7m0p6y2 JhnVkk46wII6FnT2cBK99Y9F8pSagYaGaOuIKXFy+j9FYfM2mlTQb3x6bWy9gE+W+qCC RqbqW2DD48y0aWIicn3gGFs4Bj8eubmjH/R0Yu8yINZlNXm/oJfGtKNGC+Wq7SU5o0sa j4txbspL61uAqe9twGxuUkC1TugvdhzUAp3APemQLXt0uQgFpD2VanYkcs4jCKdn5Whc csyXPZ/A63kzEoM8UhxLpCFHjufN3cvWUR3mI2kIo6SHwsIfOA6gHaa5ppvHzYsYQdKn Fhzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=dczs9anjttgTzg/uu954njfB+GeLW6EkJBQxK9xBxd4=; b=NHVcL3rATLPQfV/Nm/3d3HZ7XhYgSKiNpuCLDW78FlWggPeKAfTlk8mIiO1JmshQGq AoZhNlKteTBGKoDUzAC4PMfJmWfb6ZcrHTEtrY2L7BBZYXBFRkKolSZHSbWywhb1gwHO YAlgRJEyZyVZx1HjEbGMnIMlQuQ8AtYHFuuGtQ1dNRLABpwSm26E7hT/l4KpA6e/pb+e v4BvZMBOmLHq1RUDnXemXV8uFFaf8phF9QQtwRVhDXVbziTABz8HEdpdYCrOxcSJKsBp taQzx5QIuiU4c+t/hqzKdcEKAm42amSrF72HwCa2ydW2dPjdRZUK4YHSPWbJXzOX2Xzc UTQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="L/xLFyva"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y196si1997516iof.86.2021.08.13.08.22.00; Fri, 13 Aug 2021 08:22:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="L/xLFyva"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242258AbhHMPVq (ORCPT + 99 others); Fri, 13 Aug 2021 11:21:46 -0400 Received: from mail.skyhub.de ([5.9.137.197]:45724 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242428AbhHMPS4 (ORCPT ); Fri, 13 Aug 2021 11:18:56 -0400 Received: from zn.tnic (p200300ec2f0a0d0070a51027a6cfb94b.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:d00:70a5:1027:a6cf:b94b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 1C9EF1EC01A8; Fri, 13 Aug 2021 17:18:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1628867904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=dczs9anjttgTzg/uu954njfB+GeLW6EkJBQxK9xBxd4=; b=L/xLFyvayZt+LUhW0u37pNjr5TvN/IZS0NT7BC2ZchY0z8mCo1k21N4EQspJmckwmuuhss T45E+ksx/nZm1PMKqxifajMY4nDrPCT9cddbwmrlZwnULH4s3cD8uXP2K1GUDLby/MHaGt rXDLK1x/miuXg83W0A5qvXiGhosDp94= Date: Fri, 13 Aug 2021 17:19:07 +0200 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , tony.luck@intel.com, brijesh.ksingh@gmail.com Subject: Re: [PATCH Part1 RFC v4 09/36] x86/compressed: Add helper for validating pages in the decompression stage Message-ID: References: <20210707181506.30489-1-brijesh.singh@amd.com> <20210707181506.30489-10-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Aug 13, 2021 at 09:21:14AM -0500, Brijesh Singh wrote: > > Also get rid of eccessive defines... > > I am getting conflicting review comments on function naming, comment style, > macro etc. While addressing the feedback I try to incorporate all those > comments, lets see how I do in next rev. What do you mean? Example? With "Also get rid of eccessive defines..." I mean this here from earlier this week: https://lkml.kernel.org/r/YRJOkQe0W9/HyjjQ@zn.tnic -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette