Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210816124433.10411-1-lukas.bulwahn@gmail.com>
In-Reply-To: <20210816124433.10411-1-lukas.bulwahn@gmail.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Mon, 16 Aug 2021 14:55:15 +0200
Message-ID: <CAMj1kXFEGK_3RDXcO3kvCVQvOvoCLgRtQsR=pEbSaiY7erVJrQ@mail.gmail.com>
Subject: Re: [PATCH] crypto: remove rmd320 in Makefile
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        kernel-janitors@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 16 Aug 2021 at 14:44, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> Commit 93f64202926f ("crypto: rmd320 - remove RIPE-MD 320 hash algorithm")
> removes the Kconfig and code, but misses to adjust the Makefile.
>
> Hence, ./scripts/checkkconfigsymbols.py warns:
>
> CRYPTO_RMD320
> Referencing files: crypto/Makefile
>
> Remove the missing piece of this code removal.
>
> Fixes: 93f64202926f ("crypto: rmd320 - remove RIPE-MD 320 hash algorithm")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  crypto/Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/crypto/Makefile b/crypto/Makefile
> index 10526d4559b8..c633f15a0481 100644
> --- a/crypto/Makefile
> +++ b/crypto/Makefile
> @@ -74,7 +74,6 @@ obj-$(CONFIG_CRYPTO_NULL2) += crypto_null.o
>  obj-$(CONFIG_CRYPTO_MD4) += md4.o
>  obj-$(CONFIG_CRYPTO_MD5) += md5.o
>  obj-$(CONFIG_CRYPTO_RMD160) += rmd160.o
> -obj-$(CONFIG_CRYPTO_RMD320) += rmd320.o
>  obj-$(CONFIG_CRYPTO_SHA1) += sha1_generic.o
>  obj-$(CONFIG_CRYPTO_SHA256) += sha256_generic.o
>  obj-$(CONFIG_CRYPTO_SHA512) += sha512_generic.o
> --
> 2.26.2
>