Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 0/2] crypto: remove MD4 generic shash
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Eric Biggers <ebiggers@kernel.org>,
        ronnie sahlberg <ronniesahlberg@gmail.com>,
        linux-cifs <linux-cifs@vger.kernel.org>,
        Steve French <sfrench@samba.org>,
        David Howells <dhowells@redhat.com>, keyrings@vger.kernel.org
References: <20210818144617.110061-1-ardb@kernel.org>
 <946591db-36aa-23db-a5c4-808546eab762@gmail.com>
 <CAMj1kXEjHojAZ0_DPkogHAbmS6XAOFN3t8-4VB0+zN8ruTPVCg@mail.gmail.com>
 <24606605-71ae-f918-b71a-480be7d68e43@gmail.com>
 <CAMj1kXEO8PwLfT8uAYgeFF7T3TznWz4E=R1JArvCdKXk8qiAMQ@mail.gmail.com>
From:   Denis Kenzior <denkenz@gmail.com>
Message-ID: <e2462d50-57e9-b7d7-bc07-0f365a01d215@gmail.com>
Date:   Wed, 18 Aug 2021 17:22:00 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <CAMj1kXEO8PwLfT8uAYgeFF7T3TznWz4E=R1JArvCdKXk8qiAMQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Ard,

>> That is not something that iwd has any control over though?  We have to support
>> it for as long as there are  organizations using TTLS + MD5 or PEAPv0.  There

Ah, my brain said MSCHAP but my fingers typed MD5.

>> are still surprisingly many today.
>>
> 
> Does that code rely on MD4 as well?
> 

But the answer is yes.  Both PEAP and TTLS use MSCHAP or MSCHAPv2 in some form. 
  These are commonly used for Username/Password based WPA(2|3)-Enterprise 
authentication.  Think 'eduroam' for example.

MD4 is used to hash the plaintext password, but the hash is sent inside a TLS 
tunnel, so there's really no immediate crypto weakness concern?  At least 
there's not a replacement on the horizon as far as I know.  EAP-PWD has its own 
problems and I doubt certificate based authentication will overtake 
username/password any time soon.

Regards,
-Denis