Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp68689pxb;
        Thu, 2 Sep 2021 19:33:59 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwHb6ylK7b6/4VfH+WXh8kFom2ziTJgKzleHk6eATHXV6gnJSNttHFWSN7zQyB11Xz1/Dye
X-Received: by 2002:a17:906:c416:: with SMTP id u22mr1461383ejz.543.1630636439133;
        Thu, 02 Sep 2021 19:33:59 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1630636439; cv=none;
        d=google.com; s=arc-20160816;
        b=jWKsfFvK9rj7vfUU0I7fVO1mXecabyPL2IkoV018jD4ovonL5W8aTJuBZQBR7h40Jj
         XodUkLwKKyGVMGoy5ZqJAwyMH0xP0aEUo9W4U/nd0kakLzdXdeyjwfwXsRhw71CZ8VFL
         DBYH+gE70knqF4w4O3VrBJPfkjFIRMFCsuahcDUSL0xfb7HdfcpBAHKu+oQJ6A7US3dw
         uOLuwSAC8lkITlurMKu2Ajfpjbc9y9S+8hjeNm0cQq6+PKp1hp+s2dL+BZo2sKZpTtkU
         mSyYufZOlz0sjFZKJdW2D/yTuzoMVbjzxolqWBrg30+YZH2rLN6o6APR5yXCx8MYUtXh
         O2hQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:to:subject:message-id:date:from:mime-version
         :dkim-signature;
        bh=wDGw9jS/MTv37T06LNdhRlV9dv+DZoHzz+VFlgPfmO8=;
        b=W5KHZERmGgB9gr1jqcu7Hc7uJcWdZBuWyOxm5sUo5ZQqUUOSDakCi6vyQ0i0Uu8pdu
         Yk9mjGlkU9XQYafniBWWk8g8pdbJgjK/RNmQOP9ZW98MOQz4JKjOGnLWyuTS57p8hRW/
         IS0wDBO32xt55an0mhDh6f8xkW8u0idwI0Rp7TytZV+DSjbVvPQNHajrbtTwzdtLoj25
         8FxLMSssCOHX3hCoTWAIIKyHzWUEkd+uYLuaF4KW6e68/qK6WEPCnRuiVcORrr4nJSo3
         7LEjcOAXPamkV6xNmi7zU5OUZgtI/nMJSjlDGat3+yL29S8oOCOQWKSdXQr2sOewSwag
         1JXw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@gmail.com header.s=20210112 header.b=omFlQflt;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Return-Path: <linux-crypto-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id dm7si3120964ejc.161.2021.09.02.19.33.22;
        Thu, 02 Sep 2021 19:33:59 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@gmail.com header.s=20210112 header.b=omFlQflt;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1344741AbhICBPG (ORCPT <rfc822;will.sands.v@gmail.com>
        + 99 others); Thu, 2 Sep 2021 21:15:06 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56580 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233467AbhICBPF (ORCPT
        <rfc822;linux-crypto@vger.kernel.org>);
        Thu, 2 Sep 2021 21:15:05 -0400
Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AE42C061575;
        Thu,  2 Sep 2021 18:14:04 -0700 (PDT)
Received: by mail-wr1-x42c.google.com with SMTP id q11so5762225wrr.9;
        Thu, 02 Sep 2021 18:14:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:from:date:message-id:subject:to;
        bh=wDGw9jS/MTv37T06LNdhRlV9dv+DZoHzz+VFlgPfmO8=;
        b=omFlQfltboSk1QU/I0UiBWwcvPsZOoW+42kTHvGhx/AFgUPSLtO5ZJmmeeqBcPZKZ9
         DA2F/dMxcNNBa4XYzLn+/CKdSmvxWP2UWgvm9OdFdbpVBpjGB7V16QyzD7Lzv1dLbIQM
         AaaIR9PY4QXgDEvH+BCzOfJIzeiZ85Q0vrT3Vk/vUvAwUdbm2n1VK721x1l/heAGZiBz
         GHHqDrJUgQXi6oIu98oGC1gFP3cKaDotjOcvpkLJj6bGXk1uJoDqlxOIcuvecdoUX3xG
         WFpOy9ZWYxRoRNv6tnpYUrQOOcv/xRsHkYsAAAykY7Nz6p2+KdVTOjOBjVb0oYIWGJvS
         w/AQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=wDGw9jS/MTv37T06LNdhRlV9dv+DZoHzz+VFlgPfmO8=;
        b=GVhJgxpXtP9CiF4Z3HlMrphr7PhDQVq7PdclFKiaQfPsqE4L4MuC+JcMUgtZVTacXt
         /LUN2X+pCvsePTLWcEF9wkeeXI9gLYWITqrVOQmjHqyTKJX2UfZBpemB0+zEO3rFSW0v
         VvsMe69MRHXYMC40qrtmn1KNqeLJS3TwJh0rNyT2jIlI5rCMJyqgEYiUBRtcgRSTWOT+
         QBV3s1QlLLWY5ft3a4PQeIxuVqHBSA9WkR94W2gleYg30ISfcX5q+/JiuAt7GAP9jdNL
         R9+5dWlLW3sBVsN9vFsYLDoBrBhK6O1xbtOOfOEvoQF5nPpipjYJLZZ8mYWKdEJ5H7n+
         JKUw==
X-Gm-Message-State: AOAM532B9jVgcKXQh3Sk3Za8Iktmbcsfyf02zLnzLrMmIfLsHgrW74AM
        LqyQ1L9V5ZMfuYJZp1Uy5wmU+svKbv27w1/9TrHLpYA2xcc=
X-Received: by 2002:adf:b7c2:: with SMTP id t2mr943448wre.375.1630631642523;
 Thu, 02 Sep 2021 18:14:02 -0700 (PDT)
MIME-Version: 1.0
From:   Sandy Harris <sandyinchina@gmail.com>
Date:   Fri, 3 Sep 2021 09:13:43 +0800
Message-ID: <CACXcFmnOeHwuu4N=WiGrMB+NNgGer9oCLoG0JAORN03gv1y+HQ@mail.gmail.com>
Subject: memset() in crypto code
To:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Doing this the crypto directory:
grep memset *.c | wc -l
I get 137 results.

The compiler may optimise memset() away, subverting the intent of
these operations. We have memzero_explicit() to avoid that problem.

Should most or all those memset() calls be replaced?