Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CACXcFmm798P6mPErh9B4thz7uvBG1sUO-eJpa1MB+7ayDyTCvw@mail.gmail.com>
 <YTmCyOTFADDSTdQm@sol.localdomain>
In-Reply-To: <YTmCyOTFADDSTdQm@sol.localdomain>
From:   Sandy Harris <sandyinchina@gmail.com>
Date:   Thu, 9 Sep 2021 13:14:42 +0800
Message-ID: <CACXcFmmpf+bkjr3oiMcABCbXE+LnNQxWXXSiuVk-GMYV09u+Zw@mail.gmail.com>
Subject: Re: [PATCH] In _extract-crng mix in 64 bits if possible
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        "Ted Ts'o" <tytso@mit.edu>,
        Herbert Xu <herbert@gondor.apana.org.au>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Sep 9, 2021 at 11:43 AM Eric Biggers <ebiggers@kernel.org> wrote:

> This patch is corrupted and doesn't apply.
> ...
> > -    unsigned long v, flags;
> > +    unsigned long v, flags, *last;
> > +    last = (unsigned long *) &crng->state[14] ;
>
> How do you know that this has the right alignment for an unsigned long?

Good question, thanks. I don't & that's definitely a bug.

On my version, which includes patches I have not sent yet, it is
necessarily 64-bit aligned.