Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <7552eec6c65807fe75127215e7996b76dd851653.camel@linux.ibm.com>
Subject: Re: [PATCH v5 07/12] KEYS: Introduce link restriction to include
 builtin, secondary and machine keys
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Eric Snowberg <eric.snowberg@oracle.com>
Cc:     keyrings@vger.kernel.org,
        linux-integrity <linux-integrity@vger.kernel.org>,
        David Howells <dhowells@redhat.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        James Morris <jmorris@namei.org>,
        "Serge E . Hallyn" <serge@hallyn.com>, keescook@chromium.org,
        gregkh@linuxfoundation.org, torvalds@linux-foundation.org,
        scott.branden@broadcom.com, weiyongjun1@huawei.com,
        nayna@linux.ibm.com, ebiggers@google.com, ardb@kernel.org,
        nramas@linux.microsoft.com, lszubowi@redhat.com,
        linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        James.Bottomley@HansenPartnership.com, pjones@redhat.com,
        "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>
Date:   Thu, 09 Sep 2021 14:19:53 -0400
In-Reply-To: <6BD395AE-2549-4E33-8F4F-34B3BDB0649A@oracle.com>
References: <20210907160110.2699645-1-eric.snowberg@oracle.com>
         <20210907160110.2699645-8-eric.snowberg@oracle.com>
         <b8ba9facf525c60760b49da6cea50d701ad5613d.camel@linux.ibm.com>
         <6BD395AE-2549-4E33-8F4F-34B3BDB0649A@oracle.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2021-09-09 at 12:03 -0600, Eric Snowberg wrote:
> > On Sep 9, 2021, at 11:26 AM, Mimi Zohar <zohar@linux.ibm.com> wrote:
> > 
> > Hi Eric,
> > 
> > The subject line above is too long.   According to
> > Documentation/process/submitting-patches.rst the "the ``summary`` must
> > be no more than 70-75 characters".
> > 
> > On Tue, 2021-09-07 at 12:01 -0400, Eric Snowberg wrote:
> >> Introduce a new link restriction that includes the trusted builtin,
> >> secondary and machine keys. The restriction is based on the key to be added
> >> being vouched for by a key in any of these three keyrings.
> >> 
> >> Suggested-by: Mimi Zohar <zohar@linux.ibm.com>
> >> Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com>
> >> ---
> >> v3: Initial version
> >> v4: moved code under CONFIG_INTEGRITY_MOK_KEYRING
> >> v5: Rename to machine keyring
> >> ---
> >> certs/system_keyring.c        | 23 +++++++++++++++++++++++
> >> include/keys/system_keyring.h |  6 ++++++
> >> 2 files changed, 29 insertions(+)
> >> 
> >> diff --git a/certs/system_keyring.c b/certs/system_keyring.c
> >> index 08ea542c8096..955bd57815f4 100644
> >> --- a/certs/system_keyring.c
> >> +++ b/certs/system_keyring.c
> >> @@ -99,6 +99,29 @@ void __init set_machine_trusted_keys(struct key *keyring)
> >> {
> >> 	machine_trusted_keys = keyring;
> >> }
> >> +
> >> +/**
> >> + * restrict_link_by_builtin_secondary_and_ca_trusted
> > 
> > Sorry for the patch churn.  With the keyring name change to ".machine",
> > the restriction name should also reflect this change.
> 
> Yes, I can change that. Should it be renamed to 
> restrict_link_by_builtin_secondary_and_machine_trusted? That seems a little
> long though.  Thanks.

The existing name is long too.  Not sure it makes much of a difference,
but dropping "and" and/or "trusted" might help.

Mimi