Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 15 Sep 2021 09:51:46 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org, alex.williamson@redhat.com,
        mgurtovoy@nvidia.com, linuxarm@huawei.com, liulongfang@huawei.com,
        prime.zeng@hisilicon.com, jonathan.cameron@huawei.com,
        wangzhou1@hisilicon.com
Subject: Re: [PATCH v3 4/6] hisi-acc-vfio-pci: add new vfio_pci driver for
 HiSilicon ACC devices
Message-ID: <20210915125146.GI4065468@nvidia.com>
References: <20210915095037.1149-1-shameerali.kolothum.thodi@huawei.com>
 <20210915095037.1149-5-shameerali.kolothum.thodi@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210915095037.1149-5-shameerali.kolothum.thodi@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iYgouChASin7p3CKCfx0jsIN/1LT0fVX8mmEIvzVP0N5iZ69M7nbUjH5aInu?=
 =?us-ascii?Q?8g40zp0SoJJVQrHD4VYk+rEfQqaMdeGVXxFhDVc2V3IsQ+yOyC642jDM5Il3?=
 =?us-ascii?Q?l3ik7vYYYIEbAgsVAFMu+1qH/9Zu7jmY6u+240kGnkz1FTn3btU7Lg2gPzAy?=
 =?us-ascii?Q?4LnfkFZAZSXKA6WUjMa9E7j1bVmi6iaJO+sCN6nTJu1W9f3LlPi84PkwFu7/?=
 =?us-ascii?Q?+29TOZmuTukLP3dd6EBT22AEvoRb8VnM3EmPDqcA0/5xxxwLsQ6WUG9piy1V?=
 =?us-ascii?Q?NKyY9V6j7HubZhVQ4jjHOFb8P31FEUeKfI6sneUOSAhL8yueIFEZXGXX5JKM?=
 =?us-ascii?Q?7WUcYoQTgD8YSJwUjmTu9E+WOdQmDFU8gJAPRd9NHVvaYcGA+5rax8Vv1Wqi?=
 =?us-ascii?Q?b9+WqzUq682gSo9NhLrs4ON1hPZ83jPRX6CZp27S5NkMzlwADXBm7KLIhRit?=
 =?us-ascii?Q?tl6BaDoWV+uEyaswli/26lGp4qE5s9EKOw2usXFPnpCkPaKSJY1qt/r9fCht?=
 =?us-ascii?Q?iJiHIpBM3i1vXsFmWRXBmu92aj/tKZrSIbPgKLrFB7bgPPwiHTofpbm2vOPf?=
 =?us-ascii?Q?vjn6+Zba3gYBgeIzMx0jpHlDWrfO+/2DeC8sEDR5zmnLZqFfj+l9xRd7emjB?=
 =?us-ascii?Q?8WsqMYMwtlfY+ejJkuvYgW+fqSXw6nTTZbfOFQL8YqZAhfsbB5+4vWyVix8J?=
 =?us-ascii?Q?kZ34QA9jTO0JLGF725KejeEtWX5qp+mD3pWDbEiPhuN6paBPvegUcqaNe6tG?=
 =?us-ascii?Q?j+hW+2ezC9t/kkZSTwASiTF8CUNioHCGU09vydTYqAZEMPWGZogmsgR/NXqI?=
 =?us-ascii?Q?sX1CwZw+w41lQPIlllpVGkxnK+o7qhqxERlaOHjQXXCwc+WYKmNRCwjqDrig?=
 =?us-ascii?Q?64Jz9fb6Le1a10Ton0psqQHQeHGIoK+AqVf9NezTj8QbWcmeyYVMCEzW/lRo?=
 =?us-ascii?Q?cT3LQJEMQSzcgs3JldZBlN9nWUwnSUAnvRQS5gYJJ67ueYAdlubH/06Hvb3i?=
 =?us-ascii?Q?Wtq55XAbgp+nybf/Z6YbPvtNr9LjaQ0cyi0Rcb/nAM58E9IvoB87VEfklbeF?=
 =?us-ascii?Q?EvOP0pAahNctcet8lMJo2PgJNT3e6DPj2x7bU1VQ5MQj1s7ckBi4DGR1MhTa?=
 =?us-ascii?Q?6+BjJvmNTL8m5P3nVfbr/XiFm0e6LFtaWwKaqA/5wWHFdCjMvgxaFqCmQmN5?=
 =?us-ascii?Q?YIS6aUzOqlfWFxxaiaUqGehYu1TAH6o0xMGrckSkWv+bsj3LaBDmo/Kh7Zsv?=
 =?us-ascii?Q?1KLk0QltR4wdyYGfzlXDVEgyj0p/laA5kmrAdd3KWffaTRsctbA3bbCVzTtT?=
 =?us-ascii?Q?mUyvbpOC71l3AcHmpaU44hcV?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7f1d142-14f3-4464-13ad-08d97847947a
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 12:51:48.0248
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EelXkKUY+WeuaXSt+RoQnZiuAwu5klDs8mbKTTh8yYbilLFyEo3N0G9ORgQaXyeV
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5304
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Wed, Sep 15, 2021 at 10:50:35AM +0100, Shameer Kolothum wrote:
> +static const struct vfio_device_ops hisi_acc_vfio_pci_ops = {
> +	.name		= "hisi-acc-vfio-pci",
> +	.open_device	= hisi_acc_vfio_pci_open_device,
> +	.close_device	= vfio_pci_core_close_device,
> +	.ioctl		= vfio_pci_core_ioctl,
> +	.read		= vfio_pci_core_read,
> +	.write		= vfio_pci_core_write,
> +	.mmap		= vfio_pci_core_mmap,
> +	.request	= vfio_pci_core_request,
> +	.match		= vfio_pci_core_match,
> +};

Avoid horizontal alignments please

> +static void hisi_acc_vfio_pci_remove(struct pci_dev *pdev)
> +{
> +	struct vfio_pci_core_device *vdev = dev_get_drvdata(&pdev->dev);
> +
> +	vfio_pci_core_unregister_device(vdev);
> +	vfio_pci_core_uninit_device(vdev);
> +	kfree(vdev);
> +}
> +
> +static const struct pci_device_id hisi_acc_vfio_pci_table[] = {
> +	{ PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_HUAWEI, SEC_VF_PCI_DEVICE_ID) },
> +	{ PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_HUAWEI, HPRE_VF_PCI_DEVICE_ID) },
> +	{ PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_HUAWEI, ZIP_VF_PCI_DEVICE_ID) },
> +	{ 0, }

Just {}

> +};
> +
> +MODULE_DEVICE_TABLE(pci, hisi_acc_vfio_pci_table);
> +
> +static struct pci_driver hisi_acc_vfio_pci_driver = {
> +	.name			= "hisi-acc-vfio-pci",

This shoud be KBUILD_MODNAME, the string must always match the module
name 

Jason