Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Marek Vasut <marex@denx.de>, linux-crypto@vger.kernel.org
Cc:     ch@denx.de, Herbert Xu <herbert@gondor.apana.org.au>,
        =?UTF-8?Q?Horia_Geant=c4=83?= <horia.geanta@nxp.com>,
        Iuliana Prodan <iuliana.prodan@nxp.com>
References: <20210916134154.8764-1-marex@denx.de>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Subject: Re: [RFC][PATCH] crypto: caam - Add missing MODULE_ALIAS
Message-ID: <441a7e2e-7ac8-5000-72e0-3793ae7e58d5@canonical.com>
Date:   Thu, 16 Sep 2021 15:59:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210916134154.8764-1-marex@denx.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 16/09/2021 15:41, Marek Vasut wrote:
> Add MODULE_ALIAS for caam and caam_jr modules, so they can be auto-loaded.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Horia Geantă <horia.geanta@nxp.com>
> Cc: Iuliana Prodan <iuliana.prodan@nxp.com>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/crypto/caam/ctrl.c | 1 +
>  drivers/crypto/caam/jr.c   | 1 +
>  2 files changed, 2 insertions(+)
> 

Since you marked it as RFC, let me share a comment - would be nice to
see here explanation why do you need module alias.

Drivers usually do not need module alias to be auto-loaded, unless the
subsystem/bus reports different alias than one used for binding. Since
the CAAM can bind only via OF, I wonder what is really missing here. Is
it a MFD child (it's one of cases this can happen)?


Best regards,
Krzysztof