Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC][PATCH] crypto: caam - Add missing MODULE_ALIAS
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        linux-crypto@vger.kernel.org
Cc:     ch@denx.de, Herbert Xu <herbert@gondor.apana.org.au>,
        =?UTF-8?Q?Horia_Geant=c4=83?= <horia.geanta@nxp.com>,
        Iuliana Prodan <iuliana.prodan@nxp.com>
References: <20210916134154.8764-1-marex@denx.de>
 <441a7e2e-7ac8-5000-72e0-3793ae7e58d5@canonical.com>
From:   Marek Vasut <marex@denx.de>
Message-ID: <08afb147-07c7-9fbb-4a0c-8a79717b06b7@denx.de>
Date:   Thu, 16 Sep 2021 16:06:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <441a7e2e-7ac8-5000-72e0-3793ae7e58d5@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/16/21 3:59 PM, Krzysztof Kozlowski wrote:
> On 16/09/2021 15:41, Marek Vasut wrote:
>> Add MODULE_ALIAS for caam and caam_jr modules, so they can be auto-loaded.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Herbert Xu <herbert@gondor.apana.org.au>
>> Cc: Horia Geantă <horia.geanta@nxp.com>
>> Cc: Iuliana Prodan <iuliana.prodan@nxp.com>
>> Cc: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
>>   drivers/crypto/caam/ctrl.c | 1 +
>>   drivers/crypto/caam/jr.c   | 1 +
>>   2 files changed, 2 insertions(+)
>>
> 
> Since you marked it as RFC, let me share a comment - would be nice to
> see here explanation why do you need module alias.
> 
> Drivers usually do not need module alias to be auto-loaded, unless the
> subsystem/bus reports different alias than one used for binding. Since
> the CAAM can bind only via OF, I wonder what is really missing here. Is
> it a MFD child (it's one of cases this can happen)?

I noticed the CAAM is not being auto-loaded on boot, and then I noticed 
the MODULE_ALIAS fixes cropping up in the kernel log, but I couldn't 
find a good documentation for that MODULE_ALIAS. So I was hoping to get 
a feedback on it.