Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210914142428.57099-1-u.kleine-koenig@pengutronix.de>
In-Reply-To: <20210914142428.57099-1-u.kleine-koenig@pengutronix.de>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Sun, 19 Sep 2021 22:07:15 +0200
Message-ID: <CAFBinCAFp1FfRdQqKu3j3R1zsDFaeomcFB2DJOEjjKV6jJepTg@mail.gmail.com>
Subject: Re: [PATCH] hwrng: meson - Improve error handling for core clock
To:     =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>
Cc:     Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, kernel@pengutronix.de
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Uwe,

On Tue, Sep 14, 2021 at 4:24 PM Uwe Kleine-K=C3=B6nig
<u.kleine-koenig@pengutronix.de> wrote:
[...]
> -       data->core_clk =3D devm_clk_get(dev, "core");
> -       if (IS_ERR(data->core_clk))
> -               data->core_clk =3D NULL;
> +       data->core_clk =3D devm_clk_get_optional(dev, "core");
> +       if (IS_ERR(data->core_clk)) {
> +               ret =3D PTR_ERR(data->core_clk);
> +               if (ret !=3D -EPROBE_DEFER)
> +                       dev_err(dev, "Failed to get core clock: %pe\n",
> +                               data->core_clk);
> +
> +               return ret;
I suggest simplifying this by using dev_err_probe as this:
- allows you to get rid of the if (ret !=3D -EPROBE_DEFER)
- means that the message is shown in debugfs' "devices_deferred"


Best regards,
Martin