Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1ea7a9bd9f6d74e1b9a002a19c0923f184c17c88.camel@kernel.org>
Subject: Re: [PATCH] X.509: Support parsing certificate using SM2 algorithm
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
        David Howells <dhowells@redhat.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Biggers <ebiggers@google.com>,
        Eric Biggers <ebiggers@kernel.org>,
        Mimi Zohar <zohar@linux.ibm.com>,
        Vitaly Chikunov <vt@altlinux.org>,
        Gilad Ben-Yossef <gilad@benyossef.com>,
        Pascal van Leeuwen <pvanleeuwen@rambus.com>,
        keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Jia Zhang <zhang.jia@linux.alibaba.com>,
        "YiLin . Li" <YiLin.Li@linux.alibaba.com>
Date:   Wed, 22 Sep 2021 00:05:42 +0300
In-Reply-To: <99a79ccb-8dd9-ac37-2a1d-ec390bcb0c8a@linux.alibaba.com>
References: <20210712081352.23692-1-tianjia.zhang@linux.alibaba.com>
         <99a79ccb-8dd9-ac37-2a1d-ec390bcb0c8a@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Sat, 2021-09-18 at 10:25 +0800, Tianjia Zhang wrote:
> ping.
>=20
> On 7/12/21 4:13 PM, Tianjia Zhang wrote:
> > The SM2-with-SM3 certificate generated by latest openssl no longer
> > reuses the OID_id_ecPublicKey, but directly uses OID_sm2. This patch
> > supports this type of x509 certificate parsing.
> >=20
> > Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> > ---
> >   crypto/asymmetric_keys/x509_cert_parser.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >=20
> > diff --git a/crypto/asymmetric_keys/x509_cert_parser.c b/crypto/asymmet=
ric_keys/x509_cert_parser.c
> > index 6d003096b5bc..6a945a6ce787 100644
> > --- a/crypto/asymmetric_keys/x509_cert_parser.c
> > +++ b/crypto/asymmetric_keys/x509_cert_parser.c
> > @@ -496,6 +496,9 @@ int x509_extract_key_data(void *context, size_t hdr=
len,
> >   	case OID_gost2012PKey512:
> >   		ctx->cert->pub->pkey_algo =3D "ecrdsa";
> >   		break;
> > +	case OID_sm2:
> > +		ctx->cert->pub->pkey_algo =3D "sm2";
> > +		break;
> >   	case OID_id_ecPublicKey:
> >   		if (parse_OID(ctx->params, ctx->params_size, &oid) !=3D 0)
> >   			return -EBADMSG;
> >=20

Acked-by: Jarkko Sakkinen <jarkko@kernel.org>

/Jarkko