Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <6318b58cf9ede0ffcda396cd14572d0143f6a04e.camel@kernel.org>
Subject: Re: [PATCH] pkcs7: support EC-RDSA/streebog in SignerInfo
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
        Elvira Khabirova <e.khabirova@omp.ru>, keyrings@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
        davem@davemloft.net, herbert@gondor.apana.org.au,
        dhowells@redhat.com, vt@altlinux.org
Date:   Wed, 22 Sep 2021 00:07:25 +0300
In-Reply-To: <59bf7fdf-b06e-1533-865a-06c612f4a19c@linux.alibaba.com>
References: <20210511174744.4f3c6c59@msk1wst204>
         <59bf7fdf-b06e-1533-865a-06c612f4a19c@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Sat, 2021-09-18 at 10:39 +0800, Tianjia Zhang wrote:
> ping.
>=20
> On 5/11/21 10:47 PM, Elvira Khabirova wrote:
> > Allow using EC-RDSA/streebog in pkcs7 certificates in a similar way
> > to how it's done in the x509 parser.
> >=20
> > This is needed e.g. for loading kernel modules signed with EC-RDSA.
> >=20
> > Signed-off-by: Elvira Khabirova <e.khabirova@omp.ru>
> > ---
> >   crypto/asymmetric_keys/pkcs7_parser.c | 11 +++++++++++
> >   1 file changed, 11 insertions(+)
> >=20
> > diff --git a/crypto/asymmetric_keys/pkcs7_parser.c b/crypto/asymmetric_=
keys/pkcs7_parser.c
> > index 967329e0a07b..39c260a04167 100644
> > --- a/crypto/asymmetric_keys/pkcs7_parser.c
> > +++ b/crypto/asymmetric_keys/pkcs7_parser.c
> > @@ -248,6 +248,12 @@ int pkcs7_sig_note_digest_algo(void *context, size=
_t hdrlen,
> >   	case OID_sha224:
> >   		ctx->sinfo->sig->hash_algo =3D "sha224";
> >   		break;
> > +	case OID_gost2012Digest256:
> > +		ctx->sinfo->sig->hash_algo =3D "streebog256";
> > +		break;
> > +	case OID_gost2012Digest512:
> > +		ctx->sinfo->sig->hash_algo =3D "streebog512";
> > +		break;
> >   	default:
> >   		printk("Unsupported digest algo: %u\n", ctx->last_oid);
> >   		return -ENOPKG;
> > @@ -269,6 +275,11 @@ int pkcs7_sig_note_pkey_algo(void *context, size_t=
 hdrlen,
> >   		ctx->sinfo->sig->pkey_algo =3D "rsa";
> >   		ctx->sinfo->sig->encoding =3D "pkcs1";
> >   		break;
> > +	case OID_gost2012PKey256:
> > +	case OID_gost2012PKey512:
> > +		ctx->sinfo->sig->pkey_algo =3D "ecrdsa";
> > +		ctx->sinfo->sig->encoding =3D "raw";
> > +		break;
> >   	default:
> >   		printk("Unsupported pkey algo: %u\n", ctx->last_oid);
> >   		return -ENOPKG;
> >=20

Acked-by: Jarkko Sakkinen <jarkko@kernel.org>

/Jarkko