Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 17/19] selftests: Add -t tcp_authopt option for
 fcnal-test.sh
To:     David Ahern <dsahern@gmail.com>,
        Dmitry Safonov <0x7f454c46@gmail.com>,
        David Ahern <dsahern@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc:     Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Kuniyuki Iwashima <kuniyu@amazon.co.jp>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Yuchung Cheng <ycheng@google.com>,
        Francesco Ruggeri <fruggeri@arista.com>,
        Mat Martineau <mathew.j.martineau@linux.intel.com>,
        Christoph Paasch <cpaasch@apple.com>,
        Ivan Delalande <colona@arista.com>,
        Priyaranjan Jha <priyarjha@google.com>, netdev@vger.kernel.org,
        linux-crypto@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <cover.1632240523.git.cdleonard@gmail.com>
 <c52733a1cd9a7bd16aea0b6e056fad9dd1cc5aed.1632240523.git.cdleonard@gmail.com>
 <c72ad0be-9499-dcfb-0faa-be3dd51f4a86@gmail.com>
From:   Leonard Crestez <cdleonard@gmail.com>
Message-ID: <5471a640-d2e9-8f92-84ba-bf4fb136abe2@gmail.com>
Date:   Sat, 25 Sep 2021 17:38:03 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <c72ad0be-9499-dcfb-0faa-be3dd51f4a86@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/25/21 4:52 AM, David Ahern wrote:
> On 9/21/21 10:15 AM, Leonard Crestez wrote:
>> This script is otherwise very slow to run!
> 
> there are a lot of permutations to cover.

I believe that some of the sleeps are not necessary and could be 
replaced with waits.

>>
>> Signed-off-by: Leonard Crestez <cdleonard@gmail.com>
>> ---
>>   tools/testing/selftests/net/fcnal-test.sh | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
>> index 74a7580b6bde..484734db708f 100755
>> --- a/tools/testing/selftests/net/fcnal-test.sh
>> +++ b/tools/testing/selftests/net/fcnal-test.sh
>> @@ -1331,10 +1331,21 @@ ipv4_tcp()
>>   	log_subsection "With VRF"
>>   	setup "yes"
>>   	ipv4_tcp_vrf
>>   }
>>   
>> +
>> +only_tcp_authopt()
>> +{
>> +	log_section "TCP Authentication"
>> +	setup
>> +	set_sysctl net.ipv4.tcp_l3mdev_accept=0
>> +	log_subsection "IPv4 no VRF"
>> +	ipv4_tcp_authopt
> 
> This feature needs to work with VRF from the beginning. v4, v6, with and
> without VRF.

I ignored the l3mdev feature because I'm not familiar with it but I'll 
go through it.

--
Regards,
Leonard