Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Cc:     brijesh.singh@amd.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        linux-crypto@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>, tony.luck@intel.com,
        marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH Part2 v5 04/45] x86/sev: Add RMP entry lookup helpers
To:     Borislav Petkov <bp@alien8.de>
References: <20210820155918.7518-1-brijesh.singh@amd.com>
 <20210820155918.7518-5-brijesh.singh@amd.com> <YU2fQMgw+PIBzSE4@zn.tnic>
From:   Brijesh Singh <brijesh.singh@amd.com>
Message-ID: <a5be6103-f643-fed2-b01a-d0310f447d7a@amd.com>
Date:   Mon, 27 Sep 2021 11:01:37 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <YU2fQMgw+PIBzSE4@zn.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFNVSHdxdlZLU3dySGIydCtTV01uaG1iUUk0ckhtNWlqZzZLUVdzd3VuaGJL?=
 =?utf-8?B?OERjSE5sSG8wY3VaZ3NIdFFSKzNUakY3QjltZ3RtUEdSZXFrRm9MRXdoRW9L?=
 =?utf-8?B?cFB6c0xYaTVIRk9JQ2xRLzkwMm0xRmpKK0xPdzVNZFFodko3MTJ6QUJkODBP?=
 =?utf-8?B?TjduTjQ3SVFRM0lvMDRkdVJjRHo3bnd6cUZyT0J6aEhHdCtUMnFvckErSFlp?=
 =?utf-8?B?emQ5OEZyd0FqWHFJUWY1OWJLbmVsUG9XNDkrUm5DaG10bnhtalMyNXRXL2ow?=
 =?utf-8?B?RnVkeS9nUEwrV3k2SDAzVit6bG1ZUURZZFdacERPVm9OdnlDN3JZLzN6b0Nr?=
 =?utf-8?B?TWlBeXllWHl1cHl2NDExdDNpSkVQalMxZTVZZ1Fld0x2OGxzT1l5bHJVdzlN?=
 =?utf-8?B?YzhSN2M2VnhGd1R0bHlBVkFNejU4NU4rUnJEWWxQR2U2NFArUEZUN01VaW5k?=
 =?utf-8?B?c3BDb0NMZzY5WWxOa1kvSk9ySEdDNUlBSklrSnpTRHp3UnJrbGViRVBxYkh6?=
 =?utf-8?B?M2ZVdnNJT3BjQnhpUU5YVmRZdVF4Q05BUGNVV0dHTFlMZmRjNXZvK3ZLdCs1?=
 =?utf-8?B?aWNPWWhzcjQ5RnJKL0lJNXpvTkhEcXE1R1RBQ3hwYWlUWVBDSlVZWTI4Z0x0?=
 =?utf-8?B?TStaSGpJMWJFSUR3MHlOdmZZVzNxUkU3WVppTUR6MjQ1ckNRY2crRG0rSTlE?=
 =?utf-8?B?U3RGTDlGWjZrRUJMNWQwek5UU2tTVStraHRiRVE1aFNmM3dUOHVLbWxoclZN?=
 =?utf-8?B?OUhZdHVEUTRXVUtZZHUvOHRxQ3lZU0M5bU95QS9QWXJpVDNPVngzOXVHSm9x?=
 =?utf-8?B?THhVOStyNjlNSEZQYWhYMlc4eXFWTm9zY1RtMjc4NCtkYUZWL2ZFQWNnWUNO?=
 =?utf-8?B?MnRZTXgxam1iaTFPQlo3VGVaZmtraDFYSnhjaG9ETGEwKzJQZFlJYk1mNjkx?=
 =?utf-8?B?U1BPZUlsM3pTcmJaRVdKR3RmSUdBWTN0ZXV4V3VzaVc1dGhBOWR5VzdlNTNU?=
 =?utf-8?B?VFdRTDZHclZOcmozV1FycFowVENFY3JsYnBSUHQ1c2dxK3Z0UHhZZEZxOGpX?=
 =?utf-8?B?cVlFQkVZeHhRd2o1ZzN5S1dhZXppTkZoZ2xyNnFOb05sNW04WGluaDNvT0tj?=
 =?utf-8?B?dlBWRjRwQ0ZmVDQvWmc3Uy9oZFY2bmhlMjdYaGx0T0RKeHZ1U3k0ZmIyM0Va?=
 =?utf-8?B?d1p2cTVZWk03QUdxcXlLN0NoTkFZWjRwbW1lUmdDM014bzZWcWQyeElnMjRM?=
 =?utf-8?B?dWZYWnZTOFpmbnlNYTZsY1ZRZU1rSDV4YmpNMU84d1Fkd3FBSHJQWkd0UDMx?=
 =?utf-8?B?cmt1RFNIYnJmU0xiUlR0ZEpEa0pqKysxdWk0bnBLK1JlUWI4TElsM0VYZkM1?=
 =?utf-8?B?c1VlT0t4QjAxYTZKT1BWNmNkbTRMNGpUWnFxWW4wMkl4TXJwU09zakhZZXNU?=
 =?utf-8?B?WWQ3bzJWUnNLTDd3dXcwckVGUXFBMTB5cE9INGtlUHo2OWtZd0hyMVBPL0RK?=
 =?utf-8?B?K3hhSzZvWnRmMkdGVEsyOHV4bGNlQ0VsRHNIaHJFdFc4Q3FEbmFnK1lpZmlh?=
 =?utf-8?B?cWczTG9XQlFhd2xSME11cU9JeWRkUGtqSTQ5YTY1Mnkyb2RseXpYZ0xWcFRB?=
 =?utf-8?B?czd2RkVhSTJBSzNRNHAxeCt5NWVvUzlGbmMwVTVxQ2pyTm1sVjlxSVcyZlpY?=
 =?utf-8?B?R25oT25MandLdDh4Skk3Sitsdmx2cmFnRUF0MGEzV0h2SlVOQVNZaXhmbzdB?=
 =?utf-8?Q?WRlREcSQ4s1BDtHPEv7dLmszjA93duZAhoVIT8U?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7e808f3-7713-4248-a00d-08d981d01731
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 16:01:39.5382
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VURkydOIh5h0Gg6kS9PVCGFJ+b8vm4yNWHuzyo444v+XK14GYFPEt7e8m1fokbPCQlhYQ9XcFPnrw3v9Twq44Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2718
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi Boris,

I agreed with all of your comment, responding to your specific questions.

On 9/24/21 4:49 AM, Borislav Petkov wrote:
...

>> +}
>> +EXPORT_SYMBOL_GPL(snp_lookup_rmpentry);
> 
> This export is for kvm, I presume?

yes, both KVM and CCP (i.e PSP) driver will need to lookup RMP entries.

> 
>> diff --git a/include/linux/sev.h b/include/linux/sev.h
>> new file mode 100644
>> index 000000000000..1a68842789e1
>> --- /dev/null
>> +++ b/include/linux/sev.h
>> @@ -0,0 +1,30 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * AMD Secure Encrypted Virtualization
>> + *
>> + * Author: Brijesh Singh <brijesh.singh@amd.com>
>> + */
>> +
>> +#ifndef __LINUX_SEV_H
>> +#define __LINUX_SEV_H
>> +
>> +/* RMUPDATE detected 4K page and 2MB page overlap. */
>> +#define RMPUPDATE_FAIL_OVERLAP		7
>> +
>> +#ifdef CONFIG_AMD_MEM_ENCRYPT
>> +int snp_lookup_rmpentry(u64 pfn, int *level);
>> +int psmash(u64 pfn);
>> +int rmp_make_private(u64 pfn, u64 gpa, enum pg_level level, int asid, bool immutable);
>> +int rmp_make_shared(u64 pfn, enum pg_level level);
>> +#else
>> +static inline int snp_lookup_rmpentry(u64 pfn, int *level) { return 0; }
>> +static inline int psmash(u64 pfn) { return -ENXIO; }
>> +static inline int rmp_make_private(u64 pfn, u64 gpa, enum pg_level level, int asid,
>> +				   bool immutable)
>> +{
>> +	return -ENODEV;
>> +}
>> +static inline int rmp_make_shared(u64 pfn, enum pg_level level) { return -ENODEV; }
>> +
>> +#endif /* CONFIG_AMD_MEM_ENCRYPT */
>> +#endif /* __LINUX_SEV_H */
>> -- 
> 
> What is going to use this linux/ namespace header?
> 

The kvm and ccp drivers.