Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Sep 2021 15:22:24 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Leon Romanovsky <leonro@nvidia.com>
Cc:     Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "mgurtovoy@nvidia.com" <mgurtovoy@nvidia.com>,
        liulongfang <liulongfang@huawei.com>,
        "Zengtao (B)" <prime.zeng@hisilicon.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        "Wangzhou (B)" <wangzhou1@hisilicon.com>
Subject: Re: [PATCH v3 6/6] hisi_acc_vfio_pci: Add support for VFIO live
 migration
Message-ID: <20210927182224.GA1575668@nvidia.com>
References: <20210915095037.1149-1-shameerali.kolothum.thodi@huawei.com>
 <20210915095037.1149-7-shameerali.kolothum.thodi@huawei.com>
 <20210915130742.GJ4065468@nvidia.com>
 <fe5d6659e28244da82b7028b403e11ae@huawei.com>
 <20210916135833.GB327412@nvidia.com>
 <a440256250c14182b9eefc77d5d399b8@huawei.com>
 <20210927150119.GB964074@nvidia.com>
 <YVHqlzyIX3099Gtz@unreal>
 <20210927160627.GC964074@nvidia.com>
 <YVIKr48e8G1wSxYX@unreal>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YVIKr48e8G1wSxYX@unreal>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Gvkt+RSR0kpchVFscfv4I1inblvDbuspfZc/t8AG+45tlbiDhA9c+bpowwqa?=
 =?us-ascii?Q?5ZT2lQfVJa7pciDY4e6m6O3ZoHXiBfyH6XhIWdXm4q+sw/4Bk1ZZnq3UQUGk?=
 =?us-ascii?Q?PFUgiz8AByK3IOxY0y92tzh9aTaJPSR5rWidPikHpQ8HULlW9eUskaaf0bf5?=
 =?us-ascii?Q?o3BVcnJNWctAD2LZqhleVb4veitv+5MlekJj+psCQak7t7ovdFgoBzU4tTmE?=
 =?us-ascii?Q?IbDcbEJRvQ0ZGyyMFk3H1ve7EJ5m4/BXowkoWo9eqND6cmFmdfbPee6CI+X5?=
 =?us-ascii?Q?GjJSMmc6kylnDtgkmbr2YxGommFtwWGNcAFISH5QAcLMzY1ql07A0y8zcNWo?=
 =?us-ascii?Q?7kEK13t4HuSGt0h+oH0RZehTgJdemQxaHYGRXv8s9jNGWMyLUCLN7lphS7qY?=
 =?us-ascii?Q?6+gBfQDXlcnaWFQrsxAHOeMB5V8zZk511zF16UppLNTivYxGo9b8LRVISFtE?=
 =?us-ascii?Q?koaeXnMm6RP3St0H4Mn938oFG4r7MhOueUElkypNLzBgObaImZzGXNfLjDZ1?=
 =?us-ascii?Q?cfnzqxQk3oEgaRorn7FFdsMDRFpOK4CfQ3VQRCvtfd5uccoercxooyLYnobd?=
 =?us-ascii?Q?UpbpLPxSeQ4osHKY/nFjJ511hne272cg0kMuOdV2kcBMT1BmEH9lnU60Ol4k?=
 =?us-ascii?Q?xQteR1OkU4/9SvryEQKE+bYQ5JpZfjLTI9xruTZtU1Ql+dWi+UPkolBAdj/K?=
 =?us-ascii?Q?ZC9rjaaV1t9fefyBSLCW3H2fRcwbNrwpz3roiuZeTR7jm8yZfzvup3d7JiOC?=
 =?us-ascii?Q?TeN7SYdvrAp6V5zipyyqvfWh60b+oCCc20x4ud0lfw6SgK3v6qp84+gZQ8HS?=
 =?us-ascii?Q?zf0BH+wSW/v87ak9MtQtGbNo+xPKgTuf5fAK6Glq1pc3970Ua8q3qm15vX35?=
 =?us-ascii?Q?rkY9j81MAlTtAwXeWn7rJ4EvTaF/ciFJ6v/vw18tQyMQIu7Rd3Eh7e2dgDPK?=
 =?us-ascii?Q?FUT/g4zBv7soplMf6/cIcRyjR9A8LEVf46m3TFjD8VrhOkEYwMNVGg+O0FJN?=
 =?us-ascii?Q?+bV2RgeTO7F3krcGCtvSFUDyKEPG8+uwUzUUFn4NYnDU2w3YnxL5ujzqg/6C?=
 =?us-ascii?Q?H/KHYp5NbMK1cAmZ4JDr5W6f1y5e8sfTPXdujodEY+ALneFNB2SZjuGEHdKo?=
 =?us-ascii?Q?ae063GQdU9iTRPO4jAdhN9po0/63sW0ptr5Mnj43EPjeLZU7eak2IKzNcm/p?=
 =?us-ascii?Q?VXUd/fraP/ZLIsws8iUWv2YE/PmUcW0zNwZiJSo9xwz4UgjPuuI0awgsEJmV?=
 =?us-ascii?Q?grctSZyGz7xyCCAYUbc7s/hZSB6dOHXe7DFBdAomFiRcpNmT+QmrUquTD2TE?=
 =?us-ascii?Q?z0gM2u96Rh5RPCXavmTWi3/H?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b44ad60-9cf9-4f85-e839-08d981e3c204
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 18:22:26.3899
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eUgn8YUMnDagTp7JtDebh7e+Q1FxRmF0M9T/+FqdEEk6Owq7eDyUsFyHxR4+MQhK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5288
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Mon, Sep 27, 2021 at 09:17:19PM +0300, Leon Romanovsky wrote:

> > The point is to all out a different locking regime that relies on the
> > sriov enable/disable removing the VF struct devices
> 
> You can't avoid trylock, because this pci_get_sriov_pf_devdata() will be
> called in VF where it already holds lock, so attempt to take PF lock
> will cause to deadlock.

My whole point is we cannot use the device_lock *at all* and a
pci_get_sriov_pf_devdata() would not have it.

Instead it would have some test to confirm that the 'current' struct
device is a VF of the 'target' struct device and thus the drvdata
must be valid so long as the 'current' struct device hasn't completed
remove.

It is a completely different locking scheme than device lock. It also
relies on the PF driver placing the sriov enable/disable 'locks' in
the correct place relative to their drvdata's.

Jason