Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 04/12] lib/base64: RFC4648-compliant base64 encoding
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
        Keith Busch <keith.busch@wdc.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org
References: <20210928060356.27338-1-hare@suse.de>
 <20210928060356.27338-5-hare@suse.de> <YVK1D+GZgdFPRsaS@sol.localdomain>
From:   Hannes Reinecke <hare@suse.de>
Message-ID: <2eee5e3c-265d-d84f-6214-ad3bcd19d169@suse.de>
Date:   Tue, 28 Sep 2021 09:16:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YVK1D+GZgdFPRsaS@sol.localdomain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/28/21 8:24 AM, Eric Biggers wrote:
> On Tue, Sep 28, 2021 at 08:03:48AM +0200, Hannes Reinecke wrote:
>> + * Return: the length of the resulting base64url-encoded string in bytes.
> 
> base64, not base64url.
> 
>> + * Decodes a string using base64url encoding, i.e. the "Base 64 Encoding"
>> + * specified by RFC 4648, including the  '='-padding.
> 
> base64, not base64url.
> 
Sheesh, you are right.

But now you know I've copied it as requested :-)

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@suse.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer