Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 13:26:37 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <uwe@kleine-koenig.org>,
        Fiona Trahe <fiona.trahe@intel.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Marco Chiappero <marco.chiappero@intel.com>,
        linux-pci@vger.kernel.org, qat-linux@intel.com,
        Bjorn Helgaas <helgaas@kernel.org>,
        linux-crypto@vger.kernel.org, kernel@pengutronix.de,
        Jack Xu <jack.xu@intel.com>,
        Wojciech Ziemba <wojciech.ziemba@intel.com>,
        Tomaszx Kowalik <tomaszx.kowalik@intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v4 6/8] crypto: qat - simplify adf_enable_aer()
Message-ID: <20210928112637.kolit6fusme7g2qf@pengutronix.de>
References: <20210927204326.612555-1-uwe@kleine-koenig.org>
 <20210927204326.612555-7-uwe@kleine-koenig.org>
 <YVL4aoKjUT2kvHip@silpixa00400314>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ivfl7y3ed6g54sur"
Content-Disposition: inline
In-Reply-To: <YVL4aoKjUT2kvHip@silpixa00400314>
Precedence: bulk


--ivfl7y3ed6g54sur
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Giovanni,

On Tue, Sep 28, 2021 at 12:11:38PM +0100, Giovanni Cabiddu wrote:
> On Mon, Sep 27, 2021 at 10:43:24PM +0200, Uwe Kleine-K=C3=B6nig wrote:
> > From: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> >=20
> > A struct pci_driver is supposed to be constant and assigning .err_handl=
er
> > once per bound device isn't really sensible. Also as the function retur=
ns
> > zero unconditionally let it return no value instead and simplify the
> > callers accordingly.
> >=20
> > As a side effect this removes one user of struct pci_dev::driver. This
> > member is planned to be removed.
> >=20
> > Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> > ---
>=20
> this patch does not build.
>=20
> drivers/crypto/qat/qat_c3xxx/adf_drv.c:36:24: error: =E2=80=98adf_err_han=
dler=E2=80=99 undeclared here (not in a function)
>    36 |         .err_handler =3D adf_err_handler,
>       |                        ^~~~~~~~~~~~~~~
> drivers/crypto/qat/qat_4xxx/adf_drv.c:303:24: error: =E2=80=98adf_err_han=
dler=E2=80=99 undeclared here (not in a function)
>   303 |         .err_handler =3D adf_err_handler,
>       |                        ^~~~~~~~~~~~~~~
> drivers/crypto/qat/qat_c62x/adf_drv.c:36:24: error: =E2=80=98adf_err_hand=
ler=E2=80=99 undeclared here (not in a function)
>    36 |         .err_handler =3D adf_err_handler,
>       |                        ^~~~~~~~~~~~~~~
> drivers/crypto/qat/qat_dh895xcc/adf_drv.c:36:24: error: =E2=80=98adf_err_=
handler=E2=80=99 undeclared here (not in a function)
>    36 |         .err_handler =3D adf_err_handler,
>       |                        ^~~~~~~~~~~~~~~
> make[2]: *** [scripts/Makefile.build:277: drivers/crypto/qat/qat_c3xxx/ad=
f_drv.o] Error 1

Hmm, I thought that was one of the things I actually tested after
rebasing. Will recheck.
=20
> Below is an updated version of your patch that fixes the issues.
>=20
> After fixing the patch you can add:
>     Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Thanks
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=C3=B6nig         =
   |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--ivfl7y3ed6g54sur
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmFS++sACgkQwfwUeK3K
7AleDwf9F69upmgTsIcwxJlGOkPLBOOUod9wpNHPeC/U99dCqa1cxHbte6dlKPGL
+yVfoPEduQpgJciGLHKs4wnkRnEAQx2Tfdy9OWlHmcDH1Ts+46RVZ/FODSuBGfob
LI4EEiWhkgm8Ky2kqvj9YEvcPiV8sm8xSQaMNsSZ9N1LFN27D5zEOxj5ykow434Z
9LU/BhsBdrCnASrEy3FroVOztTDg4Gaez+csKIpgz8FxkDvwcgPyDSJ74jaS62VM
en/sPkM+i1xWdCq0ec4A3iJWYQiL7U//qcirE8gXoLctM1Hon9nRrvY4Wh4mQqWF
LyffBo4d6kb3J+aqaVrAmOG5j8LZ9A==
=C4HR
-----END PGP SIGNATURE-----

--ivfl7y3ed6g54sur--