Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 1 Oct 2021 13:57:45 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Kai Ye <yekai13@huawei.com>
Cc:     linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        wangzhou1@hisilicon.com
Subject: Re: [PATCH v2 2/6] crypto: hisilicon/sec - add ahash alg features
 for Kunpeng920
Message-ID: <20211001055745.GA31918@gondor.apana.org.au>
References: <20210924092716.12848-1-yekai13@huawei.com>
 <20210924092716.12848-3-yekai13@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210924092716.12848-3-yekai13@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, Sep 24, 2021 at 05:27:12PM +0800, Kai Ye wrote:
>
> +static int sec_ahash_import(struct ahash_request *req, const void *in)
> +{
> +	/*
> +	 * Import partial state of the transformation. This function loads the
> +	 * entire state of the ongoing transformation from a provided block of
> +	 * data so the transformation can continue from this point onward.
> +	 */
> +	struct crypto_ahash *tfm = crypto_ahash_reqtfm(req);
> +	struct sec_req *sreq = ahash_request_ctx(req);
> +	struct sec_ctx *ctx = crypto_ahash_ctx(tfm);
> +	const struct sec_ahash_req *state = in;
> +
> +	sreq->ctx = ctx;
> +	memcpy(&sreq->hash_req, state, sizeof(struct sec_ahash_req));
> +
> +	return 0;
> +}

It's still not clear how this function actually works.

Could you please explain how can this work in the following scenario?

	x = export_state

	reboot_machine

	import_state(x)

How do you restore all the internal state so that further data
can be hashed onto the existing hash state after a reboot?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt