Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 04 Oct 2021 11:07:57 +0100
Message-ID: <878rz9rtky.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Sam Shih <sam.shih@mediatek.com>
Cc:     <matthias.bgg@gmail.com>, <Ryder.Lee@mediatek.com>,
        <devicetree@vger.kernel.org>, <enric.balletbo@collabora.com>,
        <fparent@baylibre.com>, <gregkh@linuxfoundation.org>,
        <herbert@gondor.apana.org.au>, <hsinyi@chromium.org>,
        <john@phrozen.org>, <linus.walleij@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-clk@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>,
        <linux-serial@vger.kernel.org>, <linux-watchdog@vger.kernel.org>,
        <linux@roeck-us.net>, <mpm@selenic.com>, <mturquette@baylibre.com>,
        <robh+dt@kernel.org>, <sboyd@kernel.org>, <sean.wang@kernel.org>,
        <seiya.wang@mediatek.com>, <wim@linux-watchdog.org>
Subject: Re: [v4,8/9] arm64: dts: mediatek: add mt7986a support
In-Reply-To: <20211004091208.31335-1-sam.shih@mediatek.com>
References: <0459da08cddc579f069a28e659e614fd@kernel.org>
        <20211004091208.31335-1-sam.shih@mediatek.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 04 Oct 2021 10:12:08 +0100,
Sam Shih <sam.shih@mediatek.com> wrote:
> 
> +		gic: interrupt-controller@c000000 {
> +			compatible = "arm,gic-v3";
> +			#interrupt-cells = <3>;
> +			interrupt-parent = <&gic>;
> +			interrupt-controller;
> +			reg = <0 0x0c000000 0 0x40000>,  /* GICD */
> +			      <0 0x0c080000 0 0x80000>,  /* GICR */
> +			      <0 0x0c400000 0 0x2000>,   /* GICC */
> +			      <0 0x0c410000 0 0x1000>,   /* GICH */
> +			      <0 0x0c420000 0 0x2000>;   /* GICV */
> +			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> +		};

Also, the GICD region is totally wrong. It is 64kB at all times. I
don't know where you get this 256kB figure from.

	M.

-- 
Without deviation from the norm, progress is not possible.