Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp2310779pxb; Fri, 8 Oct 2021 05:26:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeCkgpPpqSQgX7GI7Ky3QTptSgArvWHapiIRwSIJ0Rp+/Dzbiz5phvwtQRiXc5KWo8ylR4 X-Received: by 2002:a17:906:f184:: with SMTP id gs4mr3943536ejb.116.1633695994776; Fri, 08 Oct 2021 05:26:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633695994; cv=none; d=google.com; s=arc-20160816; b=09cCYCTFXiH/rNpyIFr7/uli07QJgkNOCD5hwpiRbWYFBEhqCl9/tIv3Am6SbkmTJe 925g4/3FGa1+TaN3QLov68LsRKL/T+7bdKq+YgIWG8pzDrrNFrR2lnbLroByk5qLM+Zg dt43TRD2d1V9e/iFhRC48kcC6KUwgacEUz7hXZvUfjt2vOnOd5zcbgL7XIWK8/Y3PdHX DHUyD0S/fgIlGrxlo6B6SLd4g2OdPTjzpEukZjW08O4PsStdEEowxwaSrsHBD5wrcS3v CzCbV6YYOSNgIgRMUq92DBB1RJU356QKcecuy8TLyto4IfADafRTz9EFPZAW+yakh49m fzbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=XgCAhMA/vSla2tAhUnvA/PTam8WIsBiEXuA8oSNzFAM=; b=hcKBi2s8LRyXcBNRaX741zlT4UfIQ7k0Y+swBZCX5FpuvKKLV1+/6Oq5xy9emV7cBJ GfJPFiP35dNkHlvxl0xDbMxujbSw2/he05SkIOf0kEtrCFyf2ESNWI6td64Wg1abUeQo U7Un/T3Ep5XTCH11dqU+Ih7phElYGUubLHRuDpp/QeCOJu4GXVdHJMWX55korifZ0AGB Pp6k2GDGjWR6YUEuTmDy7pKlHYO8Gthr+QVhOugrrQRXYP9vEZlDH0JJET8xt34m2bZp WV4KVhG/MXWpNXst+67OEVylZMkHiwmM92+JfKrjJu27lChtaxTAM03nVjaEJ/f9qNJj JeeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qb4si4861631ejc.749.2021.10.08.05.26.10; Fri, 08 Oct 2021 05:26:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241336AbhJHMZ4 (ORCPT + 99 others); Fri, 8 Oct 2021 08:25:56 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:55916 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230187AbhJHMZz (ORCPT ); Fri, 8 Oct 2021 08:25:55 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1mYout-0003bN-Ho; Fri, 08 Oct 2021 20:23:59 +0800 Received: from herbert by gondobar with local (Exim 4.92) (envelope-from ) id 1mYouj-000868-Jl; Fri, 08 Oct 2021 20:23:49 +0800 Date: Fri, 8 Oct 2021 20:23:49 +0800 From: Herbert Xu To: Giovanni Cabiddu Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com Subject: Re: [PATCH 00/12] crypto: qat - PFVF fixes and refactoring Message-ID: <20211008122349.GC31060@gondor.apana.org.au> References: <20210928114440.355368-1-giovanni.cabiddu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210928114440.355368-1-giovanni.cabiddu@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Sep 28, 2021 at 12:44:28PM +0100, Giovanni Cabiddu wrote: > This set includes few fixes and refactors in the QAT driver, mainly > related to the PFVF communication mechanism. > > Here is a summary of the changes: > * Patches #1 and #2 fix a bug in the PFVF protocol related to collision > detection; > * Patch #3 optimizes the PFVF protocol protocol by removing an unnecessary > timeout; > * Patch #4 makes the VF to PF interrupt related logic device specific; > * Patches #5 and #6 remove duplicated logic across devices and homegrown > logic; > * Patches #7 to #12 are just refactoring of the PFVF code in preparation > for updates to the protocol. > > Giovanni Cabiddu (3): > crypto: qat - detect PFVF collision after ACK > crypto: qat - disregard spurious PFVF interrupts > crypto: qat - use hweight for bit counting > > Marco Chiappero (9): > crypto: qat - remove unnecessary collision prevention step in PFVF > crypto: qat - fix handling of VF to PF interrupts > crypto: qat - remove duplicated logic across GEN2 drivers > crypto: qat - make pfvf send message direction agnostic > crypto: qat - move pfvf collision detection values > crypto: qat - rename pfvf collision constants > crypto: qat - add VF and PF wrappers to common send function > crypto: qat - extract send and wait from adf_vf2pf_request_version() > crypto: qat - share adf_enable_pf2vf_comms() from adf_pf2vf_msg.c > > .../crypto/qat/qat_4xxx/adf_4xxx_hw_data.c | 4 +- > .../crypto/qat/qat_c3xxx/adf_c3xxx_hw_data.c | 89 +------ > .../crypto/qat/qat_c3xxx/adf_c3xxx_hw_data.h | 13 +- > .../crypto/qat/qat_c62x/adf_c62x_hw_data.c | 87 +------ > .../crypto/qat/qat_c62x/adf_c62x_hw_data.h | 12 - > .../crypto/qat/qat_common/adf_accel_devices.h | 5 + > .../crypto/qat/qat_common/adf_common_drv.h | 9 +- > .../crypto/qat/qat_common/adf_gen2_hw_data.c | 98 ++++++++ > .../crypto/qat/qat_common/adf_gen2_hw_data.h | 27 ++ > drivers/crypto/qat/qat_common/adf_isr.c | 20 +- > drivers/crypto/qat/qat_common/adf_pf2vf_msg.c | 238 ++++++++++-------- > drivers/crypto/qat/qat_common/adf_pf2vf_msg.h | 9 - > drivers/crypto/qat/qat_common/adf_vf2pf_msg.c | 4 +- > drivers/crypto/qat/qat_common/adf_vf_isr.c | 6 + > .../qat/qat_dh895xcc/adf_dh895xcc_hw_data.c | 123 ++++----- > .../qat/qat_dh895xcc/adf_dh895xcc_hw_data.h | 14 +- > 16 files changed, 361 insertions(+), 397 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt