Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Cc:     brijesh.singh@amd.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        linux-crypto@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Borislav Petkov <bp@alien8.de>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>, tony.luck@intel.com,
        marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH Part2 v5 39/45] KVM: SVM: Introduce ops for the post gfn
 map and unmap
To:     Sean Christopherson <seanjc@google.com>
References: <20210820155918.7518-1-brijesh.singh@amd.com>
 <20210820155918.7518-40-brijesh.singh@amd.com> <YWYm/Gw8PbaAKBF0@google.com>
 <94128da2-c9f7-d990-2508-5a56f6cf16e7@amd.com> <YWc9KL8gghEiI48h@google.com>
 <a7a541ba-129a-1083-3517-c30e9f9cd7c7@amd.com> <YWdZUrpn5/JCz39R@google.com>
From:   Brijesh Singh <brijesh.singh@amd.com>
Message-ID: <9ffed063-4322-2213-0f0b-d899eae32ddd@amd.com>
Date:   Wed, 13 Oct 2021 17:31:24 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <YWdZUrpn5/JCz39R@google.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akJnTkNZZWtmUWswQVV4RnNDRkJxZVZNZUZtdkdBTnpXUW5VbC9PSDh3UXZn?=
 =?utf-8?B?OXBZRmg2cEJHeVVKTEJuYWQ1R0VPTXphakFKUTI0RkxYNjQyNEpWd0JGajhO?=
 =?utf-8?B?Tk9PcjVoU1dOZmdrdElGdXlZTjZSOGpBd3hidmJzZXFqSjRnc0ZsK3JvdVVl?=
 =?utf-8?B?SHFhelVVeEw1UjBUY0hjdVZ2aHFTQXN5K2g1SjlQSkg1Zy9HRDJOWTVrRDVH?=
 =?utf-8?B?TUVGUnh0NGNsZG9jSGdsRlg1Q3BHcEpVRzJSQWxnV203RFlEYXYxdmt3TDUz?=
 =?utf-8?B?My82cUpIMnJpQ0JNbXpMRGRBbDRHYXBPQ3dvZXllM3FnT1pxcDRJRGgza3Ji?=
 =?utf-8?B?R1BINUxEVVBROS9laFdEZnZ1MVN1Y05CVWlQcGhiVGNUd0tjZ0Y1d3Fwakpo?=
 =?utf-8?B?S013WE5LajUyODRXd3dwcGVQMDhjRkN1OEdRbkJ6MGlld1o2cHBsbkoyN0Q2?=
 =?utf-8?B?VHVvWVhYOVVqUTJIUUU1KzJXdGRSc3JST3Rra0k0b0xQdWNTc0pXcnY0ZU51?=
 =?utf-8?B?NWVKWmgvTXJUanEyOU5QL0UzNjc2SEcvelRhVlFreXRRdUlCbnVSbTZqNzVX?=
 =?utf-8?B?dTJjWmFSLzhDS2VaYzZ4N2tvMW9reFg4ZmFhOXYvMDlHM1pUU0pmUjhXWjJ4?=
 =?utf-8?B?YWdFMk5Zd3VzWjNOSzgzM2RFbWxSSmNNM2VKelN4STdObG5uVU5WU2R1clJo?=
 =?utf-8?B?Z0xmV1dUaGdiZ1JCT1RiZ2ZpMS9GWVpnWUlVKzNaSk9PeTg2R2hJUUVxRjFT?=
 =?utf-8?B?ZCtjNngyZFcrVGlwY0JmNWZrek9uN2UwWmFlU0NvS2FwcHdDZDFGeUx5RXk5?=
 =?utf-8?B?VVNCK3lDeHQ2WWVsM1czWFhZdDIyVlg4ejdJYnRyUWhuRVlEc1c1ZnE4VDhu?=
 =?utf-8?B?ZmF4aWZVelFyckxjMnlKV043ajMxSEFTZWc2MmY2OE9MRGVWRXRSMnZZVzJS?=
 =?utf-8?B?Y2U1NFlEdWtRaTA0VURJUWFIMWxsNmNhc2FPU0Y5SHlGTjE5cEpucFN4Tlh3?=
 =?utf-8?B?ZWNYV2R1WE1iMUFYclZHSFJYV2RNNGtsRnBvbVZ4czJQOEFkTnk1ZFR5ZklC?=
 =?utf-8?B?Z2cvOHZRZFJHOFhBbWtoYXNXY2lqVmg5dUNYZFFIekx3eXplZVVDS293Y0Z0?=
 =?utf-8?B?K2FnT1ZQbHVBeUJ2bDdPNXNPZUpycWtEdmZSb0F6NFVFbkNzcGZmZTN3VHJi?=
 =?utf-8?B?VVJGVlFKcWlvUm5wd1ZKYTFRa09Id05SZk82d3UvNGE0amJVSDZDWXE4MHBD?=
 =?utf-8?B?bWVtMFJXQ2hlTDhZNXBLM0hiNmdYTDFIQ3FGODllOXVxK081MFd6R1pEemRP?=
 =?utf-8?B?YUNmMFlDZ0kyU3YxWXNnVXhlQm5USXVPenBQMG91NVRMckozdURXWUkyOGhw?=
 =?utf-8?B?QUM4UC8zVEgzQkxibTREd2JKZlZOdzkwb2hOeHJoUElTOW4vNUNCQW8zL0pZ?=
 =?utf-8?B?aGlxcklpWFcwaEZPOElhTXFmVGV1K09GeFpkeW1PV1dONngyMmVsQ0Y4NkZR?=
 =?utf-8?B?ZmRkZDVNQzVqR0hOeWhzMm1xYS9jRnNsSGExL1RUUUVkVTFWa2FTVFZaSmwr?=
 =?utf-8?B?ZCsweWMvaEQ4QkJiN0JDSGtWRkd3dTk0bW11Y2ZYSjJmK0NjVzUyRmliOVhP?=
 =?utf-8?B?aEdDalJkUlFXNkYrZURTcjF0SmRMa3VkYkkwa2VicXN6UUxQNkRwa2Y4YlU1?=
 =?utf-8?B?V2t0ZVNCRkF5K1VrVXFVTms1ejdoMm5aNkxCV29Scm1tM011S3dZZ25LcWZE?=
 =?utf-8?Q?DpjEvIHGvdJm6ffy+iyjIFck03jXbYCdICjClm6?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3dc6bda-14d8-465b-19dc-08d98e99324e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 22:31:27.6894
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RBNoo7e30gRQaCOP1y3pgvmrxBj7wXYQ2LNHX9VvOR0KzGQgyHtNNDK7bPYQFjrCX1yNBNZqsnHonkA2SQAcQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2720
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 10/13/21 3:10 PM, Sean Christopherson wrote:
> On Wed, Oct 13, 2021, Brijesh Singh wrote:
>> On 10/13/21 1:10 PM, Sean Christopherson wrote:
>>> Side topic, what do you think about s/assigned/private for the "public" APIs, as
>>> suggested/implied above?  I actually like the terminology when talking specifically
>>> about the RMP, but it doesn't fit the abstractions that tend to be used when talking
>>> about these things in other contexts, e.g. in KVM.
>> I can float the idea to see if docs folks is okay with the changes but
>> generally speaking we all have been referring the assigned == private in
>> the Linux SNP support patch.
> Oh, I wasn't suggesting anything remotely close to an "official" change, it was
> purely a suggestion for the host-side patches.  It might even be unique to this
> one helper.

Ah, sure I am good with calling a private in the helper.

-Brijesh