Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Meng Li <Meng.Li@windriver.com>
To:     horia.geanta@nxp.com, pankaj.gupta@nxp.com,
        herbert@gondor.apana.org.au, davem@davemloft.net
Cc:     linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        meng.li@windriver.com
Subject: [PATCH] driver: crypto: caam: instead this_cpu_ptr with raw_cpu_ptr
Date:   Tue, 19 Oct 2021 14:37:19 +0800
Message-Id: <20211019063719.18251-1-Meng.Li@windriver.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oqG+BaL0vM3OqyU3Am3B12ey33tSXQCKjs/vhw/tCDIXyRVAfFO70ZmWXVi0?=
 =?us-ascii?Q?N1IWf8SlfudVwok6l39OqLG5AsZKqxWneEgZ4UN/Q4FNOWL8laRr7/WGTbbn?=
 =?us-ascii?Q?2mPy3qnYd2AZo1+hZLbYTnG5Xe8pT3F3Z9rYQaAH/exIjxAnVq1HPMk9nr6H?=
 =?us-ascii?Q?QsX0L3xOqbuy7ZtKQMTDOomd1E3eTR+Op9R7/Ox915seqhKUk+mLeH9sFm9Q?=
 =?us-ascii?Q?8CCZYpAULLGlLqutpwaoC8jlfJ7ImLHPjjRLfs4ip1cnRr8cDsJvLZb5PO4Y?=
 =?us-ascii?Q?rKxDXHadL11ivbdN1nPNA9hDUkb+mpvN0HbwvjweAEIovoSlC+sgggAMF6VI?=
 =?us-ascii?Q?teCUL/gUVpU/ed4pW2GLtoC0bYzvQwrv0mnFINgZ2DzsbmHRanwoVyRHfqQG?=
 =?us-ascii?Q?cT78Cq8zTfBFR2Dl1TMo/rd+BR+mqyIDdwZUUbXHK7GqGB9ZoYnnPj01vKC5?=
 =?us-ascii?Q?m6VvCbT4HJS7qCcoJQc1ukKZgEtv/G7yUSPvMdg9jNS5bte7FSofY3ntMV6N?=
 =?us-ascii?Q?7B2PEfztFn+xWQQ2P5gmg1D9u6wjjnKF87TVWK/wYmcSb95I4jiTmFIjnvm5?=
 =?us-ascii?Q?z60nwjcX5JDJCptdJeIaFSf2roMoJ4hTZmcXmnJUdyIJQjyCsrvumclfqh6m?=
 =?us-ascii?Q?12ZvJkWNERDsds7V9tiLAp9eVdt06G6r1Zf5ufih3/3K/uJVt1mlm5EKpwvT?=
 =?us-ascii?Q?+w/hR8IScgs9vac3Yvd8xOTGVVR6+gyZJvAW7m9L3+fcK3+ng2pafvPJCjzS?=
 =?us-ascii?Q?gxyYJwFHtN4D+EdA3ejbNUFWrS6TMLr4awfoyrqOW5bdqCVDMGDsJYQm4wsz?=
 =?us-ascii?Q?RNYBfTbxGutVeSVDv5m+j1JW7Fh4gF4kCyM/xwuYea5Y66ZVVmRoj5ejvdQi?=
 =?us-ascii?Q?a4py7npCuNKuplkFW2Rlt6w2Ufpxt+HtK3cpcHDrE6QzLcBCwaZIXFMrI5zi?=
 =?us-ascii?Q?+ZeVR6x9Cnv801VOf+7c2w8yP77VaxzereyMPVAJ/vXLg7do6CHtwU75mUm3?=
 =?us-ascii?Q?tMzG+U3OzwOkZ89dBUSGTQWCIcxg8cvLL3Sbkg6xtGDs2Sskk747OLlg6fZN?=
 =?us-ascii?Q?JmrsPO1Tr8NY46g6ymwVl5HVmQEP5r5smibe80KNhkP3nIVvFOaPlT7iKOay?=
 =?us-ascii?Q?7aqtyQl8Do+gXizrA5X0PebXjWXl13Rz8rAIg61wPhkoiBlxa14e4Qep2koJ?=
 =?us-ascii?Q?cd9GhJKJQQVN+YBr6TQwvrpjvhYbeVlkYWMp33M8zbwDLCVmvtnCUQYvmbK7?=
 =?us-ascii?Q?5xHBjajuervM13ZNyVFTv+TKpyUYyXuHzF3/gEpraT+xZrJZ1+o/J9FnlMyC?=
 =?us-ascii?Q?ijngTcEUt9+kA4Ry2goX26gw?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eaa3969b-2e9c-4180-b29b-08d992caf069
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5191.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 06:37:36.6563
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1TMFmwPvpdjg+r6fJEVY117VpB7cZC/LeFMTSTMmiSWEOyhJM4pX5GVYdnucjis/5bmwYYPgovCLfKCbbGzzEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4806
X-Proofpoint-GUID: lgCR1bBHLDLEe1R_ijJNc6IBFJ5emIoD
X-Proofpoint-ORIG-GUID: lgCR1bBHLDLEe1R_ijJNc6IBFJ5emIoD
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-18_07,2021-10-18_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0
 phishscore=0 spamscore=0 mlxscore=0 priorityscore=1501 clxscore=1011
 impostorscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110190039
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

When enable the kernel debug config, there is below calltrace detected:
BUG: using smp_processor_id() in preemptible [00000000] code: cryptomgr_test/339
caller is debug_smp_processor_id+0x20/0x30
CPU: 9 PID: 339 Comm: cryptomgr_test Not tainted 5.10.63-yocto-standard #1
Hardware name: NXP Layerscape LX2160ARDB (DT)
Call trace:
 dump_backtrace+0x0/0x1a0
 show_stack+0x24/0x30
 dump_stack+0xf0/0x13c
 check_preemption_disabled+0x100/0x110
 debug_smp_processor_id+0x20/0x30
 dpaa2_caam_enqueue+0x10c/0x25c
 ......
 cryptomgr_test+0x38/0x60
 kthread+0x158/0x164
 ret_from_fork+0x10/0x38
According to the comment in commit ac5d15b4519f("crypto: caam/qi2
 - use affine DPIOs "), it doesn't matter whether preemption is
disable or not. So, only instead this_cpu_ptr with raw_cpu_ptr to
avoid above call trace.

Fixes: ac5d15b4519f ("crypto: caam/qi2 - use affine DPIOs")
Cc: stable@vger.kernel.org
Signed-off-by: Meng Li <Meng.Li@windriver.com>
---
 drivers/crypto/caam/caamalg_qi2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/caam/caamalg_qi2.c b/drivers/crypto/caam/caamalg_qi2.c
index 86fc349abc59..39db403ba8b4 100644
--- a/drivers/crypto/caam/caamalg_qi2.c
+++ b/drivers/crypto/caam/caamalg_qi2.c
@@ -5766,7 +5766,7 @@ int dpaa2_caam_enqueue(struct device *dev, struct caam_request *req)
 	dpaa2_fd_set_len(&fd, dpaa2_fl_get_len(&req->fd_flt[1]));
 	dpaa2_fd_set_flc(&fd, req->flc_dma);
 
-	ppriv = this_cpu_ptr(priv->ppriv);
+	ppriv = raw_cpu_ptr(priv->ppriv);
 	for (i = 0; i < (priv->dpseci_attr.num_tx_queues << 1); i++) {
 		err = dpaa2_io_service_enqueue_fq(ppriv->dpio, ppriv->req_fqid,
 						  &fd);
-- 
2.17.1