Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1335784pxb; Wed, 20 Oct 2021 03:04:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtchyh//ZiiVZpwnORUGMYp+Pp5pwtgoHdzu48U8hMJ9Aok7dD8oPN0otFtkC29B5ePH7g X-Received: by 2002:a17:90b:1c02:: with SMTP id oc2mr6195965pjb.128.1634724290146; Wed, 20 Oct 2021 03:04:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634724290; cv=none; d=google.com; s=arc-20160816; b=nAfT7yDwEr84O9zg0ok/225zJUwiJHOXkM5wM9pI9MOTylkJup04vAXGWGDFRRAR8N dfnJO+QhByh56ekIyEm96htMqDRoF+3ldf+9kHcnAccEs3U5+1NVvjsDpBO3sua7gnu0 r5JGe5cSNtnMXDBytxSR1utnx+15G58KgphFGCmcqNRdS2CWGj7/2ZeJdh/kT1nQhtb2 OFeonp6xDfWoGFEM2bUdOd8nxx61eVrIhTD1FgG1lsXPq+OOFP6TeHoc83IzIHdumDeQ 4+JWHW8ghYJlE91SRnsKYPPa7nLAMq8Y6FicRHx6yQGb6JwtALR5YVQyhBtiyoJ0IgFs Z63w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=l8+NKGRrTVBMs2HpGGp0Mk7gLKMHl+v3PYEiRQZ06tM=; b=Z3DSqQhCArfF6KVCXrxjPduZANKgRtqSV/raj0gRCW1ypuzww4rss1ajbxjCChWBkO NSqOx/sgav7YVqAwR5tSzRLUTnPgyqPC2rl5QQD+eiAkV/RQq5Quv3pXoEFVR4pCterj LezUX1nCJPyKq6EqpSxdx5Bzf3rwZf9BF9DuupIk0NN98WP825y7d3kzOuD1uZaOFOQ0 3rLzNE7Z6sLJUxWsDyVxFfn+Ng7pBKEWDpryhveICvLwTlVAe0/fGH/7t2qdxwuoORxZ tit9NelktSZ6zVIvpe5wVkMGDpgC3Udwsmow/KuQg+zKL3mUE6+QHjjrfuAIwOiYHlLk Za9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u15si2297345pgk.512.2021.10.20.03.04.12; Wed, 20 Oct 2021 03:04:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230103AbhJTKGR (ORCPT + 99 others); Wed, 20 Oct 2021 06:06:17 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:62584 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbhJTKGL (ORCPT ); Wed, 20 Oct 2021 06:06:11 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.7]) by rmmx-syy-dmz-app03-12003 (RichMail) with SMTP id 2ee3616fe975509-08a42; Wed, 20 Oct 2021 18:03:34 +0800 (CST) X-RM-TRANSID: 2ee3616fe975509-08a42 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.112.105.130]) by rmsmtp-syy-appsvr04-12004 (RichMail) with SMTP id 2ee4616fe97249c-189fd; Wed, 20 Oct 2021 18:03:34 +0800 (CST) X-RM-TRANSID: 2ee4616fe97249c-189fd From: Tang Bin To: krzysztof.kozlowski@canonical.com, vz@mleia.com, herbert@gondor.apana.org.au, davem@davemloft.net Cc: linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Bin Subject: [PATCH] crypto: s5p-sss - Add error handling in s5p_aes_probe() Date: Wed, 20 Oct 2021 18:03:48 +0800 Message-Id: <20211020100348.42896-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The function s5p_aes_probe() does not perform sufficient error checking after executing platform_get_resource(), thus fix it. Signed-off-by: Tang Bin --- drivers/crypto/s5p-sss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index 55aa3a711..7717e9e59 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -2171,6 +2171,8 @@ static int s5p_aes_probe(struct platform_device *pdev) variant = find_s5p_sss_version(pdev); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; /* * Note: HASH and PRNG uses the same registers in secss, avoid -- 2.20.1.windows.1