Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1383776pxb; Wed, 20 Oct 2021 04:07:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTNn7avwdpGhbDNwnzr/VVD8FOdCL9NGhFX9Q4G/XqVQZ285njt8l3VkSKO/+gbhzUcoUL X-Received: by 2002:a17:906:5e52:: with SMTP id b18mr47176452eju.560.1634728025694; Wed, 20 Oct 2021 04:07:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634728025; cv=none; d=google.com; s=arc-20160816; b=OlXN26NTZoX8yz4bE88BsLfdMcpleBpK8PiWsvcJX5k1jJdmagh8/j+xspFUv+gBmu MplR9jNQrCEL998NLZlGFqZhyYyc+ZhXoK4IQzXb0dr6DsYITbB8OqGAPNH38qjEqAaJ cCoVeqrs0rrCyBYF6MoopU6hDDJ5mTuzm3Xb541tkrHrvnuh4azpgrNarLi2FILyydJV 2o4rQKlyTo06q73Qxj56FWL7o8PJbESuH8p4KXjir8ZMf7HbF6SXAGjITYUG8PtrdyQ/ WGYPkou+rmRvqhvXQRYSMliJ26J46EpLP4Er9cpKf7e5a21n+7AaC0hznJrIbYadoxzC 7SVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=fcYFo1aY7VrPOr/tAGJeE3PCOqwNphXZc56E17rv5H0=; b=f84UBS9Y9kL7nZ2KOwHDQ/3gmOpHhqNN22u2v5orOlhz9iB0UYVcVfEprEt18f1M2T /+CndgwgDS2slel9oYx93f3vwCUBPXeFgUzaWVyHLxpMtLg9k4tUcb/nZlgug9q5kegz YCG7z1AR0wZYUezAN/3/BjOceqFUwI7cZ9wqy1xV7ZG10reDcc52qwPZGVItnh/JpHDF 0Zplu+0YRnsPd30XI+fSQ04WsoaL4ktBEo6IsFHUlU86opyWzowsD2shae6VHKCeH09j g9vTti0o2e45kjb/F9LkEOhZW8coAvL8CDzyCbdvc/ufkDUj45UhmLjOaqGOOjDkbw0P Laiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g23si2450662ejw.249.2021.10.20.04.06.29; Wed, 20 Oct 2021 04:07:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230106AbhJTLIj (ORCPT + 99 others); Wed, 20 Oct 2021 07:08:39 -0400 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:25964 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230105AbhJTLIi (ORCPT ); Wed, 20 Oct 2021 07:08:38 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.9]) by rmmx-syy-dmz-app08-12008 (RichMail) with SMTP id 2ee8616ff822b7d-09242; Wed, 20 Oct 2021 19:06:10 +0800 (CST) X-RM-TRANSID: 2ee8616ff822b7d-09242 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.112.105.130]) by rmsmtp-syy-appsvr05-12005 (RichMail) with SMTP id 2ee5616ff81f86e-1d843; Wed, 20 Oct 2021 19:06:10 +0800 (CST) X-RM-TRANSID: 2ee5616ff81f86e-1d843 From: Tang Bin To: krzysztof.kozlowski@canonical.com, vz@mleia.com, herbert@gondor.apana.org.au, davem@davemloft.net Cc: linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tang Bin Subject: [PATCH v2] crypto: s5p-sss - Add error handling in s5p_aes_probe() Date: Wed, 20 Oct 2021 19:06:24 +0800 Message-Id: <20211020110624.47696-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The function s5p_aes_probe() does not perform sufficient error checking after executing platform_get_resource(), thus fix it. Fixes: c2afad6c6105 ("crypto: s5p-sss - Add HASH support for Exynos") Signed-off-by: Tang Bin Reviewed-by: Krzysztof Kozlowski --- Changes from v1 - add fixed title --- drivers/crypto/s5p-sss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index 55aa3a711..7717e9e59 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -2171,6 +2171,8 @@ static int s5p_aes_probe(struct platform_device *pdev) variant = find_s5p_sss_version(pdev); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; /* * Note: HASH and PRNG uses the same registers in secss, avoid -- 2.20.1.windows.1