Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211026075626.61975-1-tianjia.zhang@linux.alibaba.com>
In-Reply-To: <20211026075626.61975-1-tianjia.zhang@linux.alibaba.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Tue, 26 Oct 2021 18:08:10 +0200
Message-ID: <CAMj1kXGiC-LCc-50cfddJxJ-mezO=fcLqhJHiK110CgxKusy9w@mail.gmail.com>
Subject: Re: [PATCH v3 0/2] use SM3 instead of SM3_256
To:     Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc:     James Bottomley <jejb@linux.ibm.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        Mimi Zohar <zohar@linux.ibm.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Peter Huewe <peterhuewe@gmx.de>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        David Howells <dhowells@redhat.com>,
        James Morris <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Jerry Snitselaar <jsnitsel@redhat.com>,
        linux-integrity <linux-integrity@vger.kernel.org>,
        keyrings@vger.kernel.org,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        linux-security-module@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 26 Oct 2021 at 09:56, Tianjia Zhang
<tianjia.zhang@linux.alibaba.com> wrote:
>
> According to https://tools.ietf.org/id/draft-oscca-cfrg-sm3-01.html,
> SM3 always produces a 256-bit hash value and there are no plans for
> other length development, so there is no ambiguity in the name of sm3.
>

What is the point of these changes? Having '256' in the identifiers is
merely redundant and not factually incorrect, so why can't we just
leave these as they are?


> ---
> v3 changes:
>  - The fix of document trusted-encrypted.rst is put in patch 2
>
> v2 changes:
>  - an additional macro with the same value is defined for uapi instead
>    of renaming directly
>
> Tianjia Zhang (2):
>   crypto: use SM3 instead of SM3_256
>   tpm: use SM3 instead of SM3_256
>
>  Documentation/security/keys/trusted-encrypted.rst | 2 +-
>  crypto/hash_info.c                                | 4 ++--
>  drivers/char/tpm/tpm-sysfs.c                      | 4 ++--
>  drivers/char/tpm/tpm2-cmd.c                       | 2 +-
>  include/crypto/hash_info.h                        | 2 +-
>  include/linux/tpm.h                               | 2 +-
>  include/uapi/linux/hash_info.h                    | 3 ++-
>  security/keys/trusted-keys/trusted_tpm2.c         | 2 +-
>  8 files changed, 11 insertions(+), 10 deletions(-)
>
> --
> 2.19.1.3.ge56e4f7
>