Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp126406pxb; Fri, 29 Oct 2021 07:02:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfqme5sdQSNsaOMhKvk288/WDVedvOFkxJFH9SRYuRgl6z5XUQwl21vCny6vNTzd5bA0UW X-Received: by 2002:a92:c262:: with SMTP id h2mr7901706ild.66.1635516124391; Fri, 29 Oct 2021 07:02:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635516124; cv=none; d=google.com; s=arc-20160816; b=xLYJqKZC901V0goJ3uDeuGrfd+Q3kiZqyEUCxOhUeXmulqaVKVQN1hZ7+09ZV+NMwX dNnaILd3WeCNZqoVDE6eI64BDhu57bUscLosK6XzdabGAY8eJ1UfUYQgez8fEf++1VNl drPLHvU347aRIZrgrqk89ZjNrFE6N5PmYUwu0hmk/GB8XlOtsKFG78HM+1JKZVlbwK6R 0h1s6lvhzuisO7Ez8AsqKkdlm10PP2XN6lQ0THThdvALQe4gOtcFUZYo27r2ZFm09Tug q6Q3dOE++Cx7DKmxnNcFC18TNFU6Od+WyZQhi1IyxiyggNowquI+jEMuwITNQN2wRXTZ IFHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=jsaels+ddUZtfsywBFS4CqwXVBDosXtO8sG+jb6tKR0=; b=DzgNeihUcrnZ/zmsGD6QdJs+OeOsVJgsBR44onhNeAkJ72SJiaB0906nzK+iBj+xa/ TtmrJk4+bP3ONK6HMF9e/rmKLnkG2dTAsQoqSLIrxAVvZx5d2rmniuWhNxRXtqiaP2cU Xk6nEBWVo7pUqW3u2JpV7hLQDkWmxsNCWnwfOgq4zvo9iHGOm+HhOEpHF/rFAax+aQgV H7uT/os/QB+oUCY5CyFmOafpiw2RjJctCW5O8lU//Zkc1GkECAjN44vB/f/nvpIEu9Xf ozQeBDN7LfSu4gRlhpwMGcfxLzTZ4va8n6SQHlyCNcIU+c8yU6E0bQWv8vsEzOB51MlP Kn2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=DhzfQ8C8; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id az9si7488353jab.107.2021.10.29.07.01.47; Fri, 29 Oct 2021 07:02:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=DhzfQ8C8; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231654AbhJ2OEM (ORCPT + 99 others); Fri, 29 Oct 2021 10:04:12 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:49642 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231418AbhJ2OEB (ORCPT ); Fri, 29 Oct 2021 10:04:01 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19TDDN3T001431; Fri, 29 Oct 2021 15:56:49 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=selector1; bh=jsaels+ddUZtfsywBFS4CqwXVBDosXtO8sG+jb6tKR0=; b=DhzfQ8C84cc0Ebr4BjC4FRbOFcGMP1A2zFMsxWgdX0Hrcvvz8+74UUAGR8dqvIDPEjuh ADz8+83ta89pdPNyTTuowAa9kjPjDFjrRPM1cVnEwUx20VGNeBtKMO+FClT2ooiuh9UT FtAs0+uJhPrmbDub2FFHs++wvSWZT1kihDnOf3G1v+xjUKyuoPLiRbG6hq+LUYAusZYg K8mumx4TVUOI+c2z6J7igLUWR6wJ2mKedY3VE6BEf1tjoCyydNeKc3epnrHGAr4BAbFv KPg02iyBbdzolF7Yt5bNV0yoNZ2eQWpT6Hyfa2DSjGh/+7l8nfk5dr/oHzP35k57bbBn xg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3c07xgkpa1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Oct 2021 15:56:49 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id F0732100034; Fri, 29 Oct 2021 15:56:48 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id E751124C742; Fri, 29 Oct 2021 15:56:48 +0200 (CEST) Received: from localhost (10.75.127.50) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 29 Oct 2021 15:56:48 +0200 From: Nicolas Toromanoff To: Herbert Xu , "David S . Miller" , Maxime Coquelin , Alexandre Torgue CC: Marek Vasut , Nicolas Toromanoff , , , , Subject: [PATCH 4/8] crypto: stm32/cryp - fix race condition Date: Fri, 29 Oct 2021 15:54:50 +0200 Message-ID: <20211029135454.4383-5-nicolas.toromanoff@foss.st.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211029135454.4383-1-nicolas.toromanoff@foss.st.com> References: <20211029135454.4383-1-nicolas.toromanoff@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG1NODE2.st.com (10.75.127.2) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-29_03,2021-10-29_01,2020-04-07_01 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Erase key before finalizing request. Fixes: 9e054ec21ef8 ("crypto: stm32 - Support for STM32 CRYP crypto module") Signed-off-by: Nicolas Toromanoff --- drivers/crypto/stm32/stm32-cryp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c index 6eeeca0d70ce..f97f9ee68d6f 100644 --- a/drivers/crypto/stm32/stm32-cryp.c +++ b/drivers/crypto/stm32/stm32-cryp.c @@ -666,6 +666,8 @@ static void stm32_cryp_finish_req(struct stm32_cryp *cryp, int err) free_pages((unsigned long)buf_out, pages); } + memset(cryp->ctx->key, 0, sizeof(cryp->ctx->key)); + pm_runtime_mark_last_busy(cryp->dev); pm_runtime_put_autosuspend(cryp->dev); @@ -674,8 +676,6 @@ static void stm32_cryp_finish_req(struct stm32_cryp *cryp, int err) else crypto_finalize_skcipher_request(cryp->engine, cryp->req, err); - - memset(cryp->ctx->key, 0, cryp->ctx->keylen); } static int stm32_cryp_cpu_start(struct stm32_cryp *cryp) -- 2.17.1