Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3040093pxb; Mon, 1 Nov 2021 06:49:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3vkFXwIKPFCxWVH6L4AKaBFFVcRZryrjN3poeWmRyVWds6E9EB5bcISFSExLPONxG5DCc X-Received: by 2002:a05:6e02:17c8:: with SMTP id z8mr2739484ilu.19.1635774577281; Mon, 01 Nov 2021 06:49:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635774577; cv=none; d=google.com; s=arc-20160816; b=Y7cFjY2zGpcu9RdjPcUCSh2FYBr/yw6ZkdZ8Ascil8LSxhNBq1ciwheM+KWfZ3EqSF VAvE+MwuRHjpQLYPW8fEfOHuv+gjRwtR0lG64TZw3r8+NipqXYYOSQxlRjKGUP3yAbKg eCtvgAiV4IuZa4YWSu1lBJez+PkavYtdc5hkZUPOkzWMYfKr1ZKy5/3DdlAirbPN7vxg 4Cgt2NnHTfqtl4EO8JOPhmCbC0llC66JfANXDxQ4m8hfjf9yiC5E08CjW6Ji2jFsM28f nQph6c/hWGrr4UG1wNLJ48WbnXulfS2dtILJ7CEsLgpoR01zZz043oVg2vSn2dew14gs lXPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Pj6j368Wt46E5mJbTEbouA16d6m/kQO1+HN090BYFv0=; b=neXw77DCm6wR5v6B8cj1/wpzVXHwi2B2H7voeCsFcbDTZDMMKbNpYEtsDbAben7yS7 nVhLo+z4F0r+DSHEBb/esf4XfgxZ+ct0FIKe9IriXA1lPeQAUorYqUeUdi+xZs+DHd4C HoCy2tVSfNdb0n0J/2rgLKFx3ag3796LZqg//pTmnu+1QEBvbwhGNeitxiTV1a3C8XiZ IOE0VtdIe0tGK6bTqShGDKr1QkGMSJKZ4WCduzUpV0Lq/hYHQ4aaWCiqE30YeQG9zE4L Or/Ek65Jwmup1SluqLKE/JBDPrn+Kw4N0Is3pw1HIljQvG/5ueRlM9ha/rG6PRtToize /Ahw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r16si6874901jac.50.2021.11.01.06.49.12; Mon, 01 Nov 2021 06:49:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232209AbhKANvm (ORCPT + 99 others); Mon, 1 Nov 2021 09:51:42 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:15328 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231493AbhKANva (ORCPT ); Mon, 1 Nov 2021 09:51:30 -0400 Received: from dggeml709-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4HjZBQ5M0kz90Nb; Mon, 1 Nov 2021 21:48:46 +0800 (CST) Received: from localhost.localdomain (10.175.102.38) by dggeml709-chm.china.huawei.com (10.3.17.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.15; Mon, 1 Nov 2021 21:48:53 +0800 From: Wei Yongjun To: , Daniele Alessandrelli , Prabhjot Khurana , Mark Gross , Herbert Xu , "David S. Miller" CC: , , Hulk Robot Subject: [PATCH -next] crypto: keembay-ocs-ecc - Fix error return code in kmb_ocs_ecc_probe() Date: Mon, 1 Nov 2021 14:02:33 +0000 Message-ID: <20211101140233.777222-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.102.38] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggeml709-chm.china.huawei.com (10.3.17.139) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fix to return negative error code -ENOMEM from the error handling case instead of 0, as done elsewhere in this function. Fixes: c9f608c38009 ("crypto: keembay-ocs-ecc - Add Keem Bay OCS ECC Driver") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/crypto/keembay/keembay-ocs-ecc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/keembay/keembay-ocs-ecc.c b/drivers/crypto/keembay/keembay-ocs-ecc.c index 679e6ae295e0..5d0785d3f1b5 100644 --- a/drivers/crypto/keembay/keembay-ocs-ecc.c +++ b/drivers/crypto/keembay/keembay-ocs-ecc.c @@ -930,6 +930,7 @@ static int kmb_ocs_ecc_probe(struct platform_device *pdev) ecc_dev->engine = crypto_engine_alloc_init(dev, 1); if (!ecc_dev->engine) { dev_err(dev, "Could not allocate crypto engine\n"); + rc = -ENOMEM; goto list_del; }