Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2338118pxb; Thu, 4 Nov 2021 18:54:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCUxvhqptxXhK9VnELjy5NfuVomRQ410qow/UlAPmAckwI7B3Yrr0rW0YRSuWSFqsKHlKk X-Received: by 2002:a17:906:961a:: with SMTP id s26mr13194176ejx.494.1636077266434; Thu, 04 Nov 2021 18:54:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636077266; cv=none; d=google.com; s=arc-20160816; b=canv9PbESJlPB5aqpx4oZG0YzZqOBiUK7Txb2qvV6h7h43ppQ15Buw5LENXJ2O39F6 4CmoEUScw4xq++N1cFR7n2ZY/5dvGdtJZxSiX7ZX4+ilEKYLjWglPktEwduTYLK+MJoz M8HVlnUQXAD6W0jOex2QEizMuNtvOrRwM/JC5Ptoq6RghES1LqeyQk/dHHX1Jm7Nqrva jIMaHJEHVAp1ZAeLLw3HbUkao9qMKxrezd4YcNPicf7om0vDK+FjXdliElZLEkthN5Sh MjT6cqR/VDRSos/SqEgs6Qt5asbe69qEDKHbq6xTOw/acVIBttEHnw2p56Pu/CKfmROL VmWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=wLIKb1B3sD7gpDetpYDcnVtopk8WtKF14UnMTVr7z5c=; b=OAtH3vODFoPLBpNVMSDqmvGrQLVT4jLa3bfHDoeMHDnYAYs5tOm3o42HrXciaRsmLy PTnlZszQT4ccLlv1EyLDIKMEF+f206BHQDPl0kyh5Bf8GxHwkH2ZMbdDJ+yF+MI1bTdN T5zuQR6pf+3yV3a+PcFDGlvJtii3FmnX+zDscM0Sml+AwCI/lD8emmKfbzQdvKpiW94a +FDr5E1mCj/PylZSzju0txhtuPCFVnue/3re4mbouwH0UXnQI9PbVQl+lxR5GR6UY0mD LKRqzS/8S+ezDMzN4VR4ziDqltmobH/2GZd6fVgA5K9f4OdrMrvwA3Qqwcb//ZtGaA4I YXbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arista.com header.s=google header.b=GzH0LxLa; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=arista.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gt30si11771412ejc.298.2021.11.04.18.54.02; Thu, 04 Nov 2021 18:54:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@arista.com header.s=google header.b=GzH0LxLa; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=arista.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231133AbhKEBwg (ORCPT + 99 others); Thu, 4 Nov 2021 21:52:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbhKEBwf (ORCPT ); Thu, 4 Nov 2021 21:52:35 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED220C061203 for ; Thu, 4 Nov 2021 18:49:56 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id o4-20020a1c7504000000b0032cab7473caso6027394wmc.1 for ; Thu, 04 Nov 2021 18:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wLIKb1B3sD7gpDetpYDcnVtopk8WtKF14UnMTVr7z5c=; b=GzH0LxLa/7Klq68tpwtV5tT03apuSeJSGuk9msZKS9/0cybWe3JxEm+BTMkS7NpDig h3pZ/kuFMAvhBTuyf9j+GLWoXtQY7vXsSkwndEOge4tDjLoBFbYUnt3t8EdVvgFFVfAv ww6P+4SQ5REZeslnLQHKaZxVPtJAaFCr5sCU2uU9QM1xuWbl8x4nyUOLbBGjo9S9FZOz 7aTjhrgLbxAm67XEkv+ZtgDZ9Ie0fvcXbAzYwDLCjDkhinerxBPrMKGD57mw8i/KGkfB mnuOdWeJ0CyCP0BAEkAgRvkgnoda0Cf/6yTuxo8UpwnyrEKwyg5nfBpx8jGP/HqZp3hL i3ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wLIKb1B3sD7gpDetpYDcnVtopk8WtKF14UnMTVr7z5c=; b=fVQHHxsz0bUVEgz7nZfXmYEz8IWtRaokPv4dh6NRa7nI3WOusqYbQHL8/eAFR1x8+R oHROE5nEW9PSQMf5xQwMAxpRBmuE6aOEny0V7IwRnZDdAMvZc6hp6B9fYC4aNDNtOQJJ HmWqRMM4B8iYtjbDotkfekuNRI4BNhxyalxXXX47AZMTwF/+1HsLoVVKiVnpmDPZe0uH PJfnlhmuwbm5JdLkDWOE2ve2nTFrOcu0J1TdqAKLfDzmrvXTWtsPv8dOUuRAB//ALj4s S6nLXZO08dxi2u3d7/Lo92ACkVTnbZzLU0eZdnSTvCYVITf2sdPa6ed/yNDa5oxmiRD5 tsrw== X-Gm-Message-State: AOAM533S8KZF3LD8W2YdKUQLX8Zs0qvsjRlrTxMqWFAPk8XRze0gbtyb an3CVD7VWA45vxhO2sOmCnM7tw== X-Received: by 2002:a1c:f31a:: with SMTP id q26mr27039636wmq.148.1636076995407; Thu, 04 Nov 2021 18:49:55 -0700 (PDT) Received: from localhost.localdomain ([2a02:8084:e84:2480:228:f8ff:fe6f:83a8]) by smtp.gmail.com with ESMTPSA id c6sm7202421wmq.46.2021.11.04.18.49.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Nov 2021 18:49:55 -0700 (PDT) From: Dmitry Safonov To: linux-kernel@vger.kernel.org Cc: Dmitry Safonov <0x7f454c46@gmail.com>, Dmitry Safonov , Andy Lutomirski , David Ahern , "David S. Miller" , Eric Dumazet , Francesco Ruggeri , Jakub Kicinski , Herbert Xu , Hideaki YOSHIFUJI , Leonard Crestez , linux-crypto@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 0/5] tcp/md5: Generic tcp_sig_pool Date: Fri, 5 Nov 2021 01:49:48 +0000 Message-Id: <20211105014953.972946-1-dima@arista.com> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org 3 small fixes for unlikely issues. The last patch adds tcp_sig_pool, which can be used to manage ahashes besides md5 algorythm. It reuses tcp_md5sig_pool code and in my view is a better alternative to [1] proposal, which uses shash for hasing segments and frags. This also doesn't need introduction of an enum with supported algorythms, which makes it possible to supply any crypto-supported hashing algorythm from socket option syscall (like struct xfrm_algo does in ipsec), reducing needless kernel code. [1]: https://lore.kernel.org/all/5245f35901015acc6a41d1da92deb96f3e593b7c.1635784253.git.cdleonard@gmail.com/T/#u Cc: Andy Lutomirski Cc: David Ahern Cc: "David S. Miller" Cc: Eric Dumazet Cc: Francesco Ruggeri Cc: Jakub Kicinski Cc: Herbert Xu Cc: Hideaki YOSHIFUJI Cc: Leonard Crestez Cc: linux-crypto@vger.kernel.org Cc: netdev@vger.kernel.org Dmitry Safonov (5): tcp/md5: Don't BUG_ON() failed kmemdup() tcp/md5: Don't leak ahash in OOM tcp/md5: Alloc tcp_md5sig_pool only in setsockopt() tcp/md5: Use tcp_md5sig_pool_* naming scheme tcp/md5: Make more generic tcp_sig_pool include/net/tcp.h | 23 +++-- net/ipv4/tcp.c | 193 ++++++++++++++++++++++++++++----------- net/ipv4/tcp_ipv4.c | 45 ++++----- net/ipv4/tcp_minisocks.c | 5 +- net/ipv6/tcp_ipv6.c | 43 +++++---- 5 files changed, 207 insertions(+), 102 deletions(-) base-commit: 8a796a1dfca2780321755033a74bca2bbe651680 -- 2.33.1