Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1447417pxb; Wed, 12 Jan 2022 15:12:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJyoktNhIdFGoQu5oHPx+XBFAV7t5Q5g7+PM5ouTjI73dyJ1B1yBzOpyR3Y52DDa1quNWkbA X-Received: by 2002:a05:6a00:8cc:b0:4a8:262:49e1 with SMTP id s12-20020a056a0008cc00b004a8026249e1mr1590602pfu.28.1642029126831; Wed, 12 Jan 2022 15:12:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642029126; cv=none; d=google.com; s=arc-20160816; b=vfcHsFIq+vn+9/KG733QHS9NjwqxsVbc/4GhBAqb3IN3t3sA9xoLLgc469suUAuwVQ qbPWF0B9u9DAoKd6HVEINIVlYeL35vEi/3hJwyYVPQ1zxxlfsg/qLds/DcDkJzEjUTpo jqULpoXjcsjiBE9EeI89fKsAlUP7LiDpsstNR56UGrMJOdD3LRuLVMFNMOttpwziYTmH 4zkgOGaqZhHxYfmSp33njU3R/mCg5M3PBz4gHagFwafNEFggPgotE7ymbwkLTWj2Kedc JCVRrO+RP9BWdclf9JxwAiRAJdVSmujttI8JYmtQr4yFEccFct6O6q3Jtekcv6sErk4j SBNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=rRXjtbrE2Eve7J58Q9IJgxX8+W28gZ0ioA+AryafyRo=; b=ZIVbA5ah292Y+rYnV4uozatdJuTvEj14nku/ENp0LdTzMsYdJ+kzSr986Sje9lWiBp l9PZjH/VFWZkgapHgw8kAwuo55vyQlmVqCJly7hAFPWdYVn3dklE1DWBhEIsn7ygOAZn lhaOGrIaRzd1wjiCsEikRQw59Tzj95NyBpwYMBiCaCtCHORdfb/33oKdlDJCnBkW3I++ Td5gT1bil0ToXrxI6bPn6HBhOcbMXGeCGR792IZf8+4IdXMhEKQ9PUu8GGLyogX68ls/ NUdMcUCNU67VlIdovsd5oOxXnELJW0YlzsVA7r8sOtSmcK+7WU9dGVTWEYdUjRlQR6Zj 4B4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=d40SY2Xa; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 8si1199924pfm.274.2022.01.12.15.11.54; Wed, 12 Jan 2022 15:12:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=d40SY2Xa; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353536AbiALNTI (ORCPT + 99 others); Wed, 12 Jan 2022 08:19:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353532AbiALNSv (ORCPT ); Wed, 12 Jan 2022 08:18:51 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A7CDC061751; Wed, 12 Jan 2022 05:18:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CC85D61937; Wed, 12 Jan 2022 13:18:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E525CC36AF8; Wed, 12 Jan 2022 13:18:49 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="d40SY2Xa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1641993526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rRXjtbrE2Eve7J58Q9IJgxX8+W28gZ0ioA+AryafyRo=; b=d40SY2XaCIk0dSlLUT5yjkzn3M731524Y1ppya4erUzgWWKIfM4qfTNSnK+z4My2VtBHXW kY3JoOps/+i3GCja/QwYYVHvShcqblBHaBFJwykbJvD7elDljSpfkdiDVO5apndncszVww r9uzpV3ySCfDaeWWK9lpAKJ0ZFgh8i4= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 224c85a4 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 12 Jan 2022 13:18:46 +0000 (UTC) Received: by mail-yb1-f181.google.com with SMTP id d7so6280573ybo.5; Wed, 12 Jan 2022 05:18:46 -0800 (PST) X-Gm-Message-State: AOAM530eAxene4GT+qHasKW5c+BdwykkZE4SaeAHaysG9uZ0moqE1ZPi YwXEaoNRUSb2+7tWvaZjqzIjfF0Rtj75Kq+M8g8= X-Received: by 2002:a5b:10:: with SMTP id a16mr12918334ybp.115.1641993525094; Wed, 12 Jan 2022 05:18:45 -0800 (PST) MIME-Version: 1.0 References: <20220111181037.632969-1-Jason@zx2c4.com> <20220111220506.742067-1-Jason@zx2c4.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Wed, 12 Jan 2022 14:18:34 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH crypto v3 0/2] reduce code size from blake2s on m68k and other small platforms To: Geert Uytterhoeven Cc: Linux Crypto Mailing List , netdev , WireGuard mailing list , Linux Kernel Mailing List , bpf , Theodore Tso , Greg KH , Jean-Philippe Aumasson , Ard Biesheuvel , Herbert Xu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Geert, On Wed, Jan 12, 2022 at 12:00 PM Geert Uytterhoeven wrote: > Thanks for the series! > > On m68k: > add/remove: 1/4 grow/shrink: 0/1 up/down: 4/-4232 (-4228) > Function old new delta > __ksymtab_blake2s256_hmac 12 - -12 > blake2s_init.constprop 94 - -94 > blake2s256_hmac 302 - -302 > sha1_transform 4402 582 -3820 > Total: Before=4230537, After=4226309, chg -0.10% > > Tested-by: Geert Uytterhoeven Excellent, thanks for the breakdown. So this shaves off ~4k, which was about what we were shooting for here, so I think indeed this series accomplishes its goal of counteracting the addition of BLAKE2s. Hopefully Herbert will apply this series for 5.17. Jason