Subject: Re: [PATCH v2 11/25] tcp: authopt: Implement Sequence Number
 Extension
To:     Eric Dumazet <eric.dumazet@gmail.com>,
        Francesco Ruggeri <fruggeri@arista.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Kuniyuki Iwashima <kuniyu@amazon.co.jp>,
        David Ahern <dsahern@kernel.org>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Yuchung Cheng <ycheng@google.com>,
        Mat Martineau <mathew.j.martineau@linux.intel.com>,
        Christoph Paasch <cpaasch@apple.com>,
        Ivan Delalande <colona@arista.com>,
        Priyaranjan Jha <priyarjha@google.com>, netdev@vger.kernel.org,
        linux-crypto@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Dmitry Safonov <0x7f454c46@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Shuah Khan <shuah@kernel.org>
References: <cover.1635784253.git.cdleonard@gmail.com>
 <6097ec24d87efc55962a1bfac9441132f0fc4206.1635784253.git.cdleonard@gmail.com>
 <07987e29-87a0-9a09-bdf0-b5e385d9c55f@gmail.com>
From:   Leonard Crestez <cdleonard@gmail.com>
Message-ID: <344a6d47-3d4d-ee98-10ef-c710b8538f24@gmail.com>
Date:   Tue, 2 Nov 2021 11:50:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <07987e29-87a0-9a09-bdf0-b5e385d9c55f@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/1/21 10:54 PM, Eric Dumazet wrote:
> On 11/1/21 9:34 AM, Leonard Crestez wrote:
>> Add a compute_sne function which finds the value of SNE for a certain
>> SEQ given an already known "recent" SNE/SEQ. This is implemented using
>> the standard tcp before/after macro and will work for SEQ values that
>> are without 2^31 of the SEQ for which we know the SNE.
> 
>>   }
>> +void __tcp_authopt_update_rcv_sne(struct tcp_sock *tp, struct tcp_authopt_info *info, u32 seq);
>> +static inline void tcp_authopt_update_rcv_sne(struct tcp_sock *tp, u32 seq)
>> +{
>> +	struct tcp_authopt_info *info;
>> +
>> +	if (static_branch_unlikely(&tcp_authopt_needed)) {
>> +		rcu_read_lock();
>> +		info = rcu_dereference(tp->authopt_info);
>> +		if (info)
>> +			__tcp_authopt_update_rcv_sne(tp, info, seq);
>> +		rcu_read_unlock();
>> +	}
>> +}
>> +void __tcp_authopt_update_snd_sne(struct tcp_sock *tp, struct tcp_authopt_info *info, u32 seq);
>> +static inline void tcp_authopt_update_snd_sne(struct tcp_sock *tp, u32 seq)
>> +{
>> +	struct tcp_authopt_info *info;
>> +
>> +	if (static_branch_unlikely(&tcp_authopt_needed)) {
>> +		rcu_read_lock();
>> +		info = rcu_dereference(tp->authopt_info);
>> +		if (info)
>> +			__tcp_authopt_update_snd_sne(tp, info, seq);
>> +		rcu_read_unlock();
>> +	}
>> +}
>>
> 
> I would think callers of these helpers own socket lock,
> so no rcu_read_lock()/unlock() should be needed.
> 
> Perhaps instead
> rcu_dereference_protected(tp->authopt_info, lockdep_sock_is_held(sk));

Yes, all the callers hold the socket lock and replacing rcu_read_lock 
doesn't trigger any RCU warnings.

--
Regards,
Leonard