From:   "Li, Meng" <Meng.Li@windriver.com>
To:     "horia.geanta@nxp.com" <horia.geanta@nxp.com>,
        "pankaj.gupta@nxp.com" <pankaj.gupta@nxp.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>
CC:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] driver: crypto: caam: replace this_cpu_ptr with
 raw_cpu_ptr
Thread-Topic: [PATCH v2] driver: crypto: caam: replace this_cpu_ptr with
 raw_cpu_ptr
Thread-Index: AQHXzs6MNRGiDXkbWkOiBbqJdXuioKwD+oHQ
Date:   Mon, 15 Nov 2021 02:54:36 +0000
Message-ID: <PH0PR11MB5191886DE114EF98DF3694CBF1989@PH0PR11MB5191.namprd11.prod.outlook.com>
References: <20211101031353.2119-1-Meng.Li@windriver.com>
In-Reply-To: <20211101031353.2119-1-Meng.Li@windriver.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WC23yuu1gj1u8knSYInGj6Aa4hNinmeSxayXA3idsxOZ1Wpjbx4Y72IyD9Nn?=
 =?us-ascii?Q?XHUtB82KIKTh686OvmJtq3lAcua6L1KufDV8QoVOzB3hUcT4+0vZ5CCFj4Ne?=
 =?us-ascii?Q?4sGtf1N1cT5xga6/K9d8ghzM25Qu0dGYrfpCsmBxVgiOwCS1tF9LXu5ENtdR?=
 =?us-ascii?Q?bwDB9y3yl4oPHDT1T4nEgybYPhp8GGwvKQ5z4+c2wr1I0jUsWrTcQQfeodzt?=
 =?us-ascii?Q?KiTwhL8/YcsLTelM88BFhfRAuK9TId1d2pLr5K0+Y3DZRLn9GohymQ5GFajJ?=
 =?us-ascii?Q?oNzKT0NUJu6NIz7eIYfyqWM4GSc7gHAj8zkZYdzbJ0iBQcTZ9tvgSnENZWD6?=
 =?us-ascii?Q?pSKupv/tllEIwoPvkWmppH0zClKzhG7UpP3+Bukb0XGIme7aA1WPSTpulUhg?=
 =?us-ascii?Q?Wyv3VEAJzM6B/Rg/iCg9qxUrTJ9AbAGK2gq2Sc/4Oewy7h2USPbCE4IONwzV?=
 =?us-ascii?Q?LoU9ntzKFKy4NAIj9FIHQ5mj3EevTZdHuqBVMxL80GlIMtZmx28lG0nwR2jk?=
 =?us-ascii?Q?bqeRISjj4mFCDcsJBZW4bzfnOlSBEp4wdUyxuCdA2kk4Tn3945V25RYtpTDf?=
 =?us-ascii?Q?pUF6eQAj8GwAJtSQene1bM/NmHzuYRKiX5hMEZpnF2OqaenAHNmWalyHAr87?=
 =?us-ascii?Q?a3jEPD8ScuALZ+k6wvgCX9ZWhNuecUo6uUD9vXNceRHcFe6eSbfJMldD95yF?=
 =?us-ascii?Q?E+oSYI1eHgtDDsRjEQReErrhRy33SnVSk/cPq3HzD/Ujt45A7lfs6pJBNuAH?=
 =?us-ascii?Q?HrKjy/DPxFP1VTaynQGAcDSFYacW6ngZPZb9VXKt1Tcd/OYAsfAGXcHGjbj2?=
 =?us-ascii?Q?h6rcG0Zz3T7Wpj8mxNVoFMhCUETcMupxRaCxUgZbJ0rabsczgb4EqV+rZNqH?=
 =?us-ascii?Q?cLn+GiETRqMwmlRShmcm958e8bF9GgN/2BJh+JuuG6eMCw0hU50gyLHJnWtU?=
 =?us-ascii?Q?IMwtDk8D6yq28t4dhej8p7P4YTlrUclWA0MdFP15RcbqJO2rnwllHt1Y85Da?=
 =?us-ascii?Q?VA1DlXUsNIKAJC9kX8lMfbemNoSYvzVP2fmzNUYhCxxprpP5nnY7l+9I1PRl?=
 =?us-ascii?Q?nSBa+dPCxKUPsODkZKt5hiV6CXA3yql/N+Jz/f809FDef5aju84oibq08GPF?=
 =?us-ascii?Q?vdiLwKKuCasthTKyERKggwPwZmZBGj+rwcg9Qk5ck5alagIKN/whM9tB+5JK?=
 =?us-ascii?Q?UHnYxXmQiYaWbezQfJpSX1uTlFnVFWsbj/SF5N0go0Q8TyyuNubvT2aZUkN+?=
 =?us-ascii?Q?aUN3VCbBvPOjshiyhWHCreW9GGMrNdvBFJHHfBDBmmgq6JjZTIZVA/JTTATQ?=
 =?us-ascii?Q?E36MFaOSRW9nQNI4pUj57zRoRDup5OT4c9TE3ag5zRm3KLe/fdUVSErjdDQ/?=
 =?us-ascii?Q?4LgJmRRUADBfEMXSLqA3KljTCMffhyKXpo1gfdWvpedO1ex9gBbI/YApyEt8?=
 =?us-ascii?Q?bgwxYwlNqxVMQlO/mxhr/4zTDm+s0dv/XpGO6rjwMPpSTDzvFQwoT8idaWYc?=
 =?us-ascii?Q?XozWDtVRabc27Dc1uOf5GffFAxeCgVtLQ937sASeP1L9y8rt1nKwMinJTxm6?=
 =?us-ascii?Q?VaMIHU1vDZEBqqJvd2NIeN2vPDNYB5JfG/PWzNy6ZgbOHJ+vuu4rjFTnMWTn?=
 =?us-ascii?Q?cA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5191.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 499036b0-13a4-4be8-b432-08d9a7e3430b
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2021 02:54:36.9908
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dbJUj7xHsaG3sWh/pcjrR0+l/RdnjpL/wenTy2dsIpXf/KHKme/YeoX+EW9EJAxQ3U1A/PBcMkUl9jGzYtADmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5885
X-Proofpoint-GUID: Yy6DzVernAwvrx0QYBT1ztNiknIQ4gvm
X-Proofpoint-ORIG-GUID: Yy6DzVernAwvrx0QYBT1ztNiknIQ4gvm
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-11-15_02,2021-11-12_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 adultscore=0 clxscore=1011 bulkscore=0 mlxlogscore=999 lowpriorityscore=0
 suspectscore=0 spamscore=0 phishscore=0 impostorscore=0 priorityscore=1501
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111150014
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Is there any comments about this patch?

Thanks,
Limeng

> -----Original Message-----
> From: Li, Meng <Meng.Li@windriver.com>
> Sent: Monday, November 1, 2021 11:14 AM
> To: horia.geanta@nxp.com; pankaj.gupta@nxp.com;
> herbert@gondor.apana.org.au; davem@davemloft.net
> Cc: linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org; Li, Meng
> <Meng.Li@windriver.com>
> Subject: [PATCH v2] driver: crypto: caam: replace this_cpu_ptr with
> raw_cpu_ptr
>=20
> When enable the kernel debug config, there is below calltrace detected:
> BUG: using smp_processor_id() in preemptible [00000000] code:
> cryptomgr_test/339 caller is debug_smp_processor_id+0x20/0x30
> CPU: 9 PID: 339 Comm: cryptomgr_test Not tainted 5.10.63-yocto-standard
> #1 Hardware name: NXP Layerscape LX2160ARDB (DT) Call trace:
>  dump_backtrace+0x0/0x1a0
>  show_stack+0x24/0x30
>  dump_stack+0xf0/0x13c
>  check_preemption_disabled+0x100/0x110
>  debug_smp_processor_id+0x20/0x30
>  dpaa2_caam_enqueue+0x10c/0x25c
>  ......
>  cryptomgr_test+0x38/0x60
>  kthread+0x158/0x164
>  ret_from_fork+0x10/0x38
> According to the comment in commit ac5d15b4519f("crypto: caam/qi2
>  - use affine DPIOs "), because preemption is no longer disabled while tr=
ying
> to enqueue an FQID, it might be possible to run the enqueue on a differen=
t
> CPU(due to migration, when in process context), however this wouldn't be =
a
> functionality issue. But there will be above calltrace when enable kernel
> debug config. So, replace this_cpu_ptr with raw_cpu_ptr to avoid above ca=
ll
> trace.
>=20
> Fixes: ac5d15b4519f ("crypto: caam/qi2 - use affine DPIOs")
> Cc: stable@vger.kernel.org
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
> v2:
>=20
> Add comment to describe why the raw_cpu_ptr is safe.
>  drivers/crypto/caam/caamalg_qi2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/crypto/caam/caamalg_qi2.c
> b/drivers/crypto/caam/caamalg_qi2.c
> index 8b8ed77d8715..6753f0e6e55d 100644
> --- a/drivers/crypto/caam/caamalg_qi2.c
> +++ b/drivers/crypto/caam/caamalg_qi2.c
> @@ -5470,7 +5470,7 @@ int dpaa2_caam_enqueue(struct device *dev,
> struct caam_request *req)
>  	dpaa2_fd_set_len(&fd, dpaa2_fl_get_len(&req->fd_flt[1]));
>  	dpaa2_fd_set_flc(&fd, req->flc_dma);
>=20
> -	ppriv =3D this_cpu_ptr(priv->ppriv);
> +	ppriv =3D raw_cpu_ptr(priv->ppriv);
>  	for (i =3D 0; i < (priv->dpseci_attr.num_tx_queues << 1); i++) {
>  		err =3D dpaa2_io_service_enqueue_fq(ppriv->dpio, ppriv-
> >req_fqid,
>  						  &fd);
> --
> 2.17.1