Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EFAFC433F5 for ; Mon, 15 Nov 2021 05:14:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49D1363211 for ; Mon, 15 Nov 2021 05:14:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229915AbhKOFRw (ORCPT ); Mon, 15 Nov 2021 00:17:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229565AbhKOFRt (ORCPT ); Mon, 15 Nov 2021 00:17:49 -0500 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC418C061746 for ; Sun, 14 Nov 2021 21:14:53 -0800 (PST) Received: by mail-ot1-x32a.google.com with SMTP id a23-20020a9d4717000000b0056c15d6d0caso18314356otf.12 for ; Sun, 14 Nov 2021 21:14:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BMbEPtsbChaQ9kwcj5OuQcbYWqd3cNOAC83nr5T8yyI=; b=DHEFZoB9bkdBRG/oDo/N4tyJjtDpz8D14UVrZUnxt8V870CTf+qFHI/lvtvuHqRB/S 0G0cjwSQGbh2B1qLGr73dpG/vQULcOEreyjmvDTjPnUDXuObqmEtgniwz4vo5XbksBVg vCCncJQQhH3fcNQbTYmJPBQxrlMraOGsSKdodP4JgpkTMJIwrubWgZrFda1g8OIzTNxm Hvifk8oz7cvw0SB76JMeE7rzbvOcaciTbzgb4U+5vt6012qcEIsys86HzCh47wcNbu0E veJdQWV5l4be7+kxFoPzZ6NolTqC7Gt177WZ62AeYA8gsmgry5iFCmjYgM5mYCp8Dk3j YlDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BMbEPtsbChaQ9kwcj5OuQcbYWqd3cNOAC83nr5T8yyI=; b=KgLeA4PZYunArH7HqH9gR+iVbRaPHPyI19sFcPlepyidC2ZNGfTvfjBsbEgqLJyxNW CtZdwbgX3sosAwimzYfKE3sunmS5wYqJrWfA7mOzulnr9jfK0OF+0mghLWjuwlFxez9Z bzKU2WnHoVJLgOfrjeITvjzrcELx8uLi9EQ0QSU9gYImMSgLl+7hA7nqYDX/DfJBlC3M /dJ6T7xZjUbICzPIFLfuDb2Fn5U3leQQulezNOB/jkBzJKAVE0Iyd4SJgfiEAQQ+ghGh lDK2xI8eTyT7dQs1EVLMFYNyiBMNnEQEQXN/gB3AMlwZMpeY2qn5kQz1NU72fC8COi5C x0Pw== X-Gm-Message-State: AOAM53041xTkSlbwoqMmcY4yZvRCkyCSN/rGCPt2znVXE1oiJnvGGpiV P+oeXEZGjabpNhCx+6r6crRICQp1ARiBNibxkchTWw== X-Google-Smtp-Source: ABdhPJz3TTMNAa2dJFRzkpEI9ELUZYw8ZgbwV5c101o89o5/Ov2SfAi97SBBev+zEl8y8GYrD7s2hO/0jqAVRmXvwEo= X-Received: by 2002:a9d:63d2:: with SMTP id e18mr15449878otl.28.1636953293247; Sun, 14 Nov 2021 21:14:53 -0800 (PST) MIME-Version: 1.0 References: <20211110105922.217895-1-bhupesh.sharma@linaro.org> <20211110105922.217895-18-bhupesh.sharma@linaro.org> <5b8d5f23-e766-5b9c-986c-ef70fae9119e@linaro.org> In-Reply-To: <5b8d5f23-e766-5b9c-986c-ef70fae9119e@linaro.org> From: Bhupesh Sharma Date: Mon, 15 Nov 2021 10:44:42 +0530 Message-ID: Subject: Re: [PATCH v5 17/22] crypto: qce: Print a failure msg in case probe() fails To: Vladimir Zapolskiy Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, agross@kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, stephan@gerhold.net, Bjorn Andersson , Thara Gopinath Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Vladimir, On Fri, 12 Nov 2021 at 16:12, Vladimir Zapolskiy wrote: > > Hi Bhupesh, > > On 11/10/21 12:59 PM, Bhupesh Sharma wrote: > > Print a failure message (dev_err) in case the qcom qce crypto > > driver probe() fails. > > > > Cc: Bjorn Andersson > > Cc: Rob Herring > > Reviewed-by: Thara Gopinath > > Signed-off-by: Bhupesh Sharma > > --- > > drivers/crypto/qce/core.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > > index 98784d63d78c..7c90401a2ef1 100644 > > --- a/drivers/crypto/qce/core.c > > +++ b/drivers/crypto/qce/core.c > > @@ -280,6 +280,7 @@ static int qce_crypto_probe(struct platform_device *pdev) > > err_mem_path_disable: > > icc_set_bw(qce->mem_path, 0, 0); > > err: > > + dev_err(dev, "%s failed : %d\n", __func__, ret); > > return ret; > > } > > > > > > in my opinion expressed earlier this change is not needed, but I'll recede, > if somebody thinks that the change is useful in any way. As I mentioned in the reply to the review comments to the previous series, the need for this failure message was actually felt to address failures seen with boot-on crypto tests via 'CRYPTO_MANAGER_EXTRA_TESTS'. So, I would suggest keeping this patch in, unless there are some major concerns with the change. Regards, Bhupesh