Message-ID: <b1133dd1-a5a9-de1e-e57f-1b471d2e513b@oracle.com>
Date:   Mon, 15 Nov 2021 09:19:49 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 02/12] crypto: add crypto_has_kpp()
Content-Language: en-US
To:     Hannes Reinecke <hare@suse.de>, Sagi Grimberg <sagi@grimberg.me>
Cc:     Christoph Hellwig <hch@lst.de>, Keith Busch <keith.busch@wdc.com>,
        linux-nvme@lists.infradead.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        David Miller <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, Chaitanya Kulkarni <kch@nvidia.com>
References: <20211112125928.97318-1-hare@suse.de>
 <20211112125928.97318-3-hare@suse.de>
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
Organization: Oracle
In-Reply-To: <20211112125928.97318-3-hare@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STJxU1VFdG1heGVUN0ZtMDBKMEdvNWhwR2l0UzNKTVdoRzcwT3A5NXptQW9l?=
 =?utf-8?B?ODJPZmNqWmFOdjU3eTJjWkx5UlJ4eVNDMmNTL1B3NEJZalMzOTNEOHhBZk4y?=
 =?utf-8?B?ZGhqSWozcXc3MkRseGNOZkxmKzJzQVhFdkpMVmhGT0MwT3BKRkErYUI4c3Bv?=
 =?utf-8?B?UG9kdlFqejJITUh5NFN2N2s1UFNEcm10REhNRUc5K3lrYXRXU3ZKTXFwNHRN?=
 =?utf-8?B?ZWU1S2RjVHVCUjZmQTBuakl0NXJEM0V4YW5YQ09pMDZ2STFJQkd0cVJsZ3Vt?=
 =?utf-8?B?LzltMUNpYWRSbjFZbC9xMjkza0hER3Z0L1BrdU4vNUpkc3JWazdVK3BPekVt?=
 =?utf-8?B?cmc4Vk9ZbWVqazBRQVpNaDd6WEFlL1MxbDJrYUlETHk4bWtiaEdlTXR0WWov?=
 =?utf-8?B?T2Y3ZFFnU2oySldHL2htM0xwVU9pZlRXMWN2Nmpyc2xHR3B4ZzYrNldoTXBN?=
 =?utf-8?B?VDJoNGlwWTZxcU9PdHNMM3p3K1NQV2ZTOER4S0xTZ3U0L3BWdDB4ZkgrUU51?=
 =?utf-8?B?TmxsaXowUTR6WjNjN2dLa1F3RW82aHJ3cWlsWG5rUm1Kd2xJVmdEelJiZTRj?=
 =?utf-8?B?ekhzWEh3VjFJUE9UaGp1MlVHTS8vM0NpenVWakpkM1VoaHRyZGJzT2ZZRTR4?=
 =?utf-8?B?TkN0b0FSS3ZvcnBVTWlzT2o4Uk55WUR3a0dtc3VyeTRCQmVhYUwxZXpibkhS?=
 =?utf-8?B?dDBnUDNDMFUzbFZEKzZhRllKS3htTm0zK1lTeFo5VkpKT21xSkdsQUFVYXA2?=
 =?utf-8?B?UmxJTDZQMnQvVTV6TVB4TG1OUXJqSFNWdkJ4L3ZqWHRhM0N0eFZPVzlNMWF0?=
 =?utf-8?B?TUV0UXhvN0xIbFB0ZUo3Ykx4LzFlUHgybnRLRjBjdlpxNCtQOHU0R2dMQzhr?=
 =?utf-8?B?Z0dFN3hPTEpvMDRPblJybU05cnUvT25JS1c4TzBpNHJ0VDY2UUhBR2ozQ09N?=
 =?utf-8?B?aWxtTElnaER3RkpqdWdScUtMSUl3bGJlY2dTaXd2SHNYYmRJMFFZaEh5U0Ja?=
 =?utf-8?B?S0w4MGRBWGFmbHN0S3BJUll1ZHNzNmM3all4VzRPSk5jZkd2dlUyeXZpQXBu?=
 =?utf-8?B?c1pGOWZmVjZlbHQzS3FQSTJhR2M4KzRDNmZMZFl1L20yUDc2bENrNThIdUd1?=
 =?utf-8?B?Z3NmblhtM0NCSWI0czAycW16RHVxaFBQYTcvQngxYk91UVBFaXBpVEw3SFhE?=
 =?utf-8?B?bVN3TGNVanVCRTgxa1dLRTdFT0dUc0lzelhEZnBDelhldUFNKzB2SklSeHNn?=
 =?utf-8?B?d1VVa1pNOS9Zc2pJUXNEeVh6bkhqbUJOS1JMZW5LcmxZbXF0NXJrZUdRM3Y3?=
 =?utf-8?B?czRPMkc3UWxHQjBEck1QSDlpekVkT3A3dzUzZ3Q0Wkd1NkJ4cmk0KzFLRThj?=
 =?utf-8?B?eU8xYlJmQWRNMlRFcHRQTmxlaGFxUmhMWXhNVHphMXNyQVlsT1AwbnR4MUx5?=
 =?utf-8?B?SkdNRWVURjJEYm9TaEhvM2w2d09iS2EyYm1Sa2RDUmFjOUtaVzI5NDZTdTFI?=
 =?utf-8?B?OVFZQ3BraTJGZS9WdUZwS0hpUnNIUkkzdllqRmI5QWRJcGtiQXA0Z3cyWlkv?=
 =?utf-8?B?c1hMSktBS1NuYklzbjlXRHBIaDNyaisxSm93RU14ZUY5OC8xQjBpMngyVVZ2?=
 =?utf-8?B?bytsUUNWUVBNMG5Ya0tkVWRuUm00ZnlLNzFOSitqYUs3MXVIdTV2YnlMaXhq?=
 =?utf-8?B?aWZiWWJCLytVSnJZcVZpQVZzNEx4RlVvNFltUEV5cjdSM1I0Q1k0azZ1eUZn?=
 =?utf-8?B?MGczL2lxOFJIOWQ1Sll4R215ZEE5bmhHTnIrY2hDd0U5ODBTUDEyUi9nY0dj?=
 =?utf-8?B?eFVaWXlqVDdmRk5iV1EvVUYrR2h2eUlhM3FBd3hkcEhXYTFKQ2lodEZvRU5N?=
 =?utf-8?B?a01qTkk3SnpuakVVTDJRQ0MrQjN6M3Qvd1JWZnMvRTdIbHo0UHVmQlN4ekhz?=
 =?utf-8?B?VC9tMkdJR0VreVRMMXYrY0NSdVF0WHFXa0c4S29wK3U3ei9KQU9iOW1tdlVt?=
 =?utf-8?B?U0k0ZEFtcnQrdkp6M0RWSjVCOWZIdktCYWRFWGVsZGFiUnZ1cHJZTEZIVldT?=
 =?utf-8?B?Z0FsMlhNSjI4M2dWc1d3d0JOZm1mVWxWdVRxQlpSQS82cjF0VlNTZ2tnOXFT?=
 =?utf-8?B?YzJ0UThqTHo0OWYxMGFOOWxWakpIUUxCZ3VwazFxbFJtbUgxbVRJc3hwVGVu?=
 =?utf-8?B?ZmVPbUN3anRPcE42L0tmRlZockFxWWRLYjMxQnJONFlGd3EvMXhvdnhUWUJu?=
 =?utf-8?B?Sk1pRnVxMjkxSVhvSWFETjFxSlR3PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7583af6f-5716-41a3-4f8c-08d9a84b5e8d
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2943.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 15:19:51.3028
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H6iQdFmXbN2AD5QdNcsG0bT3SdOvezU3xKhHDUeuDOaYLQVm7MBwKyTRgetE05WKGTYTfqBjkHd4dmieTypP31E9ntHbM5HXNbMV+WltI0Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5638
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10168 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0
 adultscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111150081
X-Proofpoint-ORIG-GUID: sBF7EjFqHAadC-0-j1DzOizfmWJzJtVq
X-Proofpoint-GUID: sBF7EjFqHAadC-0-j1DzOizfmWJzJtVq
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 11/12/21 06:59, Hannes Reinecke wrote:
> Add helper function to determine if a given key-agreement protocol
> primitive is supported.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
>   crypto/kpp.c         | 6 ++++++
>   include/crypto/kpp.h | 2 ++
>   2 files changed, 8 insertions(+)
> 
> diff --git a/crypto/kpp.c b/crypto/kpp.c
> index 313b2c699963..416e8a1a03ee 100644
> --- a/crypto/kpp.c
> +++ b/crypto/kpp.c
> @@ -87,6 +87,12 @@ struct crypto_kpp *crypto_alloc_kpp(const char *alg_name, u32 type, u32 mask)
>   }
>   EXPORT_SYMBOL_GPL(crypto_alloc_kpp);
>   
> +int crypto_has_kpp(const char *alg_name, u32 type, u32 mask)
> +{
> +	return crypto_type_has_alg(alg_name, &crypto_kpp_type, type, mask);
> +}
> +EXPORT_SYMBOL_GPL(crypto_has_kpp);
> +
>   static void kpp_prepare_alg(struct kpp_alg *alg)
>   {
>   	struct crypto_alg *base = &alg->base;
> diff --git a/include/crypto/kpp.h b/include/crypto/kpp.h
> index cccceadc164b..24d01e9877c1 100644
> --- a/include/crypto/kpp.h
> +++ b/include/crypto/kpp.h
> @@ -104,6 +104,8 @@ struct kpp_alg {
>    */
>   struct crypto_kpp *crypto_alloc_kpp(const char *alg_name, u32 type, u32 mask);
>   
> +int crypto_has_kpp(const char *alg_name, u32 type, u32 mask);
> +
>   static inline struct crypto_tfm *crypto_kpp_tfm(struct crypto_kpp *tfm)
>   {
>   	return &tfm->base;
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

-- 
Himanshu Madhani                                Oracle Linux Engineering