Message-ID: <4c301e38-5b87-fccb-5e2b-ec5f78895151@oracle.com>
Date:   Mon, 15 Nov 2021 09:25:42 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 06/12] nvme-fabrics: decode 'authentication required'
 connect error
Content-Language: en-US
To:     Hannes Reinecke <hare@suse.de>, Sagi Grimberg <sagi@grimberg.me>
Cc:     Christoph Hellwig <hch@lst.de>, Keith Busch <keith.busch@wdc.com>,
        linux-nvme@lists.infradead.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        David Miller <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, Chaitanya Kulkarni <kch@nvidia.com>
References: <20211112125928.97318-1-hare@suse.de>
 <20211112125928.97318-7-hare@suse.de>
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
Organization: Oracle
In-Reply-To: <20211112125928.97318-7-hare@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y01oTm93OXEzVEl4YjNidjdFamZyMXBJZUtmanhnTk5hbXJsZ0VGaFY5TlQ5?=
 =?utf-8?B?a2tFWlZjMWdDcDY1WVVJcEc0dGduY3lVTGxHTUljVWxPNmZ6UDBYV244Q2hu?=
 =?utf-8?B?Y1V5dmMwc2hPK29Leno2eHlaTHY3cnpMRWN3UjBqUk16VnZBalFHWStIVDl3?=
 =?utf-8?B?amJpL1JoK1pkMkVOdGs1a0xIV29IQWJNczdqd2FVQTBKekw0a3RHVVFiVktY?=
 =?utf-8?B?ZVRzVlVwZnA2QjJpcTZwdE1ScEVlbXZabmNPUmY4TkE1MzlpNWgvQjNYbk5m?=
 =?utf-8?B?TkpldlBrZjNKRzB2Slh2YnVpdTMvOWQ2LzByOE9UMTlUU28vNEp6M0tOQW1r?=
 =?utf-8?B?NzhnUnJuaU5mNGhNV0JxOGF6WnZpaVJuZ0ZxWTRaZFc0dUNzQmRZZnNuWk44?=
 =?utf-8?B?TzNDL2Z5MzRFd1FrbUZmUk9ERmd4d3IvdExSU0JvUmp5OEU2cFBFV0h3Y0gv?=
 =?utf-8?B?b0xJeTBHelJGWG9ZNTBhd3M3bXVyL01qWUgrTE5BYkpFeDUrbzdXQUJHVEJz?=
 =?utf-8?B?Yko2M0xvYXRZaUhMSGdXWW1tUHpVMFNXQ2hwdzVnbFNJdnpFb3hHenh2bTBC?=
 =?utf-8?B?QVI0RFJmL3ZrWStFWlZFMy9EVVh0MTk0NjVZTEFvQ21vbUloWUtqSyt0cDFF?=
 =?utf-8?B?ZGUyVWFZQzl0YURiNEJtVDJyU3Yvc0lrUjF3OGhWZGFsejdyblU1eVlZOGky?=
 =?utf-8?B?L0hzNTB5Z1RjMUJGcXdZNmpFdDA5by85Y2M3b3pDS0djRTEwWHNtSEpPUmEx?=
 =?utf-8?B?dzZ5WGxtd3U4RFd3L2lzbHJaK3pDVEhTazBhSmY0bXVSVm5aVmdoN0tqQUtq?=
 =?utf-8?B?d0tpOXlZL0dEYUNjQmp6cGlHM3RqVUE1eFBLMTlDUjNhUVpiS29peFNBVWxP?=
 =?utf-8?B?OUdKbnBtcmFBV2VOWVUzOXpyUWJMbi9qSzRCb09PRWJFVXVDM1FCZ2RLNVVS?=
 =?utf-8?B?NWlXWURMeUsyTFBJWm1TcGUvSnBKd3pZNEIyTFJBYkVxYTJkcm5US2w1S1Ra?=
 =?utf-8?B?LzM4aGF5NEptYmp4eFFBVGMrcVZ6b1RHZ1RqRzFSUHZVano4R3NSV3pGMGg5?=
 =?utf-8?B?blN6MGFOUU9XZ1BmTGpNVWkremVrUStUVTBDWkF4bXFId29Ub1I1UzdBNnRQ?=
 =?utf-8?B?Z0FXNnZ5aEJwZHZjMG44WTJBejBTMExMeWRWRFF3MmJLY2xEbGRrb3FpUTJY?=
 =?utf-8?B?OTBENzRuSjJKWkJQZ1JFV0hQR0ZOL29velNVa1graGY4R051ejR5enZQbmU4?=
 =?utf-8?B?QnR2My8xZFlkUXp2cWVoaElnWDJiQTZqVFlTV3NDckJwQ3FwdGV3dXpBTmMy?=
 =?utf-8?B?a2cvUU5MVHFSTy93a1UrNnB3cUQzYzVmcHFtTGdmbEx4RWwrUkdyODRIQWhj?=
 =?utf-8?B?KzZUdUI5clYrVmY4VEREMDk1Ym1oZ29FcXFJQVhObTdIRllRNTJPdzdIOU4w?=
 =?utf-8?B?TGRpTnBpQ0x1bXRNU1ZJQlNsK0tjTHVCRk83Ty9RY1Ewc0tpWXZoRXlia2o0?=
 =?utf-8?B?MDlwRmZSbDRBNGtxRmpHRlpYVWxwQjFJZU1NSTloWll1UW9sZDBJUXlKbEUw?=
 =?utf-8?B?SWx3dWJ0QUo0eXBDZW1DSzZHRGl1RnkyK3dEYjZYMjVUY1ljazQzUWVTcUpY?=
 =?utf-8?B?eFkrNDcrTHZKSm9NT0pYNmNEWkZkdHFCNGJvYWFqUzhUUkxwRERJNE43MGh2?=
 =?utf-8?B?VXZJYmozc3pLejF5citvV2RHRVFEbVE4dDNDcTVlUTJ6WVFBbjZZSWVJeXpV?=
 =?utf-8?B?SFBUZHpib0o3UzFzNmJpYlNBS053MWNCKzRsSHNtaVNOWjFyeXBsUE4veGVa?=
 =?utf-8?B?VXVoa1lHT1Q3cUE5Ukd2NkVDYVpwVkNuWjZPNXB2QzE1bnJtU0QvSXNjM0Rl?=
 =?utf-8?B?Z0wvR3BEVWFNT25sZEltYnNjMlJpU3JPWERiR3IybVNkdTFHNVFXeDBmTkgx?=
 =?utf-8?B?ZEd3ZHlNU2d2WkdEREVhOFJqNDV3b3ppYmQzTjhINjRjTTRBdHAvUzl3RGdw?=
 =?utf-8?B?eUpsSFNLdmpTaVMrSStSejRsbU1MQXFKWFUyeE5JZGVQSHArRGhVc00zdVh4?=
 =?utf-8?B?SHJ3aGMrbEdCUUltWTVzMTcwUVhna1d5NFdRcFY3YUNxTFlPRlQwdko0dWxO?=
 =?utf-8?B?SkhrTzBwU2R4YW5aSlNXR0ZGL0ZLYlZmZHVlSFJCdk1KTnVrckVDalRHZTRD?=
 =?utf-8?B?WDBnVS9GS1hPUU5RT0NLcURraVRZKzlGY3QxT0lpTTNjNzlNWGVvVkJlWGU3?=
 =?utf-8?B?M1l1VnplN1J3QS95MXhrK0RDTzZBPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f14f2233-22c7-4885-aa7f-08d9a84c3157
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2943.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 15:25:44.9704
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T/QbNXU5uSQenRGtZEYUrHiGQyQNi05wYJP6RoWN0K0Zu8IuHox6fn9fi/LdfXPbCIdVPp9owQl+e4UEUGNgmat5eDbxvlza06OjklQcG+c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2510
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10168 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0
 adultscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111150082
X-Proofpoint-ORIG-GUID: GP5dKMa7TIJsioc777hYEZmZWNDO4L07
X-Proofpoint-GUID: GP5dKMa7TIJsioc777hYEZmZWNDO4L07
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 11/12/21 06:59, Hannes Reinecke wrote:
> The 'connect' command might fail with NVME_SC_AUTH_REQUIRED, so we
> should be decoding this error, too.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
>   drivers/nvme/host/fabrics.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
> index c5a2b71c5268..a1343a0790f6 100644
> --- a/drivers/nvme/host/fabrics.c
> +++ b/drivers/nvme/host/fabrics.c
> @@ -332,6 +332,10 @@ static void nvmf_log_connect_error(struct nvme_ctrl *ctrl,
>   		dev_err(ctrl->device,
>   			"Connect command failed: host path error\n");
>   		break;
> +	case NVME_SC_AUTH_REQUIRED:
> +		dev_err(ctrl->device,
> +			"Connect command failed: authentication required\n");
> +		break;
>   	default:
>   		dev_err(ctrl->device,
>   			"Connect command failed, error wo/DNR bit: %d\n",
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

-- 
Himanshu Madhani                                Oracle Linux Engineering