Message-ID: <99e93779-b003-6ee1-429d-0b3af172926f@oracle.com>
Date:   Mon, 15 Nov 2021 09:43:10 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 09/12] nvmet: Parse fabrics commands on all queues
Content-Language: en-US
To:     Hannes Reinecke <hare@suse.de>, Sagi Grimberg <sagi@grimberg.me>
Cc:     Christoph Hellwig <hch@lst.de>, Keith Busch <keith.busch@wdc.com>,
        linux-nvme@lists.infradead.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        David Miller <davem@davemloft.net>,
        linux-crypto@vger.kernel.org
References: <20211112125928.97318-1-hare@suse.de>
 <20211112125928.97318-10-hare@suse.de>
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
Organization: Oracle
In-Reply-To: <20211112125928.97318-10-hare@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3lXbk9JY0RWNXdXZUkzamc4a2tkWFpMVjNGaW9XTXdJRWZIMHlRSmhTWUFn?=
 =?utf-8?B?T3ovQmptTy9iN00xR1FzcDQwSzA3UVhzdGZPQnZudkJiYVR2L3BIRkJMdTJC?=
 =?utf-8?B?c0luekVHYWlaWFZUUkdaalJoclowKzZUNGtrcDduaW5CNHMrZDJaalVNV3cx?=
 =?utf-8?B?U3hndVhnY0FSVUlGZWxacGhSOW9ldW1mamtDeGZtdkdzUXJ4aVE4dTF1OVV3?=
 =?utf-8?B?djVQSTNPUEFIUWUvZlFqQzY2eHpNWjRBTU05Y1djbTA1YVV1OUZsMTJRWExm?=
 =?utf-8?B?cWF0MEljU1ZCL3VjN1dMSWphWHRrUmFjU0Zpb0dnN29nN1NzeHFrTXQwaXJS?=
 =?utf-8?B?VDM4bktoem50Rno1UDhnaWV2UFU4V0IzaVBUakVLWGxFNzB0UGo5WHlYTHQx?=
 =?utf-8?B?V1JIbTlab3NnMUV4TWxxekR3SVFibExxQXFieDBEN3QxTXQ1OGJrQnZZU0Ew?=
 =?utf-8?B?ZTFiS1FGYTBHRUxkU2RtQmRVM0x3RnVIaUtMVTJCS24rd0RTUGVyVWdlQkZ0?=
 =?utf-8?B?WFhYK2ZMK3VCdCtFM29YYkd4alArV2hWNXpiNkIrVk9IWFNNTDNtUTd2VzRz?=
 =?utf-8?B?bmNJQ3ptbURxRzIwRUhNTmRmR29lalhCQ1VnK2RuSDJZampMVWtFb2NiYXh3?=
 =?utf-8?B?WkZQaGxqeTlPVEpDWUgrSGRjUjJWbGRCY2hQbXE2eFJVL1BWbzZlT0lyZmVr?=
 =?utf-8?B?VnJUTlV3NE4zaklsV3NCekxsRUFsR3BzQ3pvRHpHTnUyUkJtVWhseHFBMmV3?=
 =?utf-8?B?N0daM1FNdTFsdXl0ZFFhVEJUTy9obVFIQk5uRHdSUU9KNCtNdkZUNnFJaVJu?=
 =?utf-8?B?cmFkTDladGV5bFVIRHdrWFlxUjcwN010WmlKcGFDa2J0YmdDMnBjR2VpR2JR?=
 =?utf-8?B?NkxMb0M1RHNxWTJzc3RGNXNNU0NPd1lraGc0c3dWbVhRaEFyb3pBdE5DTmVS?=
 =?utf-8?B?RVBLVkpLamlmZC9NSHF6S2NETUE4VU1RSVZ5YUFNdDNWSG9PK1I4K0R4TVBY?=
 =?utf-8?B?Tmx4ZE1DTDhVU2w0eDB1Rmo2dDZwNUV2STBicUxuUEw5VFJLUUlFcVpXS3dK?=
 =?utf-8?B?NWhjNW83MkZEVHByTmpyL0dSejdBUHpsbmFOZ0JjTUxqK3JrQlB6ZkZFRmgz?=
 =?utf-8?B?ODBGWkVqRnk2N1Q1SHptelFwdU0yZWIydjhMbytxbkFKK2hNbEdCMXMxbFNr?=
 =?utf-8?B?dkQxZk1NdGxMdlhlWkVVWGpoSUNaa3ZYOFhJWi82VU9HM3NSd0pGRnU1cjRX?=
 =?utf-8?B?SThNYUhzSWJXUjBjMDNON1EwZERqM3IyS0xEWk5hNUE3QjNLemViZ2IzY1B0?=
 =?utf-8?B?dllXT3RXL1psUkJiSlNSZ0loWUoxZHZ1MU8yejhUbGZTVXNsOVhndnVvc2wr?=
 =?utf-8?B?OFhYc0JmMVpHb3hYUDJ5RE13SGh3UVlxbmRpMU5MNi9qUWJXaXBUcFJXV2NM?=
 =?utf-8?B?Z1VzaVlibGdDTkkzdWtraTNhSkVTamlqK2lhOEhzcTUxNy9Td0xUdTFxWHQ2?=
 =?utf-8?B?eFpjcWNTS2tsYzN6czBwYWNMWXUwZ1kvelhhM291SDRyc2RDazJ6dUlWNFA3?=
 =?utf-8?B?Z3RlZWNyeU15aXBqdStCWmxPZlB5U2F2b1RTUTlPVXdyWHBsRDEzWUE5d3Bk?=
 =?utf-8?B?aUNONXJxaENaTFVxK2o2Nll5Z25LMVBDL0VrMEZYT1ZBU3BNV1Z3WDhMRlkx?=
 =?utf-8?B?c09sd1V5RENEcnBjUlNuWUYvcTB3bmVFeHV5MHp2em5DTUZhVjQ3Mjl4TUVk?=
 =?utf-8?B?RTBtU2NpSkRCMTB6QTJ0elJ6RnliM3c2MDIrYVgzMmNnWG1ZdGl2a0QrZ3BK?=
 =?utf-8?B?OFR2QkZUSW9zN0plMXc2ZVNJNGRuS0VTeVI0TThsN0RrSEZoZDllSmMzWHln?=
 =?utf-8?B?c2U0M0hYMG1IVWpNdzNzWnZ5Wk1CRUNqK2F1dUFmQk1wZWdtb3FQL250alpx?=
 =?utf-8?B?TVpWZU0wNUFsWFBBRTFKQ0JWZXE2SHNTS2tIQnlNazk2dUxJZnZEZWNaSTRG?=
 =?utf-8?B?SWt2ZE1OUHMrdXUxWmFod3ZHNDcrSFFQSHRDT2t6UThVaHpmVGJ6ZEl1aDYx?=
 =?utf-8?B?azBvdnJIN3Q2cHJaTklkS0xCUWY2WVUwT3hyL2dZNm5Jc3Nta0RyY0FKOHRE?=
 =?utf-8?B?MFVCWHNoVmNuZzRmcm5zTkxsQWY3YnBPTjhsamdDOTZibmdtQjd1T1AwdEpF?=
 =?utf-8?B?ajg1T0hEZDlmTzNpM2JKUENHQko4TjFJYWdwd2NVTmNaeHlNcEtUc25OWnFF?=
 =?utf-8?Q?lOohkn57WNAoQEnYjPcRuWAJ35DTlPy8uILd/hiD3U=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6009c503-9cf2-4b56-8bbb-08d9a84ea18e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2943.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 15:43:12.2254
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nh3z0xZEqPryCfiUlPFwsRvnuBH+k5dROsLEjXRdXUhJKWJj2iEMiK61AwgBbUTd1GJOfuVA5sCqTZ0fhj5NPuWbyVC8E3NKvXtt5u8uaZw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2944
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10169 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 mlxscore=0
 spamscore=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111150082
X-Proofpoint-GUID: 2VLeKiaJLLzfrrDhWTV1Otpbmx9CFMzz
X-Proofpoint-ORIG-GUID: 2VLeKiaJLLzfrrDhWTV1Otpbmx9CFMzz
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 11/12/21 06:59, Hannes Reinecke wrote:
> Fabrics commands might be sent to all queues, not just the admin one.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> ---
>   drivers/nvme/target/core.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
> index 5119c687de68..a3abbf50f7e0 100644
> --- a/drivers/nvme/target/core.c
> +++ b/drivers/nvme/target/core.c
> @@ -943,6 +943,8 @@ bool nvmet_req_init(struct nvmet_req *req, struct nvmet_cq *cq,
>   	if (unlikely(!req->sq->ctrl))
>   		/* will return an error for any non-connect command: */
>   		status = nvmet_parse_connect_cmd(req);
> +	else if (nvme_is_fabrics(req->cmd))
> +		status = nvmet_parse_fabrics_cmd(req);
>   	else if (likely(req->sq->qid != 0))
>   		status = nvmet_parse_io_cmd(req);
>   	else
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

-- 
Himanshu Madhani                                Oracle Linux Engineering