Message-ID: <96d26ba7-9553-adba-5341-8f071b0639d8@oracle.com>
Date:   Mon, 15 Nov 2021 09:19:43 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 01/12] crypto: add crypto_has_shash()
Content-Language: en-US
To:     Hannes Reinecke <hare@suse.de>, Sagi Grimberg <sagi@grimberg.me>
Cc:     Christoph Hellwig <hch@lst.de>, Keith Busch <keith.busch@wdc.com>,
        linux-nvme@lists.infradead.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        David Miller <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, Chaitanya Kulkarni <kch@nvidia.com>
References: <20211112125928.97318-1-hare@suse.de>
 <20211112125928.97318-2-hare@suse.de>
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
Organization: Oracle
In-Reply-To: <20211112125928.97318-2-hare@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnVyUGpHTmR1M29oWktTY2lPak9YYmVkTHBaa1BZSE9oay85WTRsVnlhWXZM?=
 =?utf-8?B?am9iemRlZ01IRStCaWtLdlVNOFhaQkVZSHFuM3hvcm9CVTZWS1JzQktyS3g5?=
 =?utf-8?B?UDBUeVUrazBnSGFYMGdmUHJseWJ4QXF1YVl2MTFzQ2RXS2VpeHhHcmFuUDhK?=
 =?utf-8?B?QzZxRHM2c0hjRVEwM1paa2xpVDEySC9EMVltR3pOeG5XQVBZS0xzYm01ZWlx?=
 =?utf-8?B?TEMrMkxjT3N3M1NSRnhXNGhZTDdya0hpR0d6MkphTnNjWTU3eGJkdHkyNVA3?=
 =?utf-8?B?dmY4NWdTY3lIbGUzUzVmRUJJV3FwUjUzNCtSeUtnUWNUMUtleDlrYUh5d01i?=
 =?utf-8?B?M2YwUEdDcG1qZVBubUMraXZQNlBwZUNvTS9UL2wyVDFMLzNSOFd3ZTdEMlgx?=
 =?utf-8?B?Ukh3RWd5c0JyeThtUXo4ZlNqL2Z4azhyVEhtZC94R0dvbXN1empWSHRjMFVU?=
 =?utf-8?B?K0lQZWN3NDRqWXBmODFqNDJaVUdzOUxwbXRlb1ltS005UmdFd3p6dUt2Qkdz?=
 =?utf-8?B?S210MzgzYytDRTl4b3ZTR3pUb0pXM0psNURScjMwcGgrMGZvbHFDakNqUUFF?=
 =?utf-8?B?SCtXMlFrMjBCNmhwQVZSUFFSY0pETkdKMHlUY3FMVVNISmxleDlRczJ3S0E4?=
 =?utf-8?B?MTNwR1NJSUxsWkJXbFVjTnNrUm9TNkdwSXBPTnYwb2x4dStsM1RJeHJ5dXMy?=
 =?utf-8?B?MjFVREJkMmNLSVVyV1YrekNPTXB2WUVCdzBNTERhYnBZbGlXTW5jUi9FVTdL?=
 =?utf-8?B?Z0tGdEpwcFpqanIrM3JjMWZrU25pdTY0V2NPVXNyTUpmRHYwMkUrSTkyek1Q?=
 =?utf-8?B?WG9KUG9SNlNrYWdMbFI1YytwTFpQL0Mxb0N0bnNBYWN4anNtdGRTSkhuTlhT?=
 =?utf-8?B?c1piVTVNTytzMUNGZzRBSEsxWWcyS205em5wVG9vSXREbHYrakpnVmwwQjBD?=
 =?utf-8?B?dUV1Z2daRzJkeDVmR2d0Wngrb3JTd0FPNXRLZEE0TC9jNHpvTEZHMDREdXJh?=
 =?utf-8?B?Sm5xWFZnR21RRDd4NHVGQjVYNnBaMnJidldNTENDdEZhOEQyQ09vR2VRYnpK?=
 =?utf-8?B?c2tPVE03VHRrL2U5ci82ZmczeS9qUklPUzQ4ajFkRmZCOExJWk1qbkpDMHpH?=
 =?utf-8?B?NUJTTnVPbzZsbk10Uk9XdGJsYU82dC94TUpsQ0YyRDBQcEFWWVRUM1JzQ1BG?=
 =?utf-8?B?cTd3ZjdYMVhhdUNKaGJueFJOT2ZLT1lKZGg1OWdISTJ6ZzJIN3dzaVc3RXdL?=
 =?utf-8?B?b1dEMktjSyswNmYrU1dPa2dJWGtNS0MwY0t2SW0rdFI5cmxSWHRJekZ3dmtE?=
 =?utf-8?B?MG9FcUdhY3Bna3IxZGxqVm8zMEVySU55Z3c3Q2ttZTRLRW11S2NWRkRMdEdK?=
 =?utf-8?B?ZXEvd3NkUTdqUklWQ0VoOTZBdlZISWc1V0JtcmRZMlNuYXlaMVNBTWc2U2dO?=
 =?utf-8?B?QXUrWXJqUlNTL1dzWmpLYjI3ZWJ0bTBycUREKzJnNkFteDVTeHdQaDZwblpr?=
 =?utf-8?B?bnlvOTNkUnR1RWcvQSsrd2Ztd3lacEszWUsxbHNDdmxZQklGay9BTHZ1aHlh?=
 =?utf-8?B?M0NsWndlakwyellmSUwraWlQRFFIaDRYcDBBUmNPc3UranpGVHZUd2twbnZi?=
 =?utf-8?B?ZDV0NlFLSE0yS0dMSTBVaXM2RFpkM1VmR285b3I1cmF6VmRJQWx1SHFycVJ5?=
 =?utf-8?B?aXo3T1FsUWdDdEtzcDkrZWlBaG0vQnpCYTRtWWZ0VlRpSThVTllhamo5RDRw?=
 =?utf-8?B?T3o2NE41aWNDZVZrYzZVblRja1RIYWN6cnR1V3BXSTR2ampNSytWNVVlcWQ3?=
 =?utf-8?B?akNLWVJCbW8rcnhGYlBkTThiWG9xdFVJVHdCMm1IWFRQZ0ZhNzFuaCtCejUx?=
 =?utf-8?B?TE1oTEZzamxJQ2ZQNjVJaHFEZEx1aUxCUHh4SUlEZXZBMFUwbzhRdUhvbExL?=
 =?utf-8?B?S0p4ay9xTEI4Y2tpUW1JQitPN2s1QTJGaVh5Ym5ubjM3bkdzNWxsN2tEYytP?=
 =?utf-8?B?TXRSdVR4dnV4a1k5WTE1OFhKNHU0Sm45T21pemg2RUxCSFN4M1JmV2Vja3pM?=
 =?utf-8?B?YUxjL3RMMWdLYVJNbHFyUmxzeHlsVXZzeHJqVlBaY2FZR3ExWndiZjNFazRw?=
 =?utf-8?B?Sm9uL2I0UzdUYk1qK05BVG9hbmdiV2kxS25VcDQ3Q0FxZ3lMMnBMcUo2QTBH?=
 =?utf-8?B?NnJPRVc1b0pQakpZQ25HRUFoZGJXSVZPK0lybVBjYUZVc21yWnVsR1l1OXZi?=
 =?utf-8?B?N1J1SkNZRWVIalRoQkUwN1ZVSmFRPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e21fb927-7834-42e6-96df-08d9a84b5b0e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2943.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 15:19:45.7739
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5jRY2Tfl0guwebVHpn+nBkamGqqHOF26EjmI5Ne79XBFNSKXzoKKJatwOWp3gcURQEFvjEZuYym9jt6zpPbtg4BMa1lJnZwyk1mo6w1zN8k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2720
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10168 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 mlxscore=0
 phishscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111150081
X-Proofpoint-GUID: xdFgLuClPDZrcEJEaoV1jLLS_BryPpDU
X-Proofpoint-ORIG-GUID: xdFgLuClPDZrcEJEaoV1jLLS_BryPpDU
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 11/12/21 06:59, Hannes Reinecke wrote:
> Add helper function to determine if a given synchronous hash is supported.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
>   crypto/shash.c        | 6 ++++++
>   include/crypto/hash.h | 2 ++
>   2 files changed, 8 insertions(+)
> 
> diff --git a/crypto/shash.c b/crypto/shash.c
> index 0a0a50cb694f..4c88e63b3350 100644
> --- a/crypto/shash.c
> +++ b/crypto/shash.c
> @@ -521,6 +521,12 @@ struct crypto_shash *crypto_alloc_shash(const char *alg_name, u32 type,
>   }
>   EXPORT_SYMBOL_GPL(crypto_alloc_shash);
>   
> +int crypto_has_shash(const char *alg_name, u32 type, u32 mask)
> +{
> +	return crypto_type_has_alg(alg_name, &crypto_shash_type, type, mask);
> +}
> +EXPORT_SYMBOL_GPL(crypto_has_shash);
> +
>   static int shash_prepare_alg(struct shash_alg *alg)
>   {
>   	struct crypto_alg *base = &alg->base;
> diff --git a/include/crypto/hash.h b/include/crypto/hash.h
> index f140e4643949..f5841992dc9b 100644
> --- a/include/crypto/hash.h
> +++ b/include/crypto/hash.h
> @@ -718,6 +718,8 @@ static inline void ahash_request_set_crypt(struct ahash_request *req,
>   struct crypto_shash *crypto_alloc_shash(const char *alg_name, u32 type,
>   					u32 mask);
>   
> +int crypto_has_shash(const char *alg_name, u32 type, u32 mask);
> +
>   static inline struct crypto_tfm *crypto_shash_tfm(struct crypto_shash *tfm)
>   {
>   	return &tfm->base;
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

-- 
Himanshu Madhani                                Oracle Linux Engineering