Message-ID: <78f35c6d-c7b5-f5c7-b658-00aac28674a5@nxp.com>
Date:   Thu, 18 Nov 2021 09:57:46 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH] crypto: caam: fix descriptor error when create ext4 fs on
 the device-mapper device
Content-Language: en-US
To:     Gaurav Jain <gaurav.jain@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Iuliana Prodan <iuliana.prodan@nxp.com>
Cc:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
References: <20211109095105.203960-1-gaurav.jain@nxp.com>
From:   =?UTF-8?Q?Horia_Geant=c4=83?= <horia.geanta@nxp.com>
In-Reply-To: <20211109095105.203960-1-gaurav.jain@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFNocUlYaFI3dVpybHZFak8vVm1YelVzam45ZjAvRkEvdGZINGlicjB2YXlm?=
 =?utf-8?B?eUlUYXdVVFQ2ZC9Ba0pUU0lTcXBYMUlHbldBMm1UdTAzR2ZFWTFEb0RQckNR?=
 =?utf-8?B?Zlo0RUJmSXlJSWMwaXFESjhEbGE3RzJkR3JVODNmNHlRak55bHQ4Rk8wZWo2?=
 =?utf-8?B?UnBFaWphSUtaUTE1V3NtL1BmZFF5MlgrN01FVDk0YW9mMjRLUCszOHlyS1lE?=
 =?utf-8?B?TWgvTDZhN0F4UkRtaHBKRlNrWC9OMVg4eDdWclEvT3U2Z3FTaFlBQkFxZGNB?=
 =?utf-8?B?U3dLSU9FUkxLNjNRdTZrZHJMRWMwWjNrTkVvT1I5ZXU3cjNBSlFJOHdPZlFt?=
 =?utf-8?B?Tjl6SEkya0tlOGlIbXQ5WkxjcXI3T3FOcjFaWndhS0NHN1l0ZVovU2xuUzVY?=
 =?utf-8?B?VVVnNTlhOWtpZngvWDk5bEhYRS9taEZySjdTOUJNSnJndk5QL0svcE9kKzNM?=
 =?utf-8?B?K2FxNHJIa0VvRnh5QWZqWHh4TVpvTG5HTWRKaUlVUHE0NTZDK0VDdllQWG51?=
 =?utf-8?B?Y1AxUGNuV0FhSkxTd285aEx0Y3B2eG9FQjdKVlh1ZUNwa3l5NnJ1Z0kreTBW?=
 =?utf-8?B?WG5hZ2cvV0ErY1hGQnRCUFNVQmV3NU54QkdCWDhtNEhkdDN0bjFNYUtTZ0Jy?=
 =?utf-8?B?N1lFV0Z4T0lORytFOTliallQNjlnTDhwdzVvaTdPdmh1WXNTdEhqWUk3UGpR?=
 =?utf-8?B?cG15V2hUcmdvbndBOUE0SXVKZG1wQXJpbXRjRVJ5M2NQQnIwMlNIRDM1STJS?=
 =?utf-8?B?WEl6UE9qbUxMV05rWm5jZjI5MUpEbVpaRTgwZnJkYjZiSXNoT0pZTnl6dTNp?=
 =?utf-8?B?NmQ1eENZRWU3ZVhwdXh6ZWNoRTFoUzRzRE5qcXI4Z051Q2lVd3RTcWlYQWNr?=
 =?utf-8?B?UTg4U0JUZ1Q1SzFDK3k2bHBMbVY5MzU4czcwMzl3UE5wczlYL0ExMzFpN05Q?=
 =?utf-8?B?ZVRPR0RxSStrUzNqaE9maDFPNytaMHlQVXFUVmlWUTFtbUhyUDRDeWJEYXJW?=
 =?utf-8?B?WDU5S2dGMkMzM3RZUUpvZVFlR0tkT0lqdkdrdktmc3lWTXFBNGNaTlJkd2I3?=
 =?utf-8?B?bzBBZlBBRXR3SFNvek1WOXVtQUJ2cDdrU3ptUkdhRXFMNUJKZlcxcGk0cks3?=
 =?utf-8?B?bWV3R1Nob0lrd1I4N1BQeDdUdEs1Q2ZtN2hPYkdiV3psRmZqeEhicThDT3po?=
 =?utf-8?B?eUtjZjB4YkRuOFYwRGZ6c0JFbzlsczVPci8xaDFNZkVLNTdWcXhXQ3FFRWFU?=
 =?utf-8?B?YVkza3drdE9iVFFIQU9ETmVJcVVJTzFucGowWkdNYmtoZURKWVNoVHJtVVVv?=
 =?utf-8?B?RXVpdDNyN0s1ODAwZi83OHJhcitGdWVsQmF5MlgwZXpzYjE5TWNrYmFHWUZX?=
 =?utf-8?B?RjFHZkFXdjVsb0MyWlEvZEpXN0MwaEU3SHNidHB2MDQvdFYwL29XdDdqallP?=
 =?utf-8?B?RWlEeUFaYWxJUC91dzFkRDlveHgwYjg5amwzdE81cnZzSFo5a0NnbWR4Y3Mv?=
 =?utf-8?B?ZXI5ZFFRMXUrMHY5ZUtaR3R3em5EbU0xRTM1U2svRGR1VHVQSTdjdGhqdHBK?=
 =?utf-8?B?L3lQOEJHN2Z6OXVUSEdXeXVCcy9haGZrU2lyMTJweUN1bVdHeG12bGdYMFBa?=
 =?utf-8?B?QlVzeHZScXdMZndjUU1Cei8wK256M0RiT0tEWG1qMEF1cXV6WmlWWUJTQWpH?=
 =?utf-8?B?YVBGWGR0VXhqRFV2c0tqRG5rSVd3NUQrOXVsTWI4bllwbWEzeTRXWGlud0c5?=
 =?utf-8?B?RHdFb0NzcXdJTFg3bkhaWjJvWmtLdWlsaGFVNkpZcGxuZFlHVmFMVWdncno3?=
 =?utf-8?B?QjArMitrT3JLVHFMS0I3cHZBTmR3N0l0VTFrSkxYYmQwem9iQTFsQVQzTmtP?=
 =?utf-8?B?dWVsdXRwcWdHLzRBRTRDSTh1eTlxVXdwNmtSbGoreE1nWFN1ZWVvTEpyZnNB?=
 =?utf-8?B?ekZBR2xaeU1IeHlqbmVnYXE4NkNRVEdvTENBNGJOZm85UERGVm9XdTBrMDg5?=
 =?utf-8?B?aVFBMjM0SXZYRER1ZU1xSnh1Q3g2bjBleUh5dVc2S1p2UkQ5d2VQaTlRSldZ?=
 =?utf-8?B?WVYrOVBvYm8vU1ArbWhUSnFGWHhkUS93QTJvQS9rcTFTS1pZUGF6UjVSU2NP?=
 =?utf-8?B?YUVnc3Y0TGNpalZJQ3FEcS95SEI0d3NsKzZGbkQwckQ2NElhbTdIVjNIMHg5?=
 =?utf-8?Q?Q9gloy+z0KmoOeu+OZ9lwlw=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5647ac7-f0aa-4d3a-9d76-08d9aa691dd8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 07:57:50.0008
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +6P9B1rI3tLQT5YvPAvZsfNpDYNaVtnwLr3gyJVsoqgSSZPl/HAihIergZtFI8t/gqxLgSJqeCqevKKsQyVGmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5039
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 11/9/2021 11:51 AM, Gaurav Jain wrote:
> Root cause:
> When caam queue is full (-ENOSPC), caam frees descriptor memory.
> crypto-engine checks if retry support is true and h/w queue
> is full(-ENOSPC), then requeue the crypto request.
> During processing the requested descriptor again, caam gives below error.
> (caam_jr 30902000.jr: 40000006: DECO: desc idx 0: Invalid KEY Command).
> 
> This patch adds a check to return when caam input ring is full
> and retry support is true. so descriptor memory is not freed
> and requeued request can be processed again.
> 
This approach is fine for a fix, to keep it small.

IMO it would be better to modify caam driver to use the crypto_engine callbacks
(prepare_request, unprepare_request).

> Fixes: 2d653936eb2cf ("crypto: caam - enable crypto-engine retry mechanism")
> Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
> Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
Initial upstream patch submission should not carry the R-b tags gathered
during internal reviews.

Patch looks good, thanks.
However the subject should change to something more generic,
given the root cause.

Horia