Message-ID: <d45c25c1-1cb5-cde2-3152-3920200a8b3d@nxp.com>
Date:   Thu, 18 Nov 2021 10:21:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH v2] driver: crypto: caam: replace this_cpu_ptr with
 raw_cpu_ptr
Content-Language: en-US
To:     Meng Li <Meng.Li@windriver.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>
Cc:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20211101031353.2119-1-Meng.Li@windriver.com>
From:   =?UTF-8?Q?Horia_Geant=c4=83?= <horia.geanta@nxp.com>
In-Reply-To: <20211101031353.2119-1-Meng.Li@windriver.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGo1Yy8vSTdqcW4zTWVvaWhzSU54dml1UFFUWEt6aVdqQW1XRitsQ01YTU1F?=
 =?utf-8?B?SGkvSENnQlVQZUVFVnpFYldXQjhyZld1T1U2aCthbGNPVmxvaldrUGl4WlhR?=
 =?utf-8?B?YTZnMzhZMDdKVEM3QmVEbkxVV0U2b1NTcUVRblkzZ1ZYYStreXIzWUNQK1Mr?=
 =?utf-8?B?ZTd1LzNjSHZJemcrLzdCbUkvM1RzKzBCWnpkdDh5TGdtdytQQnV2UzJ5enNh?=
 =?utf-8?B?NEFmY0tuN3pweDFzaWtVbjBTNmpUcnk5MC9HbkVJVVFCUFBORFIxTlJBa3FO?=
 =?utf-8?B?ZlJ1bng5dWxFRGFmeWNPQnprUjBYcEhXcUs3K29iS2RIQmZobXd3Sko3TTI0?=
 =?utf-8?B?cDdGWjhZTFRkRjNXSlU4aE9sNG5EWmhGN3FWTUYrVjFuWUhUaE5Ya2NvZk44?=
 =?utf-8?B?YzVHY1A5L2d2NTdYZThsQXNsTWZJNVMvQTZ4YjRNU0toRjMzSlBJVWhwMlox?=
 =?utf-8?B?MWh6V0lSUGpkKzVYVDhIaGxXZ1Jnd0h2eE5XR2ZHM3NDY3REd3l0UUlHV1pN?=
 =?utf-8?B?Y1hQQk05S1RGUjNUQjFra2h5QUVoR1U1ZVY2eWZhZVVZdUltUkhQc0hsNWhx?=
 =?utf-8?B?Z01ldkJlejY4ZXJkYnJCaXUyZHd1UUpWQVY0eDBJWkYvNUNjRGhuWXB2SDlz?=
 =?utf-8?B?YjJoR1FMcXlka3dVU01BdFgvd1YrWlViM1A4QUpBV1lTQi95NmpVSVpST2tM?=
 =?utf-8?B?RUhHV2IvODJMZVZMeFZua05iQnhac0J0RG1BV1NBMkVCOGxENHlIR25uL2xY?=
 =?utf-8?B?OGFwMitzRVRIVTJrSjBvN3lWU21hbHk1d0QwSzFGaFNseFBsd1llRWFhWFRu?=
 =?utf-8?B?RnMwSnFXdTlHVTZ0MTRIQnpwL3Y4c21xU3lCRis1b0dFcFNkN3JLSEM0Q1Ev?=
 =?utf-8?B?OXVUUnRzTmlIQncwSXl4cU1SeFpiWEk4c1dCKy8rS2o1K2ZYUFVnQnhWN0V6?=
 =?utf-8?B?M3dFTDlNaVhTRUFHTiszVTJBcGJyc0I0K3FGMGR2TDFleWhhSWU4REZVTDRV?=
 =?utf-8?B?ejVRN0h5Qm9hNFVabFVaVTBkRWZhTjR4Rm9tL0pWK2ZHM0ZTOTdUMmRWYWIw?=
 =?utf-8?B?MHZ0aVZ0UFFmT0Y5MXZoWjA3YTZvbUJPWTdYbDQzRWcxd083Z1J4UlhRZ2Rv?=
 =?utf-8?B?U0NjZWFzTDJBcHo2YllOa1NidUdxb0xZZjZvMUhMbUFqdWp5QkJlNFg3RzhU?=
 =?utf-8?B?R3JRb3VkQ0x5VFhmM0hFZkdSSHJpOVhFenlrY09ydCtRd0lSVDdWL1AvSzFw?=
 =?utf-8?B?UUVzcWp0WktBb1BlMmFCb3lhSVJSQnZBZXkyeUsrRGozcUhuMlNJSDBLRWc4?=
 =?utf-8?B?b3liTFdhTE15Y1REMm5IbktJMnV4TEVnOHZ0ZllTYVhtL1Bib0RxdHJ6L2hW?=
 =?utf-8?B?RjhNOWE0c0N5aXRGN3RkU2FMU1Y1VGZoNnY5dkh5bG1GZEt2K1BCaUtaODBv?=
 =?utf-8?B?ZVFYK1lBSkd1Vkt0WmJuR0lmYWZEdmpLOUZzdjlHN1NTK0thRE45S0ZrMnJR?=
 =?utf-8?B?TEhBTTFTRDRyaERqWnd3L05MbnNlMnZLdWJSSmwyOWpqM3VUNTB5MlF5VjJJ?=
 =?utf-8?B?cFlpRWVFMDNKRjFCckxGZWpXVjhzZjl0aDlsQ01kc1BmcmJkYjkzNmpvMStT?=
 =?utf-8?B?NjdkZ3ZQOGtMT2xFL2hUbndSdlBLK2dkVXZSUEJMMzE4UlMyUTNGSzBSWlJV?=
 =?utf-8?B?YjQ3WlFyM2tRS2NndW5USlBNVHROdnNORGE5K0ovTGtGOUdqV21FOWdTVlFn?=
 =?utf-8?B?cjZUdk1rT0dPMjJ6TW9yemtiUWZ2eS8wbEF2Ukh2a0RhdHVIYWdkVnVsTG92?=
 =?utf-8?B?MUtlR0YzdzYvVHVjK3lkcVlXYkhrbGNZRllTL2xUUVdQQnl1aXUyWENibVhK?=
 =?utf-8?B?UU5JNm9sckRTWmdsK3ZwUHh0ZTZ4WlhuUm5mNzlScG5ZU3NlNkpPSFlTaUo1?=
 =?utf-8?B?Ky9PcE4xQXE2TUcxNlUyZVhZbWxGcUNDQ0Nza3NySHJlMGUzL0V5SUhkV2p5?=
 =?utf-8?B?dVcvWkhmZ05YcjFEOVB4eEdtV1Vjd2ljUHNFeUdFUzJrMXdFRDUvcXVXWGRF?=
 =?utf-8?B?Njhjd0tSMTFYTlRqOHU0dGxQMDROTVFsODdMNWtvWVAzUmtUOEZ0ZzVFMVBu?=
 =?utf-8?B?aThPaWR3S3VJWWtzWE5oeHJhRlZySmQ2UkZxSVV2ajlMa2tsOGVIZXhVY0FO?=
 =?utf-8?Q?uKnLuOIEqdd/bwtstIywtsU=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5eaaa38-b151-42ab-a03d-08d9aa6c67f7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 08:21:22.8356
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U0721R63uuNMWlD0Xpggm9fGHIK7IYe+73JVKgFxnvXmNsVJ23eNjJ8tTV1bhalYLT5oGQL7vM89W+1cPQ+XaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3983
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 11/1/2021 5:14 AM, Meng Li wrote:
> When enable the kernel debug config, there is below calltrace detected:
> BUG: using smp_processor_id() in preemptible [00000000] code: cryptomgr_test/339
> caller is debug_smp_processor_id+0x20/0x30
> CPU: 9 PID: 339 Comm: cryptomgr_test Not tainted 5.10.63-yocto-standard #1
> Hardware name: NXP Layerscape LX2160ARDB (DT)
> Call trace:
>  dump_backtrace+0x0/0x1a0
>  show_stack+0x24/0x30
>  dump_stack+0xf0/0x13c
>  check_preemption_disabled+0x100/0x110
>  debug_smp_processor_id+0x20/0x30
>  dpaa2_caam_enqueue+0x10c/0x25c
>  ......
>  cryptomgr_test+0x38/0x60
>  kthread+0x158/0x164
>  ret_from_fork+0x10/0x38
> According to the comment in commit ac5d15b4519f("crypto: caam/qi2
>  - use affine DPIOs "), because preemption is no longer disabled
> while trying to enqueue an FQID, it might be possible to run the
> enqueue on a different CPU(due to migration, when in process context),
> however this wouldn't be a functionality issue. But there will be
> above calltrace when enable kernel debug config. So, replace this_cpu_ptr
> with raw_cpu_ptr to avoid above call trace.
> 
> Fixes: ac5d15b4519f ("crypto: caam/qi2 - use affine DPIOs")
> Cc: stable@vger.kernel.org
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
Reviewed-by: Horia Geantă <horia.geanta@nxp.com>

Thanks,
Horia