From:   John Haxby <john.haxby@oracle.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Stephan Mueller <smueller@chronox.de>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>, Tso Ted <tytso@mit.edu>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        Willy Tarreau <w@1wt.eu>, Nicolai Stange <nstange@suse.de>,
        LKML <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        "Alexander E. Patrakov" <patrakov@gmail.com>,
        "Ahmed S. Darwish" <darwish.07@gmail.com>,
        Matthew Garrett <mjg59@srcf.ucam.org>,
        Vito Caputo <vcaputo@pengaru.com>,
        Andreas Dilger <adilger.kernel@dilger.ca>,
        Jan Kara <jack@suse.cz>, Ray Strode <rstrode@redhat.com>,
        William Jon McCann <mccann@jhu.edu>,
        zhangjs <zachary@baishancloud.com>,
        Andy Lutomirski <luto@kernel.org>,
        Florian Weimer <fweimer@redhat.com>,
        Lennart Poettering <mzxreary@0pointer.de>,
        Peter Matthias <matthias.peter@bsi.bund.de>,
        Marcelo Henrique Cerri <marcelo.cerri@canonical.com>,
        Neil Horman <nhorman@redhat.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Julia Lawall <julia.lawall@inria.fr>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Andy Lavr <andy.lavr@gmail.com>,
        Eric Biggers <ebiggers@kernel.org>,
        Petr Tesarik <ptesarik@suse.cz>,
        Alexander Lobakin <alobakin@mailbox.org>,
        Jirka Hladky <jhladky@redhat.com>
Subject: Re: [PATCH v43 01/15] Linux Random Number Generator
Thread-Topic: [PATCH v43 01/15] Linux Random Number Generator
Thread-Index: AQHX3vewWy39tI151EiqhdM1dyRTOqwOlDWAgABzKYCAAAewAIAAtsMA
Date:   Mon, 22 Nov 2021 16:56:24 +0000
Message-ID: <DBF8E8A8-9968-4E81-8C6E-7BAD0C3F39FA@oracle.com>
References: <2036923.9o76ZdvQCi@positron.chronox.de>
 <4641592.OV4Wx5bFTl@positron.chronox.de>
 <CAHmME9oaS4TOpk7rQ73BRKeVLjMUNyt6EFyeOX=hZSkFBPDu0g@mail.gmail.com>
 <2560758.ogP2UNPRoF@tauon.chronox.de> <YZsyZua9T8DD6JF5@kroah.com>
In-Reply-To: <YZsyZua9T8DD6JF5@kroah.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QPA06ysDG7fgPtgAeyF6XKpMWiTu7Q/+6HUwjekkOH7QUL1y2MIMW0N/FgZF?=
 =?us-ascii?Q?c6K8kA8G7Cvcabb0G0eUxyv3BLtv1ugrrcUGn8FG8DWCRGusEWAIe+985NbP?=
 =?us-ascii?Q?+j7HJJeqO7E0KeCfUNpCxBLTZNTU/AB+GKguYBKJ9sfoU48I9odLLU9nuGdC?=
 =?us-ascii?Q?YYdJOaCB60rjPugzhDg/zkyJb3MfT8RYKcojpyx21Izo5alsjZM/OWSXql/y?=
 =?us-ascii?Q?dyhHr/otIoW658sZfpuAm4oV4/VJqLKR+B2DSqgUbJOEyq2WE+wt3xaTWigt?=
 =?us-ascii?Q?fC6XJ9aDic11LXSGvtbj6TpmUPWIwq796K7q8NaPsR645aBPjRN0HBQD/qxc?=
 =?us-ascii?Q?H/4vzb9H515F9FgZSbR94Isyfb/2n+xA+A0cvLohSP3mLnpMKr+fp8d2jHBa?=
 =?us-ascii?Q?zcCuxlTB+f8kZMRzsX2ehFxo7CmQqdj+GNeyzn0wQES5hWe+dD/6Jx08hrnB?=
 =?us-ascii?Q?FAP5B1L1qdmnOS5TAC6fgYMFpPFkzfl8Qzcu3KF26PDEqTOFKih7ZYCeS8jD?=
 =?us-ascii?Q?HOW+Q0Rj0dgtG9SS84s2DWFMlj9+Wt9M6PQVEbfSYI65kuf18eGi943C6W1s?=
 =?us-ascii?Q?rQGgRRZPXYxtejatT7F9oiPAx2HdeYfbytg8WGV/e9OPZrS7h2RmoAtBV+ab?=
 =?us-ascii?Q?3T051kl6VldlbbivH/T64D6ZZGzOwGLSrQ7Bop0nLZEjuUQRzwSOHylsbO/3?=
 =?us-ascii?Q?PcfvJKU7ebGYw8yb4NflG4RrvagsyiG+WVvvgHWRJomqXBQBM0bjRCCUmZLa?=
 =?us-ascii?Q?xACTvjEFh6UDcpqP8i2t6Kb7O1fwO5KOVyMAx9tp8oegbzlAifgQoR+bPXQf?=
 =?us-ascii?Q?Ftp0DnjX3SOPCD7mUzarzC25fHY+mWHk+GYtmpN6uXgoMcmJ61Z4jUHI5OBX?=
 =?us-ascii?Q?fHZFy3P6mQ/33o3pBVjG9Wz4+58gv6TuMTPu7pNLKnKYNRxxvxPyTeD5V+lm?=
 =?us-ascii?Q?Fl5tVIoqkHYbeePCZst0rnS13cr/rIdCuCDW7Lqe63KOmOpOZHXpAkq/A2ct?=
 =?us-ascii?Q?ho5Vd2hBgZCounWUj0yqeJvlebz++p5p70RP9dsEkHDr7rAsxU/yOPhWJC2U?=
 =?us-ascii?Q?7Ymdr4IZ/SMQGDu5eYZCaS4gk/9vjRbWAXVqi5AB8oyfprtLQt2AFzWCvsvL?=
 =?us-ascii?Q?tvHJKxXQD/FwoioPGshk6l36RHV+enEbq7DVWQPPolw2x89O40o4Ss4rCMQd?=
 =?us-ascii?Q?uTzzBJVQ0gXLu/4ukogbv9VzY8sLOGm4sMeeq5/Z/m9CsKvIzs2PzX8qtrOM?=
 =?us-ascii?Q?rueuaxL4v5n8h0/yRcH1K5jX/gKiRT2T3h1q5rxLgLfV9gIBwuo/tEJOXsBZ?=
 =?us-ascii?Q?MWH21yh71sWjkzewOnnLp6jO4jiDssJxuA6QT9xKT/tJ6gCtKTnDUZ+TufU2?=
 =?us-ascii?Q?fnXuUOm8+oMyNXzEmZISB5Qs5EbJ29BEZnjRjxA7JqemJGCkZbeTSuV+r8hP?=
 =?us-ascii?Q?O7L5YiMSOL2yiosS3rRlIDtiL4Vcqld/T1XVWOQOUXKePpaJX51QM1zx+soV?=
 =?us-ascii?Q?D8xE7B9L1iDdflhBVnN5D32v0y1VfFapd5dy80+GukEg4iUyOuTt3IkjQE3U?=
 =?us-ascii?Q?DpQoEX4MgPxagNrju5lYRwAaUOY4TFQF98LV6qQFMCCNliYNVlRqpJLpnruV?=
 =?us-ascii?Q?qWGaIC5ad0CfJUmHaKrchVuN6wHr2/2GMtRjD59ZtneLC06oa++CQ/5Oy6aA?=
 =?us-ascii?Q?bwUb5VLmGGzpQsIhcVeZBs90/JM=3D?=
Content-Type: multipart/signed;
        boundary="Apple-Mail=_9F5EAF58-C5F3-4D88-93EB-779CDF09FF15";
        protocol="application/pgp-signature";
        micalg=pgp-sha256
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5660.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81ca20a9-ea5b-4750-dda3-08d9add904c9
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2021 16:56:24.8088
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Lns60f737IKgUtatkQLDmeo2vOZX020AGAF6ZmIBceJB/viVnT1X3jYd7mYj3Z6cYksu4RmKV0GTE4DadsIOWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5563
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10176 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 spamscore=0
 bulkscore=0 suspectscore=0 mlxscore=0 mlxlogscore=940 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111220086
X-Proofpoint-GUID: btFop3_DQ2U1Tb3M6mKwK1urQNNCW5Vf
X-Proofpoint-ORIG-GUID: btFop3_DQ2U1Tb3M6mKwK1urQNNCW5Vf
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

--Apple-Mail=_9F5EAF58-C5F3-4D88-93EB-779CDF09FF15
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii


> On 22 Nov 2021, at 06:02, Greg Kroah-Hartman =
<gregkh@linuxfoundation.org> wrote:
>=20
> On Mon, Nov 22, 2021 at 06:34:43AM +0100, Stephan Mueller wrote:
>> Am Sonntag, 21. November 2021, 23:42:33 CET schrieb Jason A. =
Donenfeld:
>>=20
>> Hi Jason,
>>=20
>>> Hi Stephan,
>>>=20
>>> You've posted it again, and yet I still believe this is not the
>>> correct design or direction. I do not think the explicit goal of
>>> extended configurability ("flexibility") or the explicit goal of =
being
>>> FIPS compatible represent good directions, and I think this =
introduces
>>> new problems rather than solving any existing ones.
>>=20
>> The members from the Linux distributions that are on copy on this may =
tell you
>> a different story. They all developed their own downstream patches to =
somehow
>> add the flexibility that is needed for them. So, we have a great deal =
of
>> fragmentation at the resting-foundation of Linux cryptography.
>=20
> What distros specifically have patches in their kernels that do
> different things to the random code path?  Do you have pointers to =
those
> patches anywhere?  Why have the distros not submitted their changes
> upstream?
>=20

We (Oracle) are carrying such a patch at the moment.  We want this patch =
to be a temporary workaround simply to get FIPS certification in the =
current kernel.

We're carrying this patch simply because the certification requirements =
changed and this was the quickest and easiest way to workaround today's =
problem.  It won't fix tomorrow's problem and next time we, and others, =
attempt FIPS certification then we, and others, will need a different =
/dev/random because neither the old one nor our quick and dirty =
workaround will actually be acceptable.

The commit we're carrying at the moment is here: =
https://github.com/oracle/linux-uek/commit/5ebe83413c7573d566e581461bc95f9=
f139c5d4d -- you'll notice that we have a different RNG in fips mode =
compared to normal mode.

We really don't want to have to work out a new hack for future FIPS =
certifications and I'm sure no other distros want to do that either.

Personally, I'd far rather have any fips-certifiable /dev/random drivers =
be in mainline where everyone gets the same thing.  I don't like =
carrying out-of-tree patches like this, it's not healthy.

jch


> thanks,
>=20
> greg k-h


--Apple-Mail=_9F5EAF58-C5F3-4D88-93EB-779CDF09FF15
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iHUEAREIAB0WIQT+pxvb11CFWUkNSOVFC7t+lC+jyAUCYZvLtgAKCRBFC7t+lC+j
yP09AP9pwIKmNQRjv+XK88yZQp8qcSqUa5KApJgORWU9Zv5w2wD+JK/OinXAN6nw
Sz0VLGuXGQ6D8F4NdK6b+9RcOBc0GHo=
=1QIx
-----END PGP SIGNATURE-----

--Apple-Mail=_9F5EAF58-C5F3-4D88-93EB-779CDF09FF15--